Commit Graph

2679 Commits

Author SHA1 Message Date
Andrew
d325332090 refactor(Scripts/OHF): Clean up script files (#17724) 2023-11-15 20:44:39 -03:00
Andrew
db851b483e refactor(Scripts/RuinsOfAhnQiraj): Clean up script files (#17723) 2023-11-15 20:41:56 -03:00
Andrew
b0cf308be2 fix(Scripts/SSC): Respawn Leotheras and fix last phase transition (#17720) 2023-11-15 18:59:03 -03:00
Andrew
03612e8bff refactor(Scripts/TempleOfAhnQiraj): Clean up script files (#17718)
* refactor(Scripts/TempleOfAhnQiraj): Clean up script files

* Update src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_fankriss.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/scripts/Kalimdor/TempleOfAhnQiraj/boss_ouro.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-11-15 14:17:29 -03:00
Andrew
a0f66edcec fix(Scripts/Karazhan): Fix being able to interact with Nightbane's doors (#17713)
fix(Scripts/Karazhan): Fix being able to interact with NIghtbane's doors
2023-11-15 13:35:32 +01:00
Andrew
c4722de46a fix(Scripts/Karazhan): Fix Temptation target (#17710) 2023-11-14 20:09:25 -03:00
Andrew
a19613df86 fix(Scripts/Karazhan): Use actual spell interruption timers to handle… (#17709)
fix(Scripts/Karazhan): Use actual spell interruption timers to handle basic ability cast
2023-11-14 18:50:45 -03:00
Andrew
d9e12f7a46 fix(Scripts/Karazhan): Implement Aran's Atiesh interaction (#17692) 2023-11-14 14:49:05 -03:00
KJack
3d20f8902b feat(Core/Instance): InstanceScript: create Remove functions (#17702)
InstanceScript: create `Remove` helper functions
2023-11-14 08:13:28 -03:00
avarishd
4cb25b4b5e fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds (#17667)
* fix(Scripts/DurnholdeKeep): Captain Skarloc spawning double/wrong adds

* Ss

* DoForAllSummons
2023-11-14 08:53:17 +01:00
KJack
4fabaee597 fix(Scripts/ZulGurub): Jeklik (Bat Boss) - fix double-run scheduler (#17693)
* Don't double-run scheduler. Only run out of combat when needed.

* Comment clarification

* Rename variable

* Replace janky scheduling with `DespawnOnEvade()`
2023-11-13 03:42:16 -03:00
Andrew
bbedb91e2c fix(Scripts/Karazhan): Implement Nightbane summon emote and despawn on evade (#17690)
* fix(Scripts/Karazhan): Implement summon emote and despawn on evade

* missing flag
2023-11-13 01:39:14 -03:00
Grimgravy
6486f72740 fix(Script/Quest): Improve A Spirit Ally? (#16893)
* fix(db/Quest): Improve A Spirit Ally?

* Update spell_quest.cpp

* improvement in position
2023-11-12 17:52:49 +01:00
avarishd
67811a6369 fix(Script/Spell): Carinda's Scroll of Retribution usable on players (#17601) 2023-11-12 16:32:16 +01:00
KJack
3c8adc71cd (Scripts/AI) ZG20: Jeklik (Bat Boss) - Implement Bat Riders, other fixes and improvements (#17573)
---------

Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-12 09:35:35 +01:00
Kitzunu
bbadc32bea Revert Visibility Notifier changes (#17682)
* Revert "fix(Core/Grid): Implement missing GridUnload setting (#17569)"

This reverts commit 79b39f9655.

* Revert "fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)"

This reverts commit 60e27511c5.

* Revert "fix(Core): GridCleanUpDelay Log (#17436)"

This reverts commit 90b16ca065.

* Revert "feat(Core/Grids): Implement visibility notifier (#15919)"

This reverts commit 2779833768.
2023-11-12 00:48:49 +01:00
Dan
e1aa26f92d fix(Scripts/SSC): make sure adds properly respawn and DoAction only fires on Tidalvess alive (#17680)
initial commit
2023-11-11 23:20:26 +01:00
Dan
32ff556a99 fix(Scripts/SSC): make Fathomlord use his Spitfire Totem ability (#17674)
* initial

* new spell/aurascript format

* leftover
2023-11-11 19:45:21 +01:00
Dan
203536526c fix(Scripts/TheEye): Void Reaver sniffed timers (#17676)
initial commit
2023-11-11 19:34:42 +01:00
Dan
8f81a08455 fix(Scripts/SSC): make sure Insidious Whispers demons don't instantly despawn (#17672)
* initial commit

* reset threat list

threat should drop on any phase transition
2023-11-11 19:00:52 +01:00
KJack
896e7c5656 (Scripts/AI) ZG20: Improvements to Thekal (Tiger Boss) (#17603)
Co-authored-by: AG <43139552+AGandrup@users.noreply.github.com>
2023-11-11 08:13:43 +01:00
KJack
f7fdc7cb6c refactor(Scripts/RuinsOfAhnQiraj)Ç AQ20: Modernize Kurinnaxx (#17671) 2023-11-10 18:59:46 -03:00
Ludwig
cb483d124f fix(Script/Spell): fix AOE circle bug on Midsummer Torch Catching (#17654)
* fix(Spells/Midsummer): fix script for spell 46747 SPELL_FLING_TORCH_DUMMY

* SpellInfoCorrections: fix target of spell 46747 Fling torch

* DB: assign spell 46747 Fling torch to item 34833 Unlit Torches

* remove whitespaces at src/server/game/Spells/SpellInfoCorrections.cpp:4610
2023-11-09 00:19:57 +01:00
Dan
145b14c567 refactor(Scripts/TheEye): High Astromancer Solarian script refactored using taskscheduler (#17653)
* initial commit

* some fixes

* remove leftovers

* no attack during invisibility
2023-11-07 22:13:23 +01:00
avarishd
9c09ddc3df fix(DB/Creature): Hellfire Peninsula - Stonescythe mobs (#17604)
fix(DB/Creature): HFP - Stonescythe mobs
2023-11-02 08:54:11 -03:00
avarishd
bc688c2a51 fix(Core/Spells): Script Choking Vines (#17615)
* fix(DB/Custom): Choking Vines should stack from different sources

* script spell

* comment
2023-11-02 08:53:45 -03:00
KJack
751ffc7c70 feat(Core/Hooks): Add OnAfterDatabaseLoadCreatureTemplates hook (#17621)
* Add OnAfterDatabaseLoadCreatureTemplates hook
- fix issue where the fast template cache was not updated correctly after a CS reload of a single creature template

* Parameter naming tweak to reduce confusion.

* Refactor to streamline fastcache creation, remove threading concerns

* Remove unneeded resize when loading creature templates

* Update fast cache resizing to highest-performing option
2023-10-31 06:58:45 -03:00
avarishd
0679789120 fix(Core/Spells): T5 Holy Paladin 2 set (#17566)
* fix(Core/Spells): T5 Holy Paladin 2 set

* thanks notepad (don't ask)
2023-10-29 23:36:27 +01:00
Kitzunu
f757e93da5 refactor(Core/Misc): Make DeathState enum class (#17607) 2023-10-28 10:54:03 +02:00
Andrew
3dcbe649dd fix(Scripts/Karazhan): Fix Flame Wreath affecting pets (#17581) 2023-10-25 19:01:15 -03:00
KJack
632b55faa5 fix (Scripts/ICC): Make Valithria starting health dynamic, fix broken channeling spell (#17586)
* Make Valithria starting health dynamic based on actual max health

* Fix Risen Archmage broken spell channel and combat log spam
2023-10-25 18:53:00 -03:00
Andrew
41dba1affb fix(Scripts/ObsidianSanctum): Fix Tenebron respawning (#17576)
fix(Scripts/ObsidianSanctum): Fix Shadron respawning
2023-10-25 06:14:09 -03:00
AG
60e27511c5 fix(Core/Grid): Address bugs and performance issues introduced by visibility notifier implementation (#17480)
* Bug fixes

- Corrected std::chrono from seconds to milliseconds
- Got rid of leftover code that caused objects to not show up on time

* Removed logic to set gameobject as active

- More alignement with TC.
- Reduces CPU usage drastically

* Revert back to using time_t instead of std chrono

* Invoke SetNoCreate() method to reduce CPU usage drastically

* Remove setActive from static and motion transports

* Fix performance issues

* Added SetFarVisible to WG and some dungeon scripts

- Also removed setActive(true) from creatures in Wintergrasp. As for gameobjects they are set to active upon being damaged/destroyed and removed from active on rebuild (reset)

* Removed comments related to VISIBILITY_COMPENSATION

* Fix log

* Deleted unused files + corrected a check

* Added missing header

* Removed unused parameter

* Removed another unsued parameter

* Changed vector to set for i_visibleNow

- Changed vector to set for i_visibleNow in VisibleNotifer
- Adjusted HaveAtClient to accept Object*
- Adjusted SendUpdateToPlayer to send createobject packet only if not known to client
2023-10-23 05:37:11 -03:00
Andrew
a56a224bd7 fix(Scripts/Karazhan): Update Aran with the new OnPowerUpdate() hook (#17561) 2023-10-23 05:28:29 -03:00
Andrew
69418ab936 fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the… (#17562)
* fix(Scripts/Ulduar): Don't treat Algalon respawns as if they were the first pull

* Update boss_algalon_the_observer.cpp
2023-10-22 15:12:30 +02:00
Grimgravy
1262bbd237 fix(DB/Quest): Improve The Summoning Chamber (#16588)
* fix(DB/quest): The Summoning Chamber

* update

* improvement

* update

* update

* Update rev_1687180111436507500.sql

* improvement
2023-10-22 13:12:18 +02:00
Andrew
4e41a02be2 fix(Scripts/Karazhan): Implement the side entrance door area trigger … (#17556)
fix(Scripts/Karazhan): Implement the side entrance door area trigger handling
2023-10-21 22:52:07 -03:00
podmepodme
945d7c6afe fix(Script/Misc): Replace hardcoded gossip and texts with DB ones. (#17502)
* fix(CORE/Creature): replace shadowmoon valley hardcoded gossips

* fix(CORE/GameObject): replace terokkar forrest hardcoded gossips

* fix(Core/Creature): replace shattrath city hardcoded gossips

* style(Core): code style edit

* style(CORE) codestyle edit

* style(CORE) codestyle edit

* style(CORE): codestyle edit

* ready for merge

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-10-22 03:16:51 +02:00
Andrew
c5ac4789d8 fix(Scripts/Karazhan): Opera left door should stay open in case of wipe (#17553) 2023-10-21 21:59:18 -03:00
Andrew
a3d728f791 fix(Scripts/Karazhan): Script Aran's Flame Wreath ability (#17551) 2023-10-21 21:08:12 -03:00
daobashun
d9d500923a fix(DB/SAI): Move the Ashbringer event AI of the Bloody Monastery mob to Smartai (#17078)
* Move scarlet_guard's Ashbringer event to smartAI

* Remove the code from the script

* Delete the commented out code

* Modify the distance of the "Scarlet Wizard" Cast Arcane Explosion

* Fix errors

* Update rev_1692891765582381000.sql

* Update rev_1692891765582381000.sql

* Remove duplicate statements

* Remove duplicate statements
2023-10-22 02:03:50 +02:00
Andrew
25328b54f9 fix(Scripts/Mechanar): Remove polarity shift stacks on polarity change (#17548) 2023-10-21 15:48:39 -03:00
avarishd
228f6635c0 fix(Core/Scripts): ScriptEffect Frog Kiss (#17482) 2023-10-21 09:15:20 -03:00
IntelligentQuantum
a0985f59b6 refactor(Scripts/Commands): convert cs_ticket to new system (#17547)
Update cs_ticket.cpp
2023-10-21 08:22:53 -03:00
avarishd
39bad395c2 fix(Core/Spells): Script Yeh'kinya's Bramble (#17516)
* fix(Core/Spells): Script Yeh'kinya's Bramble

* rogue screechers
2023-10-21 08:10:00 -03:00
avarishd
2c28cc0eb7 fix(DB/Items): Unhatched Jubling Egg obtaining + RP (#17478) 2023-10-20 20:39:04 -03:00
IntelligentQuantum
332ff49c13 refactor(Scripts/Commands): convert cs_reset to new system (#17546)
Update cs_reset.cpp
2023-10-20 19:41:02 -03:00
Grimgravy
e3592f7de7 fix(Scripts/Quest): improve Path of Conquest (#16353)
* fix(DB/Quest): improve Path of Conquest

* update

* Update rev_1684800494817311100.sql

* .

* .
2023-10-19 21:46:00 -03:00
Dan
c7324f3066 fix(Scripts/Paladin): ensure Judgements of the Just procs Seal of Vengeance/Corruption (#17470)
* initial

* no spaces

* add enum
2023-10-19 12:19:59 -03:00
avarishd
a39175bc3b fix(Core/Spells): Demonic Knowledge missing 1% per rank (#17495) 2023-10-18 19:21:46 -03:00