* fix(Core/Spell): Flame Breath (Catapult)
- Will fix issue with Wintergrasp Catapult Siege spell (Flame Breath).
- The SQL is added just in case, if someone already tried temp fix applying another spell.
https://github.com/azerothcore/azerothcore-wotlk/issues/1978#issuecomment-507880360
- Done, updated. Wintergrasp Demolisher - Spell Ram is fixed also
* Fix treating numeric values as string
* fix(DB/CreatureScript): Deathblow to the Legion
* Implement the event which takes place during the "Deathblow to the Legion" quest. This is based on PR #1834 but had to be heavily modified as the original scripts contained many bugs and inconsistencies.
- The fix should cause the event to start after the quest The Emitter ID 9312 has ended.
The old smart_script is deleted because it does not belong to the NPC.
It belongs to the NPC with the ID 16514 which also has the script.
- Culling of Stratholme: Apply random movement instead of waypoint movement in order to prevent log errors for these creatures: Bile Golem, Crypt Fiend, Devouring Ghoul, Patchwork Construct
- Utgarde Keep: Apply correct waypoint path for Prince Keleseth
- Fix Rocknar SAI link error
- Fix Impaled Valgarde Scout SAI link error (quest "Rescuing the Rescuers")
- Utgarde Pinnacle: Fix Ymirjar Flesh Hunter SAI link error in Normal difficulty; fix using "Aimed Shot" in Heroic difficulty
* fix(DB/Creature): Razorscale Harpoon Fire State
- Adding flags_extra 128 CREATURE_FLAG_EXTRA_TRIGGER creature is trigger-NPC (invisible to players only).
* fix(DB/Creature): High Overlord Saurfang
- Adding UNIT_FLAG_IMMUNE_TO_NPC (disables combat/assistance with NonPlayerCharacters (NPC)) to creature High Overlord Saurfang in icc.
- Will fix issue with attacking creatures inside, and issue with DB errors about missing text.
* fix(DB/Creature): High Overlord Saurfang
Improvement. Fix issue with DB text. Thanks to @Stoabrogga
Use "std::unordered_map" instead of "std::vector" in order to reduce memory usage (not much, perhaps 5-10%)
identify missing pool entries in pool_template via error messages in the server log
Concerning the pool entries I applied the following fixes as they would now cause errors:
Remove pool entry 5217 from pool_gameobject (only 1 game object "Saronite", not needed here)
Remove pool entry 1047 from pool_creature (only 1 creature "Hematos", not needed here)
Add a few missing Saronite nodes to pool_template
As it is now you can complete the quest "When All Else Fails" (Horde: 13060, Alliance: 12862) but there are just 2 gossip options "I am ready to head further into Storm Peaks." which don't do anything. This is fixed through this PR which is based on the TC commit TrinityCore/TrinityCore@7c7029c (I just omitted the delete/insert statements for table "gossip_menu_option", because the AC database already contains the data).
