chore(core): cleanup code p3 (#16073)

* Update MMapMgr.cpp

* Update UpdateFetcher.cpp

* Update AuctionHouseMgr.cpp

* Update AuctionHouseMgr.h

* Update BattlegroundAV.cpp

* Update ChannelMgr.cpp

* Update ThreatMgr.h

* Update Player.h

* Update PlayerSettings.cpp

* Update ObjectMgr.cpp

* Update Guild.cpp

* Update Guild.h

* Update Map.cpp

* Update World.cpp

* Update boss_nefarian.cpp

* Update boss_prince_malchezaar.cpp

* Update boss_venoxis.cpp

* Update zone_elwynn_forest.cpp

* Update zulfarrak.cpp

* Update boss_novos.cpp

src/server/game/AuctionHouse/AuctionHouseMgr.cpp

@@ -37,7 +37,7 @@ constexpr auto AH_MINIMUM_DEPOSIT = 100;
 // Proof of concept, we should shift the info we're obtaining in here into AuctionEntry probably
 static bool SortAuction(AuctionEntry* left, AuctionEntry* right, AuctionSortOrderVector& sortOrder, Player* player, bool checkMinBidBuyout)
 {
-    for (auto thisOrder : sortOrder)
+    for (auto& thisOrder : sortOrder)
     {
         switch (thisOrder.sortOrder)
         {
@@ -908,7 +908,7 @@ bool AuctionHouseObject::BuildListAuctionItems(WorldPacket& data, Player* player
         }
     }
 
-    for (auto auction : auctionShortlist)
+    for (auto& auction : auctionShortlist)
     {
         // Add the item if no search term or if entered search term was found
         if (count < 50 && totalcount >= listfrom)

src/server/game/AuctionHouse/AuctionHouseMgr.h

@@ -133,7 +133,7 @@ public:
     AuctionHouseObject() { _next = _auctionsMap.begin(); }
     ~AuctionHouseObject()
     {
-        for (auto & itr : _auctionsMap)
+        for (auto& itr : _auctionsMap)
             delete itr.second;
     }