fix(Core/Social): cleanup + fix crash in friend system (#3832)

fix crash when a friend or ignore get GUID 0 and also double friend list
2026-01-18 11:25:42 +00:00 · 2020-12-04 00:20:35 +00:00
parent 9befc2c904
commit 755e30f916
5 changed files with 283 additions and 310 deletions
--- a/src/server/game/Handlers/Socialhandler.cpp
+++ b/src/server/game/Handlers/Socialhandler.cpp
@@ -0,0 +1,151 @@
+/*
+ * Copyright (C) 2016+     AzerothCore <www.azerothcore.org>, released under GNU GPL v2 license: https://github.com/azerothcore/azerothcore-wotlk/blob/master/LICENSE-GPL2
+ * Copyright (C) 2008-2016 TrinityCore <http://www.trinitycore.org/>
+ * Copyright (C) 2005-2009 MaNGOS <http://getmangos.com/>
+ */
+
+
+#include "WorldSession.h"
+#include "AccountMgr.h"
+#include "Log.h"
+#include "Language.h"
+#include "ObjectAccessor.h"
+#include "ObjectMgr.h"
+#include "Player.h"
+#include "SocialMgr.h"
+#include "World.h"
+
+void WorldSession::HandleContactListOpcode(WorldPacket& recv_data)
+{
+    uint32 flags;
+    recv_data >> flags;
+
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: Received CMSG_CONTACT_LIST - Unk: %d", flags);
+
+    _player->GetSocial()->SendSocialList(_player, flags);
+}
+
+void WorldSession::HandleAddFriendOpcode(WorldPacket& recv_data)
+{
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: Received CMSG_ADD_FRIEND");
+
+    std::string friendName = GetAcoreString(LANG_FRIEND_IGNORE_UNKNOWN);
+    std::string friendNote;
+
+    recv_data >> friendName;
+    recv_data >> friendNote;
+
+    if (!normalizePlayerName(friendName))
+        return;
+
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: %s asked to add friend : '%s'", GetPlayer()->GetName().c_str(), friendName.c_str());
+
+    // xinef: Get Data From global storage
+    uint32 guidLow = sWorld->GetGlobalPlayerGUID(friendName);
+    if (!guidLow)
+        return;
+
+    GlobalPlayerData const* playerData = sWorld->GetGlobalPlayerData(guidLow);
+    if (!playerData)
+        return;
+
+    uint64 friendGuid = MAKE_NEW_GUID(guidLow, 0, HIGHGUID_PLAYER);
+    uint32 friendAccountId = playerData->accountId;
+    TeamId teamId = Player::TeamIdForRace(playerData->race);
+    FriendsResult friendResult = FRIEND_NOT_FOUND;
+
+    if (!AccountMgr::IsPlayerAccount(GetSecurity()) || sWorld->getBoolConfig(CONFIG_ALLOW_GM_FRIEND)|| AccountMgr::IsPlayerAccount(AccountMgr::GetSecurity(friendAccountId, realmID)))
+    {
+        if (friendGuid)
+        {
+            if (friendGuid == GetPlayer()->GetGUID())
+                friendResult = FRIEND_SELF;
+            else if (GetPlayer()->GetTeamId() != teamId && !sWorld->getBoolConfig(CONFIG_ALLOW_TWO_SIDE_ADD_FRIEND)  && AccountMgr::IsPlayerAccount(GetSecurity()))
+                friendResult = FRIEND_ENEMY;
+            else if (GetPlayer()->GetSocial()->HasFriend(guidLow))
+                friendResult = FRIEND_ALREADY;
+            else
+            {
+                Player* pFriend = ObjectAccessor::FindPlayerInOrOutOfWorld(friendGuid);
+                if (pFriend && pFriend->IsVisibleGloballyFor(GetPlayer()) && !AccountMgr::IsGMAccount(pFriend->GetSession()->GetSecurity()))
+                    friendResult = FRIEND_ADDED_ONLINE;
+                else
+                    friendResult = FRIEND_ADDED_OFFLINE;
+                if (GetPlayer()->GetSocial()->AddToSocialList(friendGuid, SOCIAL_FLAG_FRIEND))
+                    GetPlayer()->GetSocial()->SetFriendNote(friendGuid, friendNote);
+                else
+                friendResult = FRIEND_LIST_FULL;
+            }
+            GetPlayer()->GetSocial()->SetFriendNote(guidLow, friendNote);
+        }
+    }
+
+    sSocialMgr->SendFriendStatus(GetPlayer(), friendResult, guidLow, false);
+
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: Sent (SMSG_FRIEND_STATUS)");
+}
+
+void WorldSession::HandleDelFriendOpcode(WorldPacket& recv_data)
+{
+    uint64 FriendGUID;
+    recv_data >> FriendGUID;
+
+    _player->GetSocial()->RemoveFromSocialList(GUID_LOPART(FriendGUID), SOCIAL_FLAG_FRIEND);
+
+    sSocialMgr->SendFriendStatus(GetPlayer(), FRIEND_REMOVED, GUID_LOPART(FriendGUID), false);
+
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: Sent motd (SMSG_FRIEND_STATUS)");
+}
+
+void WorldSession::HandleAddIgnoreOpcode(WorldPacket& recv_data)
+{
+    std::string ignoreName = GetAcoreString(LANG_FRIEND_IGNORE_UNKNOWN);
+
+    recv_data >> ignoreName;
+
+    if (!normalizePlayerName(ignoreName))
+        return;
+
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: %s asked to Ignore: '%s'", GetPlayer()->GetName().c_str(), ignoreName.c_str());
+
+    uint32 lowGuid = sWorld->GetGlobalPlayerGUID(ignoreName);
+    if (!lowGuid)
+        return;
+
+    uint64 IgnoreGuid = MAKE_NEW_GUID(lowGuid, 0, HIGHGUID_PLAYER);
+    FriendsResult ignoreResult = FRIEND_IGNORE_NOT_FOUND;
+
+    if (IgnoreGuid == GetPlayer()->GetGUID())              //not add yourself
+        ignoreResult = FRIEND_IGNORE_SELF;
+    else if (GetPlayer()->GetSocial()->HasIgnore(lowGuid))
+        ignoreResult = FRIEND_IGNORE_ALREADY;
+    else
+    {
+        ignoreResult = FRIEND_IGNORE_ADDED;
+
+        // ignore list full
+        if (!GetPlayer()->GetSocial()->AddToSocialList(lowGuid, SOCIAL_FLAG_IGNORED))
+            ignoreResult = FRIEND_IGNORE_FULL;
+    }
+
+    sSocialMgr->SendFriendStatus(GetPlayer(), ignoreResult, lowGuid, false);
+
+    sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: Sent (SMSG_FRIEND_STATUS)");
+}
+
+void WorldSession::HandleDelIgnoreOpcode(WorldPacket& recv_data)
+{
+    uint64 IgnoreGUID;
+    recv_data >> IgnoreGUID;
+
+    _player->GetSocial()->RemoveFromSocialList(GUID_LOPART(IgnoreGUID), SOCIAL_FLAG_IGNORED);
+    sSocialMgr->SendFriendStatus(GetPlayer(), FRIEND_IGNORE_REMOVED, GUID_LOPART(IgnoreGUID), false);
+}
+
+void WorldSession::HandleSetContactNotesOpcode(WorldPacket& recv_data)
+{
+    uint64 guid;
+    std::string note;
+    recv_data >> guid >> note;
+    _player->GetSocial()->SetFriendNote(GUID_LOPART(guid), note);
+}