nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-14 09:39:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core): Fix guild bank update broadcasts (#13520)

Browse Source 
Fix guild bank update broadcasts
This commit is contained in:
Mickaël Mauger
2022-11-11 20:25:24 +01:00
committed by GitHub
parent f32b34ef44
commit 2c4df1054e
3 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/server/game/Guilds/Guild.cpp
View File

@@ -1798,8 +1798,14 @@ void Guild::SendBankTabData(WorldSession* session, uint8 tabId, bool sendAllSlot
_SendBankContent(session, tabId, sendAllSlots);
}
void Guild::SendBankTabsInfo(WorldSession* session, bool sendAllSlots /*= false*/) const
void Guild::SendBankTabsInfo(WorldSession* session, bool sendAllSlots /*= false*/)
{
Member* member = GetMember(session->GetPlayer()->GetGUID());
if (!member)
return;
member->SubscribeToGuildBankUpdatePackets();
_SendBankList(session, 0, sendAllSlots);
}
@@ -1809,12 +1815,17 @@ void Guild::SendBankTabText(WorldSession* session, uint8 tabId) const
tab->SendText(this, session);
}
void Guild::SendPermissions(WorldSession* session) const
void Guild::SendPermissions(WorldSession* session)
{
Member const* member = GetMember(session->GetPlayer()->GetGUID());
Member* member = GetMember(session->GetPlayer()->GetGUID());
if (!member)
return;
// We are unsubscribing here since it is the only reliable way to handle /reload from player as
// GuildPermissionsQuery is sent on each reload, and we don't want to send partial changes while client
// doesn't know the full state
member->UnsubscribeFromGuildBankUpdatePackets();
uint8 rankId = member->GetRankId();
WorldPackets::Guild::GuildPermissionsQueryResults queryResult;
@@ -1857,8 +1868,6 @@ void Guild::SendLoginInfo(WorldSession* session)
LOG_DEBUG("guild", "SMSG_GUILD_EVENT [{}] MOTD", session->GetPlayerInfo());
SendBankTabsInfo(session);
Player* player = session->GetPlayer();
HandleRoster(session);
@@ -2878,13 +2887,17 @@ void Guild::_SendBankList(WorldSession* session /* = nullptr*/, uint8 tabId /*=
LOG_DEBUG("guild", "SMSG_GUILD_BANK_LIST [{}]: TabId: {}, FullSlots: {}, slots: {}",
session->GetPlayerInfo(), tabId, sendAllSlots, packet.WithdrawalsRemaining);
}
else /// @todo - Probably this is just sent to session + those that have sent CMSG_GUILD_BANKER_ACTIVATE
else
{
packet.Write();
for (auto const& [guid, member] : m_members)
{
if (!member.ShouldReceiveBankPartialUpdatePackets())
continue;
if (!_MemberHasTabRights(member.GetGUID(), tabId, GUILD_BANK_RIGHT_VIEW_TAB))
continue;
Player* player = member.FindPlayer();
if (!player)
continue;