nchebrov/AzerothCore-RealmMaster
1
0
Fork 0
mirror of https://github.com/uprightbass360/AzerothCore-RealmMaster.git synced 2026-01-13 09:07:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Compare commits

base: nchebrov:0.0.1
Branches Tags
nchebrov:main nchebrov:chore/update-module-manifest nchebrov:feat/variable-enhancement nchebrov:feat/refactor nchebrov:feat/module-install-refactor
nchebrov:0.0.1
..
compare: nchebrov:305da352c005ceda5366aaa61c73c0eed8d8753f
Branches Tags
nchebrov:main nchebrov:chore/update-module-manifest nchebrov:feat/variable-enhancement nchebrov:feat/refactor nchebrov:feat/module-install-refactor
nchebrov:0.0.1

2 Commits
0.0.1 ... 305da352c0

Author SHA1 Message Date
uprightbass360
305da352c0 fix: correct module list output in build summary 
The redirect operator was placed after '|| true', causing the module
list to not be appended to GITHUB_STEP_SUMMARY. Moved the redirect
before the fallback operator to ensure output is captured.
 2026-01-10 18:22:46 -05:00
uprightbass360
61436263ad fix: resolve YAML syntax errors in create-release workflow 
Replaced heredocs with echo statements to avoid YAML parsing issues.
The YAML parser was interpreting markdown headings and other content
within heredocs as YAML syntax, causing validation errors.

Using grouped echo statements ({ echo ...; } > file) works correctly
with GitHub Actions YAML parser while maintaining variable expansion.

Also updated documentation to use generic placeholder (your-dockerhub-username)
in examples instead of hardcoded username.
 2026-01-10 18:16:29 -05:00
4 changed files with 5 additions and 8 deletions
Expand all files Collapse all files

2
.github/workflows/build-and-publish.yml vendored
View File

@@ -230,7 +230,7 @@ jobs:
echo "<summary>View enabled modules</summary>" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
grep '^MODULE_.*=1' .env | sed 's/=1//' || true >> $GITHUB_STEP_SUMMARY
grep '^MODULE_.*=1' .env | sed 's/=1//' >> $GITHUB_STEP_SUMMARY || true
echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
echo "</details>" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY

4
.github/workflows/create-release.yml vendored
View File

@@ -107,7 +107,7 @@ jobs:
echo "1. **Edit .env.prebuilt**:"
echo " \`\`\`bash"
echo " nano .env.prebuilt"
echo " # Set: DOCKERHUB_USERNAME=uprightbass360"
echo " # Set: DOCKERHUB_USERNAME=your-dockerhub-username"
echo " \`\`\`"
echo ""
echo "2. **Rename to .env**:"
@@ -180,7 +180,7 @@ jobs:
echo ""
echo "# Configure Docker Hub username"
echo "nano .env.prebuilt"
echo "# Set: DOCKERHUB_USERNAME=uprightbass360"
echo "# Set: DOCKERHUB_USERNAME=your-dockerhub-username"
echo ""
echo "# Deploy"
echo "mv .env.prebuilt .env"

5
docs/PREBUILT_IMAGES.md
View File

@@ -48,11 +48,8 @@ cp .env.prebuilt .env
Edit `.env` and set your Docker Hub username:
```bash
# Change this line:
# Change this line to your Docker Hub username:
DOCKERHUB_USERNAME=your-dockerhub-username
# To (example):
DOCKERHUB_USERNAME=uprightbass360
```
### 4. Optional: Customize Settings

2
docs/RELEASES.md
View File

@@ -145,7 +145,7 @@ cd azerothcore-realmmaster-v1.0.0-realmmaster
# 3. Configure
nano .env.prebuilt
# Set: DOCKERHUB_USERNAME=uprightbass360
# Set: DOCKERHUB_USERNAME=your-dockerhub-username
# 4. Deploy
mv .env.prebuilt .env