From 9e3ce874547b33ba5ca8a57a5d0e107cdf78197f Mon Sep 17 00:00:00 2001 From: Pagani Walter Date: Mon, 12 Jun 2023 09:04:35 -0300 Subject: [PATCH] Update repository --- .github/ISSUE_TEMPLATE/bug_report.yml | 72 ++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.yml | 33 ++++++++++ .github/README.md | 8 ++- .github/README_ES.md | 8 ++- pull_request_template.md | 32 ++++++++++ src/quest_loot_party.cpp | 2 +- 6 files changed, 152 insertions(+), 3 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml create mode 100644 pull_request_template.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml new file mode 100644 index 0000000..5610d2b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -0,0 +1,72 @@ +name: Bug report +description: Create a bug report to help us improve. +title: "Bug: " +body: + - type: textarea + id: current + attributes: + label: Current Behaviour + description: | + Description of the problem or issue here. + Include entries of affected creatures / items / quests / spells etc. + If this is a crash, post the crashlog (upload to https://gist.github.com/) and include the link here. + Never upload files! Use GIST for text and YouTube for videos! + validations: + required: true + - type: textarea + id: expected + attributes: + label: Expected Behaviour + description: | + Tell us what should happen instead. + validations: + required: true + - type: textarea + id: reproduce + attributes: + label: Steps to reproduce the problem + description: | + What does someone else need to do to encounter the same bug? + placeholder: | + 1. Step 1 + 2. Step 2 + 3. Step 3 + validations: + required: true + - type: textarea + id: extra + attributes: + label: Extra Notes + description: | + Do you have any extra notes that can help solve the issue that does not fit any other field? + placeholder: | + None + validations: + required: false + - type: textarea + id: commit + attributes: + label: AC rev. hash/commit + description: | + Copy the result of the `.server debug` command (if you need to run it from the client get a prat addon) + validations: + required: true + - type: input + id: os + attributes: + label: Operating system + description: | + The Operating System the Server is running on. + i.e. Windows 11 x64, Debian 10 x64, macOS 12, Ubuntu 20.04 + validations: + required: true + - type: textarea + id: custom + attributes: + label: Custom changes or Modules + description: | + List which custom changes or modules you have applied, i.e. Eluna module, etc. + placeholder: | + None + validations: + required: false diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml new file mode 100644 index 0000000..58f79dd --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -0,0 +1,33 @@ +name: Feature request +description: Suggest an idea for this project +title: "Feature: " +body: + - type: markdown + attributes: + value: | + Thank you for taking your time to fill out a feature request. Remember to fill out all fields including the title above. + An issue that is not properly filled out will be closed. + - type: textarea + id: description + attributes: + label: Describe your feature request or suggestion in detail + description: | + A clear and concise description of what you want to happen. + validations: + required: true + - type: textarea + id: solution + attributes: + label: Describe a possible solution to your feature or suggestion in detail + description: | + A clear and concise description of any alternative solutions or features you've considered. + validations: + required: false + - type: textarea + id: additional + attributes: + label: Additional context + description: | + Add any other context or screenshots about the feature request here. + validations: + required: false diff --git a/.github/README.md b/.github/README.md index a477fbf..f9691f2 100644 --- a/.github/README.md +++ b/.github/README.md @@ -4,8 +4,14 @@ [English](README.md) | [Español](README_ES.md) -- Latest build status with azerothcore: [![Build Status](https://github.com/pangolp/mod-quest-loot-party/workflows/core-build/badge.svg?branch=master&event=push)](https://github.com/pangolp/mod-quest-loot-party) +- Latest build status with azerothcore: + +[![Build Status](https://github.com/pangolp/mod-quest-loot-party/workflows/core-build/badge.svg?branch=master&event=push)](https://github.com/pangolp/mod-quest-loot-party) The idea of this simple mod is that by implementing a hook in the emulator, it is possible to modify the drop condition of the quest items. In this way, it is possible that within a group, everyone is able to get the quest item, as long as the npc has a chance to drop it. I think this way, we encourage more people to play in groups, because before, if we were a group of 5 people doing quests, and we had to get all the necessary items, we had to kill a lot of npc, or directly avoid that kind of quests. + +- For this module to work, the following pull request must be approved. +- Until it is in the emulator, it cannot work. +- https://github.com/azerothcore/azerothcore-wotlk/pull/16509 diff --git a/.github/README_ES.md b/.github/README_ES.md index 6490e2e..375dd54 100644 --- a/.github/README_ES.md +++ b/.github/README_ES.md @@ -4,8 +4,14 @@ [English](README.md) | [Español](README_ES.md) -- Último estado de compilación con azerothcore: [![Build Status](https://github.com/pangolp/mod-quest-loot-party/workflows/core-build/badge.svg?branch=master&event=push)](https://github.com/pangolp/mod-quest-loot-party) +- Último estado de compilación con azerothcore: + +[![Build Status](https://github.com/pangolp/mod-quest-loot-party/workflows/core-build/badge.svg?branch=master&event=push)](https://github.com/pangolp/mod-quest-loot-party) La idea de este sencillo mod, es que mediante la implementación de un hook en el emulador, sea posible modificar la condición del drop de los ítems de quest. De esa forma, es posible, que dentro de un grupo, todos sean capaces de obtener el ítem de quest, siempre y cuando, el npc tenga una probabilidad de tirarlo. Creo que de esa forma, fomentamos mas el hecho de que la gente jugué en grupo, porque anteriormente, si eramos un grupo de 5 personas haciendo misiones, y teníamos que obtener todos los ítems necesarios, debíamos matar mucha cantidad de npc, o bien, directamente evitar ese tipo de misiones. + +- Para que este modulo funcione, se requiere de la aprobación del siguiente pull request. +- Hasta que el mismo no se encuentre en el emulador, no puede funcionar. +- https://github.com/azerothcore/azerothcore-wotlk/pull/16509 diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..b48f258 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,32 @@ + + +## Changes Proposed: +- +- + +## Issues Addressed: + +- Closes + +## SOURCE: + + +## Tests Performed: + + +- +- + + +## How to Test the Changes: + + +1. +2. +3. + +## Known Issues and TODO List: + + +- [ ] +- [ ] diff --git a/src/quest_loot_party.cpp b/src/quest_loot_party.cpp index 1d17e60..fab682b 100644 --- a/src/quest_loot_party.cpp +++ b/src/quest_loot_party.cpp @@ -25,7 +25,7 @@ public: } } - void OnBeforeLootItem(Player* player, LootItem& item) + void OnBeforeFillQuestLootItem(Player* player, LootItem& item) { if (sConfigMgr->GetOption("QuestParty.Enable", false)) {