mirror of
https://github.com/mod-playerbots/mod-playerbots.git
synced 2026-01-31 01:13:48 +00:00
13fff46fa0
# Pull Request
- Applies the clean and corrected singletons, Meyer pattern. (cherry
picked from @SmashingQuasar )
Testing by just playing the game in various ways. Been tested by myself
@Celandriel and @SmashingQuasar
---
## Complexity & Impact
- Does this change add new decision branches?
- [x] No
- [ ] Yes (**explain below**)
- Does this change increase per-bot or per-tick processing?
- [x] No
- [ ] Yes (**describe and justify impact**)
- Could this logic scale poorly under load?
- [x] No
- [ ] Yes (**explain why**)
---
## Defaults & Configuration
- Does this change modify default bot behavior?
- [x] No
- [ ] Yes (**explain why**)
---
## AI Assistance
- Was AI assistance (e.g. ChatGPT or similar tools) used while working
on this change?
- [x] No
- [ ] Yes (**explain below**)
---
## Final Checklist
- [x] Stability is not compromised
- [x] Performance impact is understood, tested, and acceptable
- [x] Added logic complexity is justified and explained
- [x] Documentation updated if needed
---
## Notes for Reviewers
Anything that significantly improves realism at the cost of stability or
performance should be carefully discussed
before merging.
---------
Co-authored-by: Nicolas Lebacq <nicolas.cordier@outlook.com>
Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com>
113 lines
3.0 KiB
C++
113 lines
3.0 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
|
|
* and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#include "ShareQuestAction.h"
|
|
|
|
#include "Event.h"
|
|
#include "Playerbots.h"
|
|
|
|
bool ShareQuestAction::Execute(Event event)
|
|
{
|
|
std::string const link = event.getParam();
|
|
if (!GetMaster())
|
|
return false;
|
|
|
|
PlayerbotChatHandler handler(GetMaster());
|
|
uint32 entry = handler.extractQuestId(link);
|
|
if (!entry)
|
|
return false;
|
|
|
|
Quest const* quest = sObjectMgr->GetQuestTemplate(entry);
|
|
if (!quest)
|
|
return false;
|
|
|
|
// remove all quest entries for 'entry' from quest log
|
|
for (uint8 slot = 0; slot < MAX_QUEST_LOG_SIZE; ++slot)
|
|
{
|
|
uint32 logQuest = bot->GetQuestSlotQuestId(slot);
|
|
if (logQuest == entry)
|
|
{
|
|
WorldPacket p;
|
|
p << entry;
|
|
bot->GetSession()->HandlePushQuestToParty(p);
|
|
botAI->TellMaster("Quest shared");
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool AutoShareQuestAction::Execute(Event event)
|
|
{
|
|
Player* requester = event.getOwner() ? event.getOwner() : GetMaster();
|
|
bool shared = false;
|
|
|
|
for (uint8 slot = 0; slot < MAX_QUEST_LOG_SIZE; ++slot)
|
|
{
|
|
uint32 logQuest = bot->GetQuestSlotQuestId(slot);
|
|
Quest const* quest = sObjectMgr->GetQuestTemplate(logQuest);
|
|
|
|
if (!quest)
|
|
continue;
|
|
|
|
bool partyNeedsQuest = false;
|
|
|
|
for (GroupReference* itr = bot->GetGroup()->GetFirstMember(); itr != nullptr; itr = itr->next())
|
|
{
|
|
Player* player = itr->GetSource();
|
|
|
|
if (!player || player == bot || !player->IsInWorld() || !botAI->IsSafe(player)) // skip self
|
|
continue;
|
|
|
|
if (bot->GetDistance(player) > 10)
|
|
continue;
|
|
|
|
if (!player->SatisfyQuestStatus(quest, false))
|
|
continue;
|
|
|
|
if (player->GetQuestStatus(logQuest) == QUEST_STATUS_COMPLETE)
|
|
continue;
|
|
|
|
if (!player->CanTakeQuest(quest, false))
|
|
continue;
|
|
|
|
if (!player->SatisfyQuestLog(false))
|
|
continue;
|
|
|
|
if (player->GetDivider())
|
|
continue;
|
|
|
|
if (auto ai = GET_PLAYERBOT_AI(player))
|
|
{
|
|
if (PAI_VALUE(uint8, "free quest log slots") < 15 || !urand(0,5))
|
|
{
|
|
WorldPacket packet(CMSG_PUSHQUESTTOPARTY, 20);
|
|
packet << logQuest;
|
|
ai->HandleMasterIncomingPacket(packet);
|
|
}
|
|
}
|
|
else
|
|
partyNeedsQuest = true;
|
|
}
|
|
|
|
if (!partyNeedsQuest)
|
|
continue;
|
|
|
|
WorldPacket p;
|
|
p << logQuest;
|
|
bot->GetSession()->HandlePushQuestToParty(p);
|
|
botAI->TellMaster("Quest shared");
|
|
shared = true;
|
|
}
|
|
|
|
return shared;
|
|
}
|
|
|
|
bool AutoShareQuestAction::isUseful()
|
|
{
|
|
return bot->GetGroup() && !botAI->HasActivePlayerMaster();
|
|
}
|