mirror of
https://github.com/mod-playerbots/mod-playerbots.git
synced 2026-01-15 18:00:27 +00:00
<!-- > [!WARNING] > **This is a DRAFT PR.** > The structure is not definitive. The code might not be optimised yet. It might not even start nor compile yet. > **Don't panic. ✋ It's going to be ok. 👌 We can make modifications, we can fix things.** 😁 --> # Description This PR aims to refactor the NextAction declaration to achieve two goals: ## Eliminate C-style sentinel arrays Currently, a double pointer (`NextAction**`) approach is being used. This an old pre-C++11 (< 2011) trick before `std::vector<>` became a thing. This approach is painful for developers because they constantly need to declare their `NextAction` arrays as: ```cpp NextAction::array(0, new NextAction("foo", 1.0f), nullptr) ``` Instead of: ```cpp { new NextAction("foo", 1.0f) } ``` The first argument of `NextAction::array` is actually a hack. It is used to have a named argument so `va_args` can find the remaining arguments. It is set to 0 everywhere but in fact does nothing. This is very confusing to people unfamiliar with this antiquated syntax. The last argument `nullptr` is what we call a sentinel. It's a `nullptr` because `va_args` is looking for a `nullptr` to stop iterating. It's also a hack and also leads to confusion. ## Eliminate unnecessary pointers for `NextAction` Pointers can be used for several reasons, to cite a few: - Indicate strong, absolute identity. - Provide strong but transferable ownership (unlike references). - When a null value is acceptable (`nullptr`). - When copy is expensive. `NextAction` meets none of these criteria: - It has no identity because it is purely behavioural. - It is never owned by anything as it is passed around and never fetched from a registry. - The only situations where it can be `nullptr` are errors that should in fact throw an `std::invalid_argument` instead. - They are extremely small objects that embark a single `std::string` and a single `float`. Pointers should be avoided when not strictly necessary because they can quickly lead to undefined behaviour due to unhandled `nullptr` situations. They also make the syntax heavier due to the necessity to constantly check for `nullptr`. Finally, they aren't even good for performance in that situation because shifting a pointer so many times is likely more expensive than copying such a trivial object. # End goal The end goal is to declare `NextAction` arrays this way: ```cpp { NextAction("foo", 1.0f) } ``` > [!NOTE] > Additional note: `NextAction` is nothing but a hacky proxy to an `Action` constructor. This should eventually be reworked to use handles instead of strings. This would make copying `NextAction` even cheaper and remove the need for the extremely heavy stringly typed current approach. Stringly typed entities are a known anti-pattern so we need to move on from those.
193 lines
5.1 KiB
C++
193 lines
5.1 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#include "UnholyDKStrategy.h"
|
|
|
|
#include "Playerbots.h"
|
|
|
|
class UnholyDKStrategyActionNodeFactory : public NamedObjectFactory<ActionNode>
|
|
{
|
|
public:
|
|
UnholyDKStrategyActionNodeFactory()
|
|
{
|
|
creators["death strike"] = &death_strike;
|
|
creators["scourge strike"] = &scourge_strike;
|
|
creators["ghoul frenzy"] = &ghoul_frenzy;
|
|
creators["corpse explosion"] = &corpse_explosion;
|
|
creators["icy touch"] = &icy_touch;
|
|
}
|
|
|
|
private:
|
|
static ActionNode* death_strike([[maybe_unused]] PlayerbotAI* botAI)
|
|
{
|
|
return new ActionNode(
|
|
"death strike",
|
|
/*P*/ { NextAction("blood presence") },
|
|
/*A*/ {},
|
|
/*C*/ {}
|
|
);
|
|
}
|
|
static ActionNode* ghoul_frenzy([[maybe_unused]] PlayerbotAI* botAI)
|
|
{
|
|
return new ActionNode(
|
|
"ghoul frenzy",
|
|
/*P*/ { NextAction("blood presence") },
|
|
/*A*/ {},
|
|
/*C*/ {}
|
|
);
|
|
}
|
|
static ActionNode* corpse_explosion([[maybe_unused]] PlayerbotAI* botAI)
|
|
{
|
|
return new ActionNode(
|
|
"corpse explosion",
|
|
/*P*/ { NextAction("blood presence") },
|
|
/*A*/ {},
|
|
/*C*/ {}
|
|
);
|
|
}
|
|
|
|
static ActionNode* scourge_strike([[maybe_unused]] PlayerbotAI* botAI)
|
|
{
|
|
return new ActionNode(
|
|
"scourge strike",
|
|
/*P*/ { NextAction("blood presence") },
|
|
/*A*/ {},
|
|
/*C*/ {}
|
|
);
|
|
}
|
|
static ActionNode* icy_touch([[maybe_unused]] PlayerbotAI* botAI)
|
|
{
|
|
return new ActionNode(
|
|
"icy touch",
|
|
/*P*/ { NextAction("blood presence") },
|
|
/*A*/ {},
|
|
/*C*/ {}
|
|
);
|
|
}
|
|
};
|
|
|
|
UnholyDKStrategy::UnholyDKStrategy(PlayerbotAI* botAI) : GenericDKStrategy(botAI)
|
|
{
|
|
actionNodeFactories.Add(new UnholyDKStrategyActionNodeFactory());
|
|
}
|
|
|
|
std::vector<NextAction> UnholyDKStrategy::getDefaultActions()
|
|
{
|
|
return {
|
|
NextAction("death and decay", ACTION_HIGH + 5),
|
|
NextAction("summon gargoyle", ACTION_DEFAULT + 0.4f),
|
|
NextAction("horn of winter", ACTION_DEFAULT + 0.2f),
|
|
NextAction("death coil", ACTION_DEFAULT + 0.1f),
|
|
NextAction("melee", ACTION_DEFAULT)
|
|
};
|
|
}
|
|
|
|
void UnholyDKStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)
|
|
{
|
|
GenericDKStrategy::InitTriggers(triggers);
|
|
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"death and decay cooldown",
|
|
{
|
|
NextAction("ghoul frenzy", ACTION_DEFAULT + 0.9f),
|
|
NextAction("scourge strike", ACTION_DEFAULT + 0.8f),
|
|
NextAction("icy touch", ACTION_DEFAULT + 0.7f),
|
|
NextAction("blood strike", ACTION_DEFAULT + 0.6f),
|
|
NextAction("plague strike", ACTION_DEFAULT + 0.5f),
|
|
}
|
|
)
|
|
);
|
|
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"dd cd and no desolation",
|
|
{
|
|
NextAction("blood strike", ACTION_DEFAULT + 0.75f)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"high frost rune",
|
|
{
|
|
NextAction("icy touch", ACTION_NORMAL + 3)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"high blood rune",
|
|
{
|
|
NextAction("blood strike", ACTION_NORMAL + 2)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"high unholy rune",
|
|
{
|
|
NextAction("plague strike", ACTION_NORMAL + 1)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode("dd cd and plague strike 3s",
|
|
{
|
|
NextAction("plague strike", ACTION_HIGH + 1)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode("dd cd and icy touch 3s",
|
|
{
|
|
NextAction("icy touch", ACTION_HIGH + 2)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode("no rune",
|
|
{
|
|
NextAction("empower rune weapon", ACTION_HIGH + 1)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"army of the dead",
|
|
{
|
|
NextAction("army of the dead", ACTION_HIGH + 6)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode("bone shield",
|
|
{
|
|
NextAction("bone shield", ACTION_HIGH + 3)
|
|
}
|
|
)
|
|
);
|
|
}
|
|
|
|
void UnholyDKAoeStrategy::InitTriggers(std::vector<TriggerNode*>& triggers)
|
|
{
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"loot available",
|
|
{
|
|
NextAction("corpse explosion", ACTION_NORMAL + 1)
|
|
}
|
|
)
|
|
);
|
|
triggers.push_back(
|
|
new TriggerNode(
|
|
"medium aoe",
|
|
{
|
|
NextAction("death and decay", ACTION_NORMAL + 3),
|
|
NextAction("corpse explosion", ACTION_NORMAL + 3)
|
|
}
|
|
)
|
|
);
|
|
}
|