mirror of
https://github.com/mod-playerbots/mod-playerbots.git
synced 2026-01-31 01:13:48 +00:00
13fff46fa0
# Pull Request
- Applies the clean and corrected singletons, Meyer pattern. (cherry
picked from @SmashingQuasar )
Testing by just playing the game in various ways. Been tested by myself
@Celandriel and @SmashingQuasar
---
## Complexity & Impact
- Does this change add new decision branches?
- [x] No
- [ ] Yes (**explain below**)
- Does this change increase per-bot or per-tick processing?
- [x] No
- [ ] Yes (**describe and justify impact**)
- Could this logic scale poorly under load?
- [x] No
- [ ] Yes (**explain why**)
---
## Defaults & Configuration
- Does this change modify default bot behavior?
- [x] No
- [ ] Yes (**explain why**)
---
## AI Assistance
- Was AI assistance (e.g. ChatGPT or similar tools) used while working
on this change?
- [x] No
- [ ] Yes (**explain below**)
---
## Final Checklist
- [x] Stability is not compromised
- [x] Performance impact is understood, tested, and acceptable
- [x] Added logic complexity is justified and explained
- [x] Documentation updated if needed
---
## Notes for Reviewers
Anything that significantly improves realism at the cost of stability or
performance should be carefully discussed
before merging.
---------
Co-authored-by: Nicolas Lebacq <nicolas.cordier@outlook.com>
Co-authored-by: Keleborn <22352763+Celandriel@users.noreply.github.com>
56 lines
1.9 KiB
C++
56 lines
1.9 KiB
C++
/*
|
|
* Copyright (C) 2016+ AzerothCore <www.azerothcore.org>, released under GNU AGPL v3 license, you may redistribute it
|
|
* and/or modify it under version 3 of the License, or (at your option), any later version.
|
|
*/
|
|
|
|
#include "CombatActions.h"
|
|
|
|
#include "Event.h"
|
|
#include "LastMovementValue.h"
|
|
#include "Playerbots.h"
|
|
#include "ServerFacade.h"
|
|
|
|
bool SwitchToMeleeAction::Execute(Event event)
|
|
{
|
|
// botAI->TellMasterNoFacing("Switching to melee!");
|
|
return ChangeCombatStrategyAction::Execute(event);
|
|
}
|
|
|
|
bool SwitchToMeleeAction::isUseful()
|
|
{
|
|
if (bot->getClass() == CLASS_HUNTER)
|
|
{
|
|
Unit* target = AI_VALUE(Unit*, "current target");
|
|
time_t lastFlee = AI_VALUE(LastMovement&, "last movement").lastFlee;
|
|
return botAI->HasStrategy("ranged", BOT_STATE_COMBAT) &&
|
|
((bot->IsInCombat() && target &&
|
|
(target->GetVictim() == bot && (!bot->GetGroup() || lastFlee) &&
|
|
ServerFacade::instance().IsDistanceLessOrEqualThan(AI_VALUE2(float, "distance", "current target"), 8.0f))) ||
|
|
(!bot->IsInCombat()));
|
|
}
|
|
|
|
return botAI->HasStrategy("ranged", BOT_STATE_COMBAT);
|
|
}
|
|
|
|
bool SwitchToRangedAction::Execute(Event event)
|
|
{
|
|
// botAI->TellMasterNoFacing("Switching to ranged!");
|
|
return ChangeCombatStrategyAction::Execute(event);
|
|
}
|
|
|
|
bool SwitchToRangedAction::isUseful()
|
|
{
|
|
if (bot->getClass() == CLASS_HUNTER)
|
|
{
|
|
Unit* target = AI_VALUE(Unit*, "current target");
|
|
bool hasAmmo = AI_VALUE2(uint32, "item count", "ammo");
|
|
return botAI->HasStrategy("close", BOT_STATE_COMBAT) && hasAmmo &&
|
|
((bot->IsInCombat() && target &&
|
|
((target->GetVictim() != bot || target->GetTarget() != bot->GetGUID()) ||
|
|
ServerFacade::instance().IsDistanceGreaterThan(AI_VALUE2(float, "distance", "current target"), 8.0f))) ||
|
|
(!bot->IsInCombat()));
|
|
}
|
|
|
|
return botAI->HasStrategy("close", BOT_STATE_COMBAT);
|
|
}
|