nchebrov/mod-playerbots
1
0
Fork 0
mirror of https://github.com/mod-playerbots/mod-playerbots.git synced 2026-01-18 19:25:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

NamedObjectContext improvement, remove unneccessary pass by copy, allow lambda ObjectCreators (#1561)

Browse Source 
Co-authored-by: Viger <viger28@gmail.com>
This commit is contained in:
Vigerus
2025-08-17 15:42:26 +02:00
committed by GitHub
parent 4f5f7d286e
commit fa7b863035
2 changed files with 30 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/strategy/NamedObjectContext.cpp
View File

@@ -14,10 +14,10 @@ void Qualified::Qualify(int qual)
qualifier = out.str();
}
std::string const Qualified::MultiQualify(std::vector<std::string> qualifiers, const std::string& separator, const std::string_view brackets)
std::string const Qualified::MultiQualify(const std::vector<std::string>& qualifiers, const std::string& separator, const std::string_view brackets)
{
std::stringstream out;
for (uint8 i = 0; i < qualifiers.size(); i++)
for (uint8 i = 0; i < qualifiers.size(); ++i)
{
const std::string& qualifier = qualifiers[i];
if (i == qualifiers.size() - 1)
@@ -40,13 +40,13 @@ std::string const Qualified::MultiQualify(std::vector<std::string> qualifiers, c
}
}
std::vector<std::string> Qualified::getMultiQualifiers(std::string const qualifier1)
std::vector<std::string> Qualified::getMultiQualifiers(const std::string& qualifier1)
{
std::istringstream iss(qualifier1);
return {std::istream_iterator<std::string>{iss}, std::istream_iterator<std::string>{}};
}
int32 Qualified::getMultiQualifier(std::string const qualifier1, uint32 pos)
int32 Qualified::getMultiQualifier(const std::string& qualifier1, uint32 pos)
{
return std::stoi(getMultiQualifiers(qualifier1)[pos]);
}