From ede7697784ec7da6bf44195ba4e1f28a7d6f6b6b Mon Sep 17 00:00:00 2001 From: Revision Date: Fri, 1 Aug 2025 21:48:01 +0200 Subject: [PATCH] Changed OnPlayerBeforeAchievementComplete to allow random bots to unlock achievements (#1487) --- src/Playerbots.cpp | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/Playerbots.cpp b/src/Playerbots.cpp index b2fc0cd2..07b2bf94 100644 --- a/src/Playerbots.cpp +++ b/src/Playerbots.cpp @@ -197,21 +197,13 @@ public: sRandomPlayerbotMgr->HandleCommand(type, msg, player); } - bool OnPlayerBeforeCriteriaProgress(Player* player, AchievementCriteriaEntry const* /*criteria*/) override + bool OnPlayerBeforeAchievementComplete(Player* player, AchievementEntry const* achievement) override { - if (sRandomPlayerbotMgr->IsRandomBot(player)) + if (sRandomPlayerbotMgr->IsRandomBot(player) && (achievement->flags == 256 || achievement->flags == 768)) { return false; } - return true; - } - bool OnPlayerBeforeAchievementComplete(Player* player, AchievementEntry const* /*achievement*/) override - { - if (sRandomPlayerbotMgr->IsRandomBot(player)) - { - return false; - } return true; }