[BUG FIX] Movement flag update called for bots while rooted (#1991)

Fix for the error "Attempted sending heartbeat with root flag for guid"

The core does not allow movement flag updates when unit/player has the
MOVEMENTFLAG_ROOT flag. Change scope bots alone.

src/PlayerbotAI.cpp

@@ -1426,8 +1426,8 @@ void PlayerbotAI::DoNextAction(bool min)
         return;
     }
 
-    // Change engine if just ressed
-    if (currentEngine == engines[BOT_STATE_DEAD] && isBotAlive)
+    // Change engine if just ressed (no movement update when rooted)
+    if (currentEngine == engines[BOT_STATE_DEAD] && isBotAlive && !bot->IsRooted())
     {
         bot->SendMovementFlagUpdate();
 

src/RandomPlayerbotMgr.cpp

@@ -1654,6 +1654,10 @@ void RandomPlayerbotMgr::RandomTeleport(Player* bot, std::vector<WorldLocation>&
     if (bot->IsBeingTeleported() || !bot->IsInWorld())
         return;
 
+    // no teleport / movement update when rooted.
+    if (bot->IsRooted())
+        return;
+
     // ignore when in queue for battle grounds.
     if (bot->InBattlegroundQueue())
         return;

src/ServerFacade.cpp

@@ -41,13 +41,17 @@ bool ServerFacade::IsDistanceLessOrEqualThan(float dist1, float dist2) { return
 
 void ServerFacade::SetFacingTo(Player* bot, WorldObject* wo, bool force)
 {
+    if (!bot)
+        return;
+
     float angle = bot->GetAngle(wo);
     // if (!force && bot->isMoving())
     //     bot->SetFacingTo(bot->GetAngle(wo));
     // else
     // {
     bot->SetOrientation(angle);
-    bot->SendMovementFlagUpdate();
+    if (!bot->IsRooted())
+        bot->SendMovementFlagUpdate();
     // }
 }
 

src/strategy/actions/FishingAction.cpp

@@ -417,7 +417,8 @@ bool FishingAction::Execute(Event event)
     {
         float angle = bot->GetAngle(pos.GetPositionX(), pos.GetPositionY());
         bot->SetOrientation(angle);
-        bot->SendMovementFlagUpdate();
+        if (!bot->IsRooted())
+            bot->SendMovementFlagUpdate();
     }
 
     EquipFishingPoleAction equipAction(botAI);