LK HC update (#876)

* ICC PP WIP

WIP

* added mutated plague for PP

* BPC added (kinetic and boss targeting need to be done by player)

OT collects dark nucles, bots spread on vortex and other stuff they do ok on their own.
Tested only on 10NM, should work on 25NM

* Tank pos. correction

* BQL, ranged spread, link, flame, bite, tanking tested 10NM

to do (better fire spread, hc tacti, melee spread when in air)

* LDW improved

improved shadow logic, ranged spread for easier shadow handling

* dbs update, fixed teleporting

Bots should only go and teleport to the mage that is actually below zero now

* DBS ranged fix

Ranged should spread more quickly and freak out less

* Festergut && DBS

fixed ranged spread (both)
fixed spore logic (fester)

* Rotface fix

Improved big ooze tanking (static pos, todo kiting)
ooze explosion spread mechanic fix
ooze pool fix
Player needs to mark rotface with skull icon, oterwise bots try to attack oozes

* BQL fixed for 25nm

todo: better melee logic in air phase, better melee flame spread

* VDW, Sister Svalna, Sindy update

Sister Svalna, bots can pickup spears and throw at svalna when she has shield up

VDW added healer strats to use portal and heal boss (atm druids are for raid healing only, so use druide + any other healer, ideally player should be healer)
todo (focus on supressers, add healer rotations, atm they use quickest spell they can)

Sindragosa
Added tank boss manipulation (boss orientation and position)
bots detect (buffet, unchained magic and chilled to the bone and act accordingly)
bots detect frost beacon move to safe spot and los frost bombs around them, while dpsing tombs (todo stop dps if only one tomb is left, if we have frost bombs around, not a big deal atm since in nm they dont one shot)
Last phase bots los behind tomb to loose buffet, tanks swap when they have hi buffet count.
Player should tell bots with skull rti if they should kill tomb or focus boss.
todo (dynamic tomb los in last phase so that healers can see tank but also hide behind tomb to break los from boss)

Removed some debug messages, improved LM spike action (nearest bots also try to help kill it)

Improved Lady Deathwshiper shade action (only targeted bots will run away instead of every bot that is near it)

dbs improved tank switch

I recommend to use 3 healers (just to be safe) and 2 paladin tanks (warr seems to struggle with agro) in 10 man
25 man 6-7 healers (just to be safe) Since most of the bosses are about survival and not dps

* LK Update (doable)

LK added

Improved tank switching for all bosses

Fixed PP gas cloud kiting
Malleable goo todo (dont know how to detect it since its not object or npc) just summon ranged bots to safe position to bypass

BPC  fixed OT sometimes not tanking kele
kinectic bombs todo (for now player should take care of them)

Sindragosa fixed rare case when she is in air phase but tombs went to last phase position

LK
Bots can handle necrotic
Bots can handle adds
Bots should focus valkyre that actually grabbed someone (if unlucky and player just use attack command and summon bots to you if they are far away from you) if they grab bots you can either summon to make them useless or let bots cc them and do it legit way.

Defile should be watched by player and once it was cast just summon bots to you
Vile spirits for some reason go to the ground and get nuked by bots aoe spells so there is not much to be done

**Player needs to be alive the whole LK fight since you will have to watch out for frost spehers (sometimes bots ignore them), summon bots when defile is up and summon ranged bots if they get stuck near shambling or raging spirits since their aoe will wipe you)

all in all LK  is doable both 10 and 25nm, player needs to have knowledge of lk fight and needs to know how to use multibot addon and make macros for eg summoning or commanding groups of bots or individual bots)

Dont forget frost/shadow/nature resist auras in whole ICC since it will help alot

I have done whole icc 10 and 25 with 2 pala tanks, 2/5 heals and rest dps,  if you use +1 or +2 heals it should be easier (since I was testing I did close to 0 dmg in fights same with heals)

* fixed changes made by mistake

fix

* Malleable fix (simple spread mechanic)

Malleable mechanic added (simple spread for now)
Gas cloud fixed (Bots sometimes got stuck between puddle and kite location)

* Defile Update

Bots detect and avoid defile (they struggle to find a way back to the boss around it tho, use summon to help them)

Melee bots should be able to stand behind/to the flank of shambling/spirits

* GS fixed bots not returning to their ship for A and H

Bots will return back to ship after killing mage

* PP gas cloud kiting improved

PP gas cloud kiting improved

* BPC targeting fixed

Bots will mark valid prince with skull RTI now

* BQL added melee spread in air pahse

BQL added melee spread

* VDW healing rotation improved

Healers will now use strong heals and hots

* Fixed Necrotic Plague

Fixed issue with Necrotic where it would get dispelled too soon, or would not get dispelled at all

* LK Update

Refined defile logic
Added 3 points for ranged and melee in winter phase (east, west, south when facing throne)
fixed frost spheres targeting (hunter will focus them)
Atm bots will reset z axis if they fall underground or if they get teleported by lk
Better positioning in 1st phase

* 10HC update until PP

LK defile improved for 10nm (bots sometimes stood 2 close to defile until it grew few times)

Improved rotface for HC

PP remade for 10HC.
Gas cloud is now properly kited
Fixed a rare case of server crash when there were ooze and gas cloud alive at same time.
Bots will move around puddles according to its size now.
Bots that get unboud plague will simply move away from raid and die thus loosing it from raid.
Volatile ooze improved stacking.
Fixed ranged sometimes glitching thru walls when spreading out from other members.

10HC PP is now doable but its hard without summoning (summoning break gascloud and ooze targets so its easier to do). You need to watch boss so you dont phase 2 soon otherwise you will get 2x ooze and cloud which is almoust always a wipe. If abo is not played near perfection bots will struggle with oozes and gas clouds if they are not slowed on time. Always save energy to slow gas cloud since it will wipe the group if it reach its target.
Bots will sometimes stand in puddle, just command them to move and they will figure out what to do.

todo (proper malleable handling)

* Up until Sindy 10HC

BPC added shadow prison handling, bots stop moving if more than 12 stack, tanks more than 18
Improved spreading logic

VDW
fixed issue where bots in portal wold move at half speed compared to real player

* fixed accidental change

* LK 10HC update

Added Shadow trap logic
(if they stand in it, not a big deal since bots wont get yeeted only players will)
When harvest soul, only player will be in another dimension (you must survive)

**Sindy and LK can be done, but I must dissapoint purist, at my skill level I could not achieve to do HC without using summon or other "cheat" bot functions.

Other bosses are all doable now in 10hc

src/strategy/raids/icecrown/RaidIccTriggers.cpp

@@ -551,6 +551,10 @@ bool IccValithriaPortalTrigger::IsActive()
 
 bool IccValithriaHealTrigger::IsActive()
 {
+    Unit* boss = AI_VALUE2(Unit*, "find target", "valithria dreamwalker");
+    if (!boss) 
+        return false;
+
     // Only healers should use healing
     if (!botAI->IsHeal(bot) || bot->HasAura(70766))
         return false;
@@ -600,6 +604,9 @@ bool IccSindragosaFrostBeaconTrigger::IsActive()
     if (!group)
         return false;
 
+    if (boss->HasUnitMovementFlag(MOVEMENTFLAG_DISABLE_GRAVITY) && !boss->HealthBelowPct(35))
+        return true;
+
     Group::MemberSlotList const& groupSlot = group->GetMemberSlots();
     for (Group::member_citerator itr = groupSlot.begin(); itr != groupSlot.end(); ++itr)
     {
@@ -619,7 +626,7 @@ bool IccSindragosaBlisteringColdTrigger::IsActive()
     if (!boss)
         return false;
 
-    if (botAI->IsMainTank(bot) || botAI->IsAssistTank(bot) || botAI->IsTank(bot))
+    if (botAI->IsMainTank(bot))
         return false;
 
     // Don't move if any bot in group has ice tomb
@@ -627,6 +634,11 @@ bool IccSindragosaBlisteringColdTrigger::IsActive()
     if (!group)
         return false;
 
+    float dist = bot->GetDistance(boss);
+    
+    if (dist >= 30.0f)
+        return false;
+
     bool isCasting = boss->HasUnitState(UNIT_STATE_CASTING);
     bool isBlisteringCold = boss->FindCurrentSpellBySpellId(70123) || boss->FindCurrentSpellBySpellId(71047) ||
                            boss->FindCurrentSpellBySpellId(71048) || boss->FindCurrentSpellBySpellId(71049);
@@ -658,15 +670,20 @@ bool IccSindragosaMysticBuffetTrigger::IsActive()
     if (!boss)
         return false;
     
-    Aura* aura = bot->GetAura(70127);
-    Aura* aura2 = bot->GetAura(72528);
-    if (!aura && !aura2)
+    if (botAI->IsTank(bot) && boss->GetVictim() == bot)
         return false;
 
-    if (bot->HasAura(70126))  // Ice Block
+    Aura* aura = botAI->GetAura("mystic buffet", bot, false, true);
+    if (!aura)
         return false;
 
-    if ((aura && aura->GetStackAmount() >= 3) || (aura2 && aura2->GetStackAmount() >= 3))
+    if (bot->HasAura(70126))  // Frost Beacon
+        return false;
+
+    if (aura->GetStackAmount() >= 2 && botAI->IsAssistTank(bot))
+        return true;
+
+    if (aura->GetStackAmount() >= 3)
         return true;
 
     return false;
@@ -678,27 +695,35 @@ bool IccSindragosaMainTankMysticBuffetTrigger::IsActive()
     if (!boss)
         return false;
 
-    if (!botAI->IsAssistTankOfIndex(bot, 0))
-    {
+    if (botAI->IsTank(bot) && boss->GetVictim() == bot)
         return false;
-    }
+
+    // Only for assist tank
+    if (!botAI->IsAssistTankOfIndex(bot, 0))
+        return false;
+
+    // Don't swap if we have frost beacon
+    if (bot->HasAura(70126))   // Frost Beacon
+        return false;
+
     Unit* mt = AI_VALUE(Unit*, "main tank");
     if (!mt)
-    {
         return false;
-    }
-    Aura* aura = botAI->GetAura("mystic buffet", mt, false, true);
-    if (!aura || aura->GetStackAmount() < 8)
-    {
+
+    // Check main tank stacks
+    Aura* mtAura = botAI->GetAura("mystic buffet", mt, false, true);
+    if (!mtAura || mtAura->GetStackAmount() < 9)
+        return false;
+
+    // Check our own stacks - don't taunt if we have too many
+    Aura* selfAura = botAI->GetAura("mystic buffet", bot, false, true);
+    if (selfAura && selfAura->GetStackAmount() > 6)
         return false;
-    }
 
     // Only taunt if we're in position
     float distToTankPos = bot->GetExactDist2d(ICC_SINDRAGOSA_TANK_POSITION);
     if (distToTankPos > 3.0f)
-    {
         return false;
-    }
 
     return true;
 }
@@ -706,26 +731,41 @@ bool IccSindragosaMainTankMysticBuffetTrigger::IsActive()
 bool IccSindragosaTankSwapPositionTrigger::IsActive()
 {
     Unit* boss = AI_VALUE2(Unit*, "find target", "sindragosa");
-    if (!boss) return false;
+    if (!boss)
+        return false;
 
-    if (!botAI->IsAssistTankOfIndex(bot, 0)) return false;
+    // Only for assist tank
+    if (!botAI->IsAssistTankOfIndex(bot, 0))
+        return false;
 
-    // Don't tank swap if we have frost beacon
-    if (bot->HasAura(70126)) return false;  // Frost Beacon
+    // Don't move to position if we have frost beacon
+    if (bot->HasAura(70126))   // Frost Beacon
+        return false;
 
-    // First check our own stacks - don't try to tank if we have too many
+    // Check our own stacks - don't try to tank if we have too many
     Aura* selfAura = botAI->GetAura("mystic buffet", bot, false, true);
-    if (selfAura && selfAura->GetStackAmount() >= 8) return false;
+    if (selfAura && selfAura->GetStackAmount() > 6)
+        return false;
 
     // Check if main tank has high stacks
     Unit* mt = AI_VALUE(Unit*, "main tank");
-    if (!mt) return false;
+    if (!mt)    
+        return false;
 
-    Aura* aura = botAI->GetAura("mystic buffet", mt, false, true);
-    if (!aura) return false;
+    Aura* mtAura = botAI->GetAura("mystic buffet", mt, false, true);
+    if (!mtAura)
+        return false;
 
-    uint32 stacks = aura->GetStackAmount();
-    return (stacks >= 7);  // Start moving at 7 stacks
+    uint32 mtStacks = mtAura->GetStackAmount();
+    if (mtStacks < 9)  // Only start moving when MT has 5+ stacks
+        return false;
+
+    // Check if we're already in position
+    float distToTankPos = bot->GetExactDist2d(ICC_SINDRAGOSA_TANK_POSITION);
+    if (distToTankPos <= 3.0f)
+        return false;
+
+    return true;  // Move to position if all conditions are met
 }
 
 bool IccSindragosaFrostBombTrigger::IsActive()
@@ -748,6 +788,17 @@ bool IccSindragosaFrostBombTrigger::IsActive()
     return false;
 }
 
+//LK
+
+bool IccLichKingShadowTrapTrigger::IsActive()
+{
+    Unit* boss = AI_VALUE2(Unit*, "find target", "the lich king");
+    if (!boss)
+        return false;
+
+    return true;
+}
+
 bool IccLichKingNecroticPlagueTrigger::IsActive()
 {
     if (!bot || !bot->IsAlive())