nchebrov/mod-playerbots
1
0
Fork 0
mirror of https://github.com/mod-playerbots/mod-playerbots.git synced 2026-01-13 00:58:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable bot XP gain when master has XP turned off (#1910)

Browse Source 
Addresses #1846

This PR disables XP gain for bots whose non-bot master has disabled XP
gain via an "Experience Eliminator" NPC.

If the current master has disabled XP gain, randombots in the group and
addclass-bots belonging to the player won't gain XP.
Randombots not grouped with a player will continue to gain XP as normal.

Discussed points:
- `Should this feature only be enabled via a new configuration value?`:
Comments currently tend towards no config value.

Open points:
- Should bots be allowed to gain XP until they reach the player's level,
even if the player has disabled XP gain?
This commit is contained in:
HennyWilly
2025-12-16 22:23:34 +01:00
committed by GitHub
parent 00cb177c86
commit c1222da8b0
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/Playerbots.cpp
View File

@@ -238,12 +238,22 @@ public:
void OnPlayerGiveXP(Player* player, uint32& amount, Unit* /*victim*/, uint8 /*xpSource*/) override void OnPlayerGiveXP(Player* player, uint32& amount, Unit* /*victim*/, uint8 /*xpSource*/) override
{ {
// early return // no XP multiplier, when player is no bot.
if (sPlayerbotAIConfig->randomBotXPRate == 1.0 || !player) if (!player || !player->GetSession()->IsBot())
return; return;
// no XP multiplier, when player is no bot. // no XP gain, if master is not a bot and has xp gain disabled.
if (!player->GetSession()->IsBot() || !sRandomPlayerbotMgr->IsRandomBot(player)) if (const Player* master = GET_PLAYERBOT_AI(player)->GetMaster())
{
if (!master->GetSession()->IsBot() && master->HasPlayerFlag(PLAYER_FLAGS_NO_XP_GAIN))
{
amount = 0;
return;
}
}
// early return
if (sPlayerbotAIConfig->randomBotXPRate == 1.0 || !sRandomPlayerbotMgr->IsRandomBot(player))
return; return;
// no XP multiplier, when bot is in a group with a real player. // no XP multiplier, when bot is in a group with a real player.