nchebrov/mod-playerbots
1
0
Fork 0
mirror of https://github.com/mod-playerbots/mod-playerbots.git synced 2026-01-13 00:58:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Quickfix: performance problems (XP gain when master has XP turned off) (#1947)

Browse Source 
Disable bot XP gain when master has XP turned off feature has a big
performance impact.

Instead of reverting placed back to original code before the feature
PR's for now as quickfix
This commit is contained in:
bashermens
2025-12-25 02:07:59 +01:00
committed by GitHub
parent 88016789ba
commit 1fcd6c5cda
1 changed files with 14 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/Playerbots.cpp
View File

@@ -264,46 +264,33 @@ public:
void OnPlayerGiveXP(Player* player, uint32& amount, Unit* /*victim*/, uint8 /*xpSource*/) override void OnPlayerGiveXP(Player* player, uint32& amount, Unit* /*victim*/, uint8 /*xpSource*/) override
{ {
if (!player || !player->IsInWorld()) // early return
if (sPlayerbotAIConfig->randomBotXPRate == 1.0 || !player)
return; return;
if (WorldSession* session = player->GetSession(); !session || !session->IsBot()) // no XP multiplier, when player is no bot.
if (!player->GetSession()->IsBot() || !sRandomPlayerbotMgr->IsRandomBot(player))
return; return;
PlayerbotAI* botAI = GET_PLAYERBOT_AI(player); // no XP multiplier, when bot is in a group with a real player.
if (!botAI)
return;
// No XP gain if master is a real player with XP gain disabled
if (const Player* master = botAI->GetMaster())
{
if (WorldSession* masterSession = master->GetSession();
masterSession && !masterSession->IsBot() &&
master->HasPlayerFlag(PLAYER_FLAGS_NO_XP_GAIN))
{
amount = 0; // disable XP multiplier
return;
}
}
// From here on we only care about random bots
if (sPlayerbotAIConfig->randomBotXPRate == 1.0f || !sRandomPlayerbotMgr->IsRandomBot(player))
return;
// No XP multiplier if bot is in a group with at least one real player
if (Group* group = player->GetGroup()) if (Group* group = player->GetGroup())
{ {
for (GroupReference* gref = group->GetFirstMember(); gref; gref = gref->next()) for (GroupReference* gref = group->GetFirstMember(); gref; gref = gref->next())
{ {
if (Player* member = gref->GetSource()) Player* member = gref->GetSource();
if (!member)
{
continue;
}
if (!member->GetSession()->IsBot())
{ {
if (WorldSession* session = member->GetSession();session && !session->IsBot())
return; return;
} }
} }
} }
// Otherwise apply XP multiplier // otherwise apply bot XP multiplier.
amount = static_cast<uint32>(std::round(static_cast<float>(amount) * sPlayerbotAIConfig->randomBotXPRate)); amount = static_cast<uint32>(std::round(static_cast<float>(amount) * sPlayerbotAIConfig->randomBotXPRate));
} }
}; };