nchebrov/mod-playerbots
1
0
Fork 0
mirror of https://github.com/mod-playerbots/mod-playerbots.git synced 2026-01-13 00:58:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update RaidUlduarBossHelper.cpp

Browse Source
This commit is contained in:
avirar
2024-12-22 10:29:07 +11:00
committed by GitHub
parent 27441e9369
commit 10fd4fb014
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/strategy/raids/ulduar/RaidUlduarBossHelper.cpp
View File

@@ -145,33 +145,35 @@ void RazorscaleBossHelper::AssignRolesBasedOnHealth()
if (!group) if (!group)
return; return;
// Gather all tank bots in the group, excluding those with Fuse Armor // Gather all tank-capable players (bots and real players) in the group, excluding those with Fuse Armor
std::vector<Player*> tankBots; std::vector<Player*> tankCandidates;
for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next()) for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next())
{ {
Player* member = ref->GetSource(); Player* member = ref->GetSource();
if (!member || !botAI->IsTank(member) || !member->IsAlive()) if (!member || !botAI->IsTank(member, true) || !member->IsAlive())
continue; continue;
Aura* fuseArmor = member->GetAura(SPELL_FUSEARMOR); Aura* fuseArmor = member->GetAura(SPELL_FUSEARMOR);
if (fuseArmor && fuseArmor->GetStackAmount() >= FUSEARMOR_THRESHOLD) if (fuseArmor && fuseArmor->GetStackAmount() >= FUSEARMOR_THRESHOLD)
continue; continue;
tankBots.push_back(member); tankCandidates.push_back(member);
} }
if (tankBots.empty()) if (tankCandidates.empty())
return; return;
// Sort tanks by max health descending // Sort tanks by max health descending
std::sort(tankBots.begin(), tankBots.end(), std::sort(tankCandidates.begin(), tankCandidates.end(),
[](Player* a, Player* b) [](Player* a, Player* b)
{ {
return a->GetMaxHealth() > b->GetMaxHealth(); return a->GetMaxHealth() > b->GetMaxHealth();
} }
); );
Player* newMainTank = tankBots[0]; Player* newMainTank = tankCandidates[0];
if (!newMainTank) // Safety check
return;
// Remove all MAINTANK flags // Remove all MAINTANK flags
for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next()) for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next())
@@ -185,13 +187,11 @@ void RazorscaleBossHelper::AssignRolesBasedOnHealth()
group->SetGroupMemberFlag(newMainTank->GetGUID(), true, MEMBER_FLAG_MAINTANK); group->SetGroupMemberFlag(newMainTank->GetGUID(), true, MEMBER_FLAG_MAINTANK);
// Notify if the new main tank is a real player // Notify if the new main tank is a real player
if (GET_PLAYERBOT_AI(newMainTank)->IsRealPlayer()) if (GET_PLAYERBOT_AI(newMainTank) && GET_PLAYERBOT_AI(newMainTank)->IsRealPlayer())
{ {
const std::string playerName = newMainTank->GetName(); const std::string text = newMainTank->GetName() + ", please taunt Razorscale now!";
const std::string text = playerName + ", please taunt Razorscale now!";
botAI->Say(text); botAI->Say(text);
} }
_lastRoleSwapTime = std::time(nullptr); _lastRoleSwapTime = std::time(nullptr);
} }