Add thread safety for group operations (#1816)

Fixes crashes and race conditions when bots perform group/guild/arena
operations by moving thread-unsafe code to world thread.

Potentially fixes #1124

## Changes

- Added operation queue system that runs in world thread
- Group operations (invite, remove, convert to raid, set leader) now
queued
- Arena formation refactored to use queue
- Guild operations changed to use packet queueing

## Testing

Set `MapUpdate.Threads` > 1 in worldserver.conf to enable multiple map
threads, then test:
- Group formation and disbanding
- Arena team formation
- Guild operations (invite, promote, demote, remove)

- Run with TSAN
cmake ../ \
  -DCMAKE_CXX_FLAGS="-fsanitize=thread -g -O1" \
  -DCMAKE_C_FLAGS="-fsanitize=thread -g -O1" \
  -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=thread" \
  -DCMAKE_INSTALL_PREFIX=/path/to/install \
  -DCMAKE_BUILD_TYPE=RelWithDebInfo

build

export
TSAN_OPTIONS="log_path=tsan_report:halt_on_error=0:second_deadlock_stack=1"
./worldserver

The crashes/race conditions should no longer occur with concurrent map
threads.

## New Files

- `PlayerbotOperation.h` - Base class defining the operation interface
(Execute, IsValid, GetPriority)
- `PlayerbotOperations.h` - Concrete implementations:
GroupInviteOperation, GroupRemoveMemberOperation,
GroupConvertToRaidOperation, GroupSetLeaderOperation,
ArenaGroupFormationOperation
- `PlayerbotWorldThreadProcessor.h/cpp` - Singleton processor with
mutex-protected queue, processes operations in WorldScript::OnUpdate
hook, handles batch processing and validation

---------

Co-authored-by: blinkysc <blinkysc@users.noreply.github.com>
Co-authored-by: SaW <swerkhoven@outlook.com>
Co-authored-by: bash <hermensb@gmail.com>

src/strategy/actions/GuildManagementActions.cpp

@@ -58,6 +58,14 @@ Player* GuidManageAction::GetPlayer(Event event)
     return nullptr;
 }
 
+void GuidManageAction::SendPacket(WorldPacket const& packet)
+{
+    // make a heap copy because QueuePacket takes ownership
+    WorldPacket* data = new WorldPacket(packet);
+
+    bot->GetSession()->QueuePacket(data);
+}
+
 bool GuidManageAction::Execute(Event event)
 {
     Player* player = GetPlayer(event);
@@ -84,12 +92,6 @@ bool GuildInviteAction::isUseful()
     return bot->GetGuildId() && sGuildMgr->GetGuildById(bot->GetGuildId())->HasRankRight(bot, GR_RIGHT_INVITE);
 }
 
-void GuildInviteAction::SendPacket(WorldPacket packet)
-{
-    WorldPackets::Guild::GuildInviteByName data = WorldPacket(packet);
-    bot->GetSession()->HandleGuildInviteOpcode(data);
-}
-
 bool GuildInviteAction::PlayerIsValid(Player* member)
 {
     return !member->GetGuildId() && (sWorld->getBoolConfig(CONFIG_ALLOW_TWO_SIDE_INTERACTION_GUILD) ||
@@ -101,12 +103,6 @@ bool GuildPromoteAction::isUseful()
     return bot->GetGuildId() && sGuildMgr->GetGuildById(bot->GetGuildId())->HasRankRight(bot, GR_RIGHT_PROMOTE);
 }
 
-void GuildPromoteAction::SendPacket(WorldPacket packet)
-{
-    WorldPackets::Guild::GuildPromoteMember data = WorldPacket(packet);
-    bot->GetSession()->HandleGuildPromoteOpcode(data);
-}
-
 bool GuildPromoteAction::PlayerIsValid(Player* member)
 {
     return member->GetGuildId() == bot->GetGuildId() && GetRankId(bot) < GetRankId(member) - 1;
@@ -117,12 +113,6 @@ bool GuildDemoteAction::isUseful()
     return bot->GetGuildId() && sGuildMgr->GetGuildById(bot->GetGuildId())->HasRankRight(bot, GR_RIGHT_DEMOTE);
 }
 
-void GuildDemoteAction::SendPacket(WorldPacket packet)
-{
-    WorldPackets::Guild::GuildDemoteMember data = WorldPacket(packet);
-    bot->GetSession()->HandleGuildDemoteOpcode(data);
-}
-
 bool GuildDemoteAction::PlayerIsValid(Player* member)
 {
     return member->GetGuildId() == bot->GetGuildId() && GetRankId(bot) < GetRankId(member);
@@ -133,12 +123,6 @@ bool GuildRemoveAction::isUseful()
     return bot->GetGuildId() && sGuildMgr->GetGuildById(bot->GetGuildId())->HasRankRight(bot, GR_RIGHT_REMOVE);
 }
 
-void GuildRemoveAction::SendPacket(WorldPacket packet)
-{
-    WorldPackets::Guild::GuildOfficerRemoveMember data = WorldPacket(packet);
-    bot->GetSession()->HandleGuildRemoveOpcode(data);
-}
-
 bool GuildRemoveAction::PlayerIsValid(Player* member)
 {
     return member->GetGuildId() == bot->GetGuildId() && GetRankId(bot) < GetRankId(member);

src/strategy/actions/GuildManagementActions.h

@@ -25,7 +25,7 @@ public:
     bool isUseful() override { return false; }
 
 protected:
-    virtual void SendPacket(WorldPacket data){};
+    virtual void SendPacket(WorldPacket const& packet);
     virtual Player* GetPlayer(Event event);
     virtual bool PlayerIsValid(Player* member);
     virtual uint8 GetRankId(Player* member);
@@ -44,7 +44,6 @@ public:
     bool isUseful() override;
 
 protected:
-    void SendPacket(WorldPacket data) override;
     bool PlayerIsValid(Player* member) override;
 };
 
@@ -59,7 +58,6 @@ public:
     bool isUseful() override;
 
 protected:
-    void SendPacket(WorldPacket data) override;
     bool PlayerIsValid(Player* member) override;
 };
 
@@ -74,7 +72,6 @@ public:
     bool isUseful() override;
 
 protected:
-    void SendPacket(WorldPacket data) override;
     bool PlayerIsValid(Player* member) override;
 };
 
@@ -89,7 +86,6 @@ public:
     bool isUseful() override;
 
 protected:
-    void SendPacket(WorldPacket data) override;
     bool PlayerIsValid(Player* member) override;
 };
 

src/strategy/actions/InviteToGroupAction.cpp

@@ -9,7 +9,9 @@
 #include "Event.h"
 #include "GuildMgr.h"
 #include "Log.h"
+#include "PlayerbotOperations.h"
 #include "Playerbots.h"
+#include "PlayerbotWorldThreadProcessor.h"
 #include "ServerFacade.h"
 
 bool InviteToGroupAction::Invite(Player* inviter, Player* player)
@@ -27,7 +29,10 @@ bool InviteToGroupAction::Invite(Player* inviter, Player* player)
     {
         if (GET_PLAYERBOT_AI(player) && !GET_PLAYERBOT_AI(player)->IsRealPlayer())
             if (!group->isRaidGroup() && group->GetMembersCount() > 4)
-                group->ConvertToRaid();
+            {
+                auto convertOp = std::make_unique<GroupConvertToRaidOperation>(inviter->GetGUID());
+                sPlayerbotWorldProcessor->QueueOperation(std::move(convertOp));
+            }
     }
 
     WorldPacket p;
@@ -89,7 +94,10 @@ bool InviteNearbyToGroupAction::Execute(Event event)
         // When inviting the 5th member of the group convert to raid for future invites.
         if (group && botAI->GetGrouperType() > GrouperType::LEADER_5 && !group->isRaidGroup() &&
             bot->GetGroup()->GetMembersCount() > 3)
-            group->ConvertToRaid();
+        {
+            auto convertOp = std::make_unique<GroupConvertToRaidOperation>(bot->GetGUID());
+            sPlayerbotWorldProcessor->QueueOperation(std::move(convertOp));
+        }
 
         if (sPlayerbotAIConfig->inviteChat && sRandomPlayerbotMgr->IsRandomBot(bot))
         {
@@ -221,7 +229,8 @@ bool InviteGuildToGroupAction::Execute(Event event)
         if (group && botAI->GetGrouperType() > GrouperType::LEADER_5 && !group->isRaidGroup() &&
             bot->GetGroup()->GetMembersCount() > 3)
         {
-            group->ConvertToRaid();
+            auto convertOp = std::make_unique<GroupConvertToRaidOperation>(bot->GetGUID());
+            sPlayerbotWorldProcessor->QueueOperation(std::move(convertOp));
         }
 
         if (sPlayerbotAIConfig->inviteChat &&
@@ -362,7 +371,10 @@ bool LfgAction::Execute(Event event)
             if (param.empty() || param == "5" || group->isRaidGroup())
                 return false;  // Group or raid is full so stop trying.
             else
-                group->ConvertToRaid();  // We want a raid but are in a group so convert and continue.
+            {
+                auto convertOp = std::make_unique<GroupConvertToRaidOperation>(requester->GetGUID());
+                sPlayerbotWorldProcessor->QueueOperation(std::move(convertOp));
+            }
         }
 
         Group::MemberSlotList const& groupSlot = group->GetMemberSlots();

src/strategy/actions/PassLeadershipToMasterAction.cpp

@@ -6,16 +6,17 @@
 #include "PassLeadershipToMasterAction.h"
 
 #include "Event.h"
+#include "PlayerbotOperations.h"
 #include "Playerbots.h"
+#include "PlayerbotWorldThreadProcessor.h"
 
 bool PassLeadershipToMasterAction::Execute(Event event)
 {
     if (Player* master = GetMaster())
         if (master && master != bot && bot->GetGroup() && bot->GetGroup()->IsMember(master->GetGUID()))
         {
-            WorldPacket p(SMSG_GROUP_SET_LEADER, 8);
-            p << master->GetGUID();
-            bot->GetSession()->HandleGroupSetLeaderOpcode(p);
+            auto setLeaderOp = std::make_unique<GroupSetLeaderOperation>(bot->GetGUID(), master->GetGUID());
+            sPlayerbotWorldProcessor->QueueOperation(std::move(setLeaderOp));
 
             if (!message.empty())
                 botAI->TellMasterNoFacing(message);