From 0d19f298dacf9d75e559e802de0366f52b381aae Mon Sep 17 00:00:00 2001
From: Yunfan Li <56597220+liyunfan1223@users.noreply.github.com>
Date: Thu, 10 Apr 2025 21:00:05 +0800
Subject: [PATCH] Loot packet fix (#1190)

---
 src/strategy/actions/LootAction.cpp | 40 ++++++++++++++++-------------
 1 file changed, 22 insertions(+), 18 deletions(-)

diff --git a/src/strategy/actions/LootAction.cpp b/src/strategy/actions/LootAction.cpp
index 95e4a744..a80ab306 100644
--- a/src/strategy/actions/LootAction.cpp
+++ b/src/strategy/actions/LootAction.cpp
@@ -29,9 +29,10 @@ bool LootAction::Execute(Event event)
 
     if (!prevLoot.IsEmpty() && prevLoot.guid != lootObject.guid)
     {
-        WorldPacket packet(CMSG_LOOT_RELEASE, 8);
-        packet << prevLoot.guid;
-        bot->GetSession()->HandleLootReleaseOpcode(packet);
+        WorldPacket* packet = new WorldPacket(CMSG_LOOT_RELEASE, 8);
+        *packet << prevLoot.guid;
+        bot->GetSession()->QueuePacket(packet);
+        // bot->GetSession()->HandleLootReleaseOpcode(packet);
     }
 
     context->GetValue<LootObject>("loot target")->Set(lootObject);
@@ -91,9 +92,10 @@ bool OpenLootAction::DoLoot(LootObject& lootObject)
 
     if (creature && creature->HasFlag(UNIT_DYNAMIC_FLAGS, UNIT_DYNFLAG_LOOTABLE))
     {
-        WorldPacket packet(CMSG_LOOT, 8);
-        packet << lootObject.guid;
-        bot->GetSession()->HandleLootOpcode(packet);
+        WorldPacket* packet = new WorldPacket(CMSG_LOOT, 8);
+        *packet << lootObject.guid;
+        bot->GetSession()->QueuePacket(packet);
+        // bot->GetSession()->HandleLootOpcode(packet);
         botAI->SetNextCheckDelay(sPlayerbotAIConfig->lootDelay);
         return true;
     }
@@ -423,9 +425,10 @@ bool StoreLootAction::Execute(Event event)
                         sGuildTaskMgr->CheckItemTask(itemid, itemcount, ref->GetSource(), bot);
         }
 
-        WorldPacket packet(CMSG_AUTOSTORE_LOOT_ITEM, 1);
-        packet << itemindex;
-        bot->GetSession()->HandleAutostoreLootItemOpcode(packet);
+        WorldPacket* packet = new WorldPacket(CMSG_AUTOSTORE_LOOT_ITEM, 1);
+        *packet << itemindex;
+        bot->GetSession()->QueuePacket(packet);
+        // bot->GetSession()->HandleAutostoreLootItemOpcode(packet);
         botAI->SetNextCheckDelay(sPlayerbotAIConfig->lootDelay);
 
         if (proto->Quality > ITEM_QUALITY_NORMAL && !urand(0, 50) && botAI->HasStrategy("emote", BOT_STATE_NON_COMBAT) && sPlayerbotAIConfig->randomBotEmote)
@@ -440,9 +443,10 @@ bool StoreLootAction::Execute(Event event)
     AI_VALUE(LootObjectStack*, "available loot")->Remove(guid);
 
     // release loot
-    WorldPacket packet(CMSG_LOOT_RELEASE, 8);
-    packet << guid;
-    bot->GetSession()->HandleLootReleaseOpcode(packet);
+    WorldPacket* packet = new WorldPacket(CMSG_LOOT_RELEASE, 8);
+    *packet << guid;
+    bot->GetSession()->QueuePacket(packet);
+    // bot->GetSession()->HandleLootReleaseOpcode(packet);
     return true;
 }
 
@@ -507,17 +511,17 @@ bool ReleaseLootAction::Execute(Event event)
     GuidVector gos = context->GetValue<GuidVector>("nearest game objects")->Get();
     for (ObjectGuid const guid : gos)
     {
-        WorldPacket packet(CMSG_LOOT_RELEASE, 8);
-        packet << guid;
-        bot->GetSession()->HandleLootReleaseOpcode(packet);
+        WorldPacket* packet = new WorldPacket(CMSG_LOOT_RELEASE, 8);
+        *packet << guid;
+        bot->GetSession()->QueuePacket(packet);
     }
 
     GuidVector corpses = context->GetValue<GuidVector>("nearest corpses")->Get();
     for (ObjectGuid const guid : corpses)
     {
-        WorldPacket packet(CMSG_LOOT_RELEASE, 8);
-        packet << guid;
-        bot->GetSession()->HandleLootReleaseOpcode(packet);
+        WorldPacket* packet = new WorldPacket(CMSG_LOOT_RELEASE, 8);
+        *packet << guid;
+        bot->GetSession()->QueuePacket(packet);
     }
 
     return true;