From 8169ab94c808a991a5e9711c12824942529bbfdb Mon Sep 17 00:00:00 2001 From: MDIC Date: Sat, 11 Jun 2022 09:01:53 -0400 Subject: [PATCH] fix (core): Dead Locks On high player populations deadlocks seem to be caused when you use the .anticheat global gm cmds. SaveAllPlayer is just not necessary or needed in this module which would cause the possible deadlock issues. Its already set to save the player's anticheat data statistics ever minute already. This save all is not need. --- src/AnticheatMgr.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/AnticheatMgr.cpp b/src/AnticheatMgr.cpp index ccd419a..92ccf3e 100644 --- a/src/AnticheatMgr.cpp +++ b/src/AnticheatMgr.cpp @@ -938,9 +938,6 @@ void AnticheatMgr::BuildReport(Player* player, uint16 reportType) void AnticheatMgr::AnticheatGlobalCommand(ChatHandler* handler) { - // MySQL will sort all for us, anyway this is not the best way we must only save the anticheat data not whole player's data!. - ObjectAccessor::SaveAllPlayers(); - QueryResult resultDB = CharacterDatabase.Query("SELECT guid,average,total_reports FROM players_reports_status WHERE total_reports != 0 ORDER BY average ASC LIMIT 3;"); if (!resultDB) {