Commit Graph

22 Commits

Author SHA1 Message Date
Nathan Handley
df33a57b78 feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass (#18243)
* Class Comparison Logic Encapsulation - Parity

* Add Context to IsClass

* Add Unit IsClass script hook

* Replace additional getClass with IsClass

* Update CanUseItem to replace getClass with IsClass

* Add separate context for pet vs ability

* Change Create to Init since not all referenced contexts are creation

* Align spacing in ClassContext

* Drop context on LFGManager max power

* Update IsClass context that wraps around Missle Barrage

* Rename context for swapping weapons

* Be more specific than CLASS_CONTEXT_TALENT

* Remove duplicate context

* Moved IsClass Hook to Player

* Removed unused parameter in virtual base function

* Added maybe_unused to IsClass virtual in order to compile

To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it

* Remove extra blank line

* Add ABILITY_REACTIVE context

* Add context for PET_CHARM

* Remove explicit nullopt check per review

* Code Readability - Change if to if else in pet

Due to the return pattern, this doesn't change functionality in any way

* Add OnPlayer to disambiguate

---------

Co-authored-by: NathanHandley <nathanhandley@protonmail.com>
2024-02-10 12:25:00 -03:00
Winfidonarleyan
e90d7a2f92 chore(Core/Misc): sort includes (#17776)
* chore(Cleanup): sort includes

* fix build

* fix build again
2023-11-18 17:51:26 +01:00
Kitzunu
4870b14b1f refactor(Core/Object): getLevel() -> GetLevel() (#14122)
* refactor(Core/Object): getLevel() -> GetLevel()

* fix build and sneak some doxygen in

* codeSTLE

* codestyle
2022-12-31 17:39:23 +01:00
Angelo Venturini
252755415c fix(Core/Spells): Overflow damage (#13424) 2022-10-15 19:42:25 -03:00
UltraNix
e390087efd feat(Core/Items): Implemented elemental weapon damage. Source: Trinit… (#13050)
...yCore.
2022-10-08 14:34:52 -03:00
Kitzunu
cf65cd6baf refactor(Core/Misc): sqrt/log/exp() to std::sqrt/log/exp() (#9792) 2022-02-09 11:59:30 +01:00
Kitzunu
b50984e9bf feat(Core/Player): Stats limitation (#10403)
Co-authored-by: Corbi <12052933+corbi@users.noreply.github.com>
2022-02-04 17:56:53 +01:00
Kargatum
52aa0e9966 feat(License): add new headers information about license (#7941)
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
2021-09-30 13:40:52 +07:00
Francesco Borzì
f73ef1cd5a fix(Core/Unit): -Wdeprecated-enum-enum-conversion warning (#6868) 2021-07-13 11:51:58 +02:00
Francesco Borzì
466cdb68d6 refactor(Core): code cleanup (part 2) (#6374) 2021-06-16 20:40:42 +02:00
Hacki95
2031e55ec7 fix(DB/Core) Fix the CLS damage system and update creature_classlevelstats (#4749)
* Fix the CLS dmg system

Thanks to TC: ccfa82e7d5
2021-03-19 17:26:30 -06:00
Francesco Borzì
f6a17164be fix(Core/License): issue with old files license (#4762) 2021-03-17 09:46:01 -06:00
Kitzunu
dbc0ff6554 refactor(Core): sort #includes alphabetically (#4579) 2021-02-24 22:34:42 +01:00
Kargatum
ea93a5c1a1 feat(CI/Codestyle): added codestyle check (#3668) 2021-01-09 11:59:50 +01:00
Kargatum
a2b26272d2 refactor(Core/Game): restyle game lib with astyle (#3466) 2020-10-12 10:08:15 +02:00
Kaev
2fa9f5c249 fix(Core): potential crashes/bugs reported by static analysis #2 (#2622) 2020-02-03 07:52:27 +01:00
Francesco Borzì
7c7c5eb203 Core/DB: refactor(creature_template): closes #1181 (#1322)
* refactor(creature_template): closes #1181

* chore: improve code readability
2019-01-20 13:39:32 +03:00
Nefertumm
dd300003e2 Update license links (#783) 2018-03-12 10:54:57 +01:00
Yehonal
17332304fd Using TC structure allowing easier patches importing 2017-12-21 00:20:29 +01:00
Yehonal
b0c8eceb08 Refactoring part 2 [W.I.P] 2016-08-12 02:38:26 +02:00
Yehonal
f6eefedcd5 converted all tabs to 4 spaces 2016-06-26 19:23:57 +02:00
Yehonal
e8e94a0a66 First Commit
For Azeroth!
2016-06-26 10:39:44 +02:00