Commit Graph

4161 Commits

Author SHA1 Message Date
Jelle Meeus
99004116a5 fix(Scripts/Ulduar): falling down Kologarn's pit should kill (#18945)
* add insersectboundary

* add kill bunny to kologarn's pit

* Update data/sql/updates/pending_db_world/rev_1716571588345702920.sql

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* refactor: use Map DoForAllPlayers

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
2024-05-26 14:38:16 -03:00
Jelle Meeus
bb1f7622cc fix(ICC/Sindragosa): add a cooldown to proccing Unchained Magic (#18901)
* add cooldown to proc

* convert to spell and aurascript pair macro

* remove no longer needed validate override

* set cooldown with Cooldown field in table spell_proc_event
2024-05-26 13:12:20 -03:00
Jelle Meeus
29dda79638 fix(Scripts/Ulduar): Add emote for opening of the Ancient Gate of the Keepers (#18949)
add ancient gate emote
2024-05-26 13:11:50 -03:00
Jelle Meeus
bb19dbf3c9 fix(Scripts/Ulduar) Kologarn becomes a bridge (#18944)
* disable_move is already set in unit_flags creature template

* make kolo not selectable, disable gravity on death
2024-05-25 18:42:46 +02:00
Jelle Meeus
845fa07aad fix(Scripts/Ulduar): update Boss Keepers, Gossip Keepers, Yogg Keepers, Yogg-Saron (#18943)
* gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

gossip keepers, keepers, sara

freya spell

improvements

better gossip

update

converter to update spellscript

refactor sanity wells spawn position, summons zonecombat

make sara summon sanity wells again

thorim casts start again, handle sanity wells only by sanity well spawn
script

refactor sanity

brackets

update comment

* refactor: remove _keepersGUID[4]

* make keeper auras only target players, remove apply scale immunity to well/keepers

include caster in cast

* update keeper flags

* summon and despawn gossip keepers

spawn only if fight done

add intro spell and handle outro

fix off by 1

fix casting simple teleport, only spawn after teleporting

remove empty line

* add teleport to shared ulduar.h

* each keeper triggers their own gossip spawn

* update is called in Reset(), no need to do it here

* add SpellHit override to Freya, Hodir

* Freya, Hodir: use scheduler to schedule post-fight teleport

* JustSummoned rename cr to summon

* sanity well summons are handled by freya instead of sara

* rename pCreature to creature

* keeper use RegisterUlduarCreatureAI

* Freya, Hodir, Thorim: increase despawn time

* despawn tentacles, sanity wells after fight

despawn tentacles after fight

* change order of teleport spells

* am missing header?
2024-05-25 12:06:21 -03:00
Andrew
df688afaff chore(Scripts/Hyjal): Don't initialize headers twice (#18939) 2024-05-23 06:02:10 -03:00
Dan
7f42ec0371 fix(Scripts/Hyjal): initialize/reset local private variables in Reset function (#18932)
initial
2024-05-22 16:15:13 -03:00
Dan
f78820e9d5 fix(Scripts/Hyjal): Air Burst should not be cast on MT (#18933)
* fix movement of doomfire

* fix air burst

* conditions

* movechase random target

* Update boss_archimonde.cpp

* update movement

* Update boss_archimonde.cpp

* Update boss_archimonde.cpp
2024-05-20 22:05:56 -03:00
Andrew
2912cb47f3 fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enr… (#18928)
fix(Scripts/Hyjal): Archimonde shouldn't cast other spells during enrage/outro
2024-05-20 10:40:46 +02:00
Andrew
0aaf521423 fix(Scripts/Hyjal): Limit Anetheron sleep to 3 targets (#18929) 2024-05-20 10:40:28 +02:00
Jelle Meeus
ce32e51552 fix(Scripts/Ulduar): disable Mimiron's and Thorim's Targetting crystal when talking to Bran (#18927)
load Mimiron's and Thorim's Targetting crystal
2024-05-19 22:17:12 -03:00
Mykhailo Redko
c13c1b28e7 fix(Scripts/Commands): Fix .lookup item command for most locales (#18922)
follow-up to 49e3d5d
2024-05-19 11:27:25 +02:00
Jelle Meeus
49e3d5dfff feat(Scripts/Commands): Add quality colors to .item lookup command (#18907)
add quality colors to .item lookup command
2024-05-18 14:08:20 +02:00
silviu20092
3988e9581d feat(core): add hooks for applying item mods (#18760) 2024-05-18 10:02:57 +02:00
Dan
3b4639aa19 fix(Scripts/ShadowmoonValley): minor fixes to Enslaved Netherwing Drakes (#18883)
* init

* fixes
2024-05-17 08:06:25 +02:00
sudlud
e2029c3633 fix(Core/BattlegroundAV): spawn generic gameobjects in Alterac Valley (#18764)
* fix(Scripts/PVP): correctly spawn generic gameobjects in Alterac Valley

I've been "collecting" these in the DB for a while, now it's time to move
these spawns to the AV script and actually spawn them.

* add 2 additional generic gameobjects
2024-05-15 20:41:59 +02:00
Jelle Meeus
b42ca49329 fix(Karazhan/Nightbane): Rain of Bones cast on one random player/pet, summon Skeletons at that location (#18892)
* replace skeletonspawn scheduler with spellscript

* Revert "replace skeletonspawn scheduler with spellscript"

This reverts commit 974bcb805be57c3175d63d91afe656c0bc327a9e.

* random target and remember position

* target position instead of player

* make pets valid targets for rain of bones

* change 100 to 100.0f
2024-05-13 20:39:17 +01:00
Jelle Meeus
d709080029 fix(Karazhan/Nightbane): no longer killable during flight (#18890)
add unkillable during flight phase

_flying: takeoff/landing, moving to location
Phase 2: in the air and casting air spells
2024-05-12 21:06:42 +02:00
Jelle Meeus
85e967183f fix(Scripts/Naxxramas): Re enable Portal Hub teleport requirement (#18844)
fix naxxramas portal hub trigger
2024-05-12 20:53:39 +02:00
sudlud
0f82c8e8dd fix(Core/Events) Implement Fireworks Spectacular (#18860)
* init sql file for fireworks spectacular - add entry in game_event

* add missing delete statement

* add gameobjects 180698 'Party Table, 180699 'Festive Keg, 180700 'Hay Bale 1'

* update comment, add gameobject 180754 Toasting Goblet

- todo: pooling (?) - the tables are quite full
- todo: why are there tables missing? e.g. below:
.go ga 82615

* add gameobject 180905 'Festive Mug'

* add gameobjects 'Firework, Show, Type%'

* add vendors

* add revelers and bruisers

TODO: also add 15906 'Ironforge Reveler'

* remove '%Firework Show%' spawns

- these will be spawned temporarily via script

* add firework gameobject SmartAI

* WIP stormwind fireworks show

steps to test the show:
.go xyz -8984 498 96 0
.gob add temp 180749

* improve handling of fireworks show, add gameobject 180749 'Cheer Speaker' spawns

how to test:
.go ga 64640
.event start 72

* prepare fetching correct show based on map+zone

* introduce typedef for FireworkShow

* Add Teldrassil show

.go ga 64651
.event start 72

* fix Teldrassil and Stormwind shows, add initShow() debug message, replace magic numbers for fireworkShow sizes

- these were broken due to an error in my txt parsing script

* add Shattrath show

.go c 139914
.event start 72

* add Silvermoon show

.go ga 64670
.event start 72

* add Booty Bay show

.go ga 64630
.event start 72

* add Thunder Bluff show, add Exodar show, set firework gameobjects active, update comments, remove _maxCount

* add Underciy show

.go ga 64641
.event start 72

* fix Undercity show indexes

* move code from midsummer.cpp to new file firework_show.cpp

* add Orgrimmar show

.go ga 64647
.event start 72

* add Ironforge show

.go ga 64634
.event start 72

* update shows from sniff parses using fixed export script

* update 'Party Table, 'Festive Keg' and 'Hay Bale 1' spawns with additional sniffs

* update 'Toasting Goblet' spawns with additional sniffs

* update 'Festive Mug' spawns with additional sniffs

* update 'Fireworks Revelers' spawns with additional sniffs

* remove duplicate AND from sql file

* attempt moving FireworkShows to the heap

* start firework show at the full hour and also handle late starts correctly

- also perform a minor cleanup

* do not touch gameobject with guid 16586 which is linked to harvest festival

* move firework_show.cpp to subfolder firework_show

* move firework_show arrays to seperate header files

* update show handling, still not final

* update for new struct design, Teldrassil show running correctly already

* update remaining shows for new firework show structs

* rename go_cheer_speaker to go_firework_show

* update debug / error messages

* update all firework shows for local spawnIndex handling

* spawn 'Toasting Goblet's for 10min after show ende

* add reveler SAI and make revelers cheer on show end

* remove log_error messages

* add comment for festive mugs

* Update firework_show.cpp

* add missing include for uint32

* replace an uint32 with an int

* revert unintended changes in midsummer.cpp

* add #include "GameObjectScript.h"

* remove ThunderBluff Reveler spawns with wandering movement

- these probably should have waypoints instead or just got parsed incorrectly
- it should be safe to remove these for now and probably investigage this further later on

* update function names
2024-05-12 18:39:14 +02:00
Knindza
dd3f4a5f8e fix(Scripts/Zones/Creature): Infra-Green Bomber (#18752)
* Updating Creature.

* Delete data/sql/updates/pending_db_world/rev_1713104748708628400.sql

* Updating Bomber
2024-05-12 11:03:21 +01:00
Balleny
31096df053 fix(Scripts/TheEye): correct first phoenix in p5 (#18802)
correct first phoenix in p5

should spawn 15 seconds before 2nd gravity lapse
2024-05-11 13:54:51 +01:00
Jelle Meeus
d44c8990c1 fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux (#18807)
* fix(Scripts/Spell): Fix Void Zone damage calcs for Netherspite, Blaumeux

* remove blank line

* remove four_horsement_consumption SpellScript

* update comment
2024-05-11 13:54:26 +01:00
Jelle Meeus
2c771397ca fix(Scripts/Naxxramas): Maexxna more blizzlike web wrap (#18843)
* WIP maexxna web wrap

* add custom summon web wrap

* progress

* save

* something that works

* update sql

* cleanup script

* clean sql

* remove orientation from position

* fix: cast web wrap on multiple targets

* fix: web wraps should not attack

* adjust vertical speed to reduce speed if close, avoid ceiling yeet

* rename candIt to itr

* remove unused wraps2

* style

* use event instead of update(diff)

* update spell_dbc sql

* include player header to fix error: invalid use of incomplete type

* include SpellAuraEffects header

* fix Effects start at 1 in DBC

* fix web wraps attacking

* calc distance with hypotf, define vspeed ranges, remove trig webwrap enum

* fixup! calc distance with hypotf, define vspeed ranges, remove trig webwrap enum

* fix: call target selection with pos 0, use IsPlayer()

* add validate

* fixup! fix: call target selection with pos 0, use IsPlayer()

* remove not needed header

* remove empty lines

* use registry macro

* Revert "remove not needed header"

This reverts commit 254717d27e196a1ec108db5a5e29e37e9e2237a6.
2024-05-11 13:53:29 +01:00
Jelle Meeus
ac203da3d3 fix(Core/Unit): SPELLMOD_RESIST_MISS_CHANCE should decrease miss chance (#18849)
fix: hitchance should decrease misschance
2024-05-11 13:51:17 +01:00
sudlud
cd63cc0bc4 fix(Conf): align LeaveGroupOnLogout default in core with worldserver.conf.dist (#18859) 2024-05-11 14:37:22 +02:00
Jason Mok
d34f64a832 fix(Core/Misc): Correct typo when loading reference loot templates (#18872)
- Fix typo when loading reference loot templates
- Closes #18870

Co-authored-by: Jason Mok <jasonmok@Jasons-MacBook-Air-4.local>
2024-05-09 13:19:28 +02:00
Anton Popovichenko
9815025341 feat(Core/Network): Add Proxy Protocol v2 support. (#18839)
* feat(Core/Network): Add Proxy Protocol v2 support.

* Fix codestyle and build.

* Another codestyle fix.

* One more missing include.
2024-05-04 13:38:32 -03:00
Walter Pagani
715b290cb7 feat(Map): Add open world LOS settings (#18816)
* chore. Add open world LOS settings

* Name change and conditional deny

* modify information in worldserver.conf.dist

* Remove pvp from variables and constants
2024-05-04 12:10:24 -03:00
Jelle Meeus
0dc822d21e fix(Scripts/Magtheridon): Clicking cubes should Banish Magtheridon (#18856)
* init

* rewrite without action

* fix: add Talk(SAY_BANISH)
2024-05-04 11:56:48 -03:00
sudlud
ab7405f94e fix(Core/Map): remove hackfix that blocked update of GOs beeing set active (#18812)
- this just broke the whole purpose of setActive(true) if the
  gameobjects is still not really beeing set active afterwards
- GetGridActivationRange() returns 0.0f for gameobjects anyways
- so CalculateCellArea() will result in the minimal cell area
  around the gameobject's position
- if the cell around the gameobject should not be updated, the
  gameobject should not have been set active in the first place
2024-04-30 06:56:17 -03:00
Knindza
21698031c5 fix(Scripts/Arenas): Updating timer for Shadow Sight spawns (#18748)
* Updating Creature.

* Updating Arenas

* Delete data/sql/updates/pending_db_world/rev_1713104748708628400.sql
2024-04-30 02:09:27 -03:00
天鹿
f203b1b9dc fix(Scripts/PlayerScript): PlayerScript Error (#18806)
Update PlayerScript.cpp
2024-04-29 02:31:14 -03:00
天鹿
81280cd560 refactor(Scripts/Karazhan): 'uint' It can never be less than 0 (#18726)
Update boss_chess_event.cpp
2024-04-27 06:17:38 -03:00
Balleny
7a2f6ff8e5 fix(Core/Battleground): EOTS adjust flag respawn timer (#18759)
adjust flag respawn timer
2024-04-27 06:17:11 -03:00
sudlud
0a376bdc76 fix(Core/GameObject): load guid based scripts correctly (#18811)
- m_goData must be assigned before Create() is beeing called
- otherwise GetScriptId() can't load the correct scriptiD
  in Create()
- all in all this is now more in line with how it's beeing
  done in Creature.cpp
2024-04-26 20:56:46 -03:00
Anton Popovichenko
b90136d80d fix(Core/Pet): Fix pets chasing when pet and target spins uncontrollable (#18798) 2024-04-24 16:25:37 -03:00
Walter Pagani
03f6dde549 fix(Core/SmartAI) fatal error: unused parameter pathId (#18795)
fix. fatal error: unused parameter pathId
2024-04-24 08:22:24 -03:00
Balleny
c4726b2d0b fix(Scripts/TheEye): Update Alar Dive Bomb timings (#18654)
Update Alar Dive Bomb timings
2024-04-23 18:54:45 +02:00
Balleny
f380e8f625 fix(Scripts/TheEye): Update Astromancer timings and add phase (#18655)
* Update Astromancer timings

* Reworked order and timings

* Whitespace removal

* Remove more whitespace

* Update boss_astromancer.cpp

* cleanup .schedule
2024-04-22 13:22:38 +02:00
Balleny
43792db685 fix(Scripts/TheEye): Update Kaelthas Phoenix timers (#18657)
Update Kaelthas Phoenix timers
2024-04-21 21:57:24 +02:00
Jelle Meeus
c738f0d67c fix(Scripts/Hyjal): Cannibalize should heal more than 1 (#18766)
* init

* include SpellScript.h
2024-04-19 22:20:24 -03:00
Gultask
6f154d0a6b feat(Core/SmartAI): Add support for waypoint_data in SAI (#18706)
* Create rev_1712670662273633900.sql

* eol?

* doesn't like a comment at the end, ok, ok

* init

* mack

* Update SmartScript.cpp

* kurzel

* random paths and garg

* Update rev_1712889530436412200.sql

* brend & marge

* Update rev_1712889530436412200.sql

* movement actions

* Update SmartScriptMgr.h
2024-04-18 10:31:41 -03:00
Anton Popovichenko
5386443388 fix(Core/Characters): Fix crash on characters deletion with COD mails. (#18754)
fix(Core/Characters): Fix crash on characters deletion.
2024-04-17 03:53:43 -03:00
Andrew
ef0ebe38d0 fix(Scripts/Pet): Fix crash when spawning lightwell by hand (#18660)
Co-authored-by: Pagani Walter <paganiwalter@gmail.com>
2024-04-17 03:12:20 -03:00
Walter Pagani
eced002ef9 fix(Scripts/Hyjal): fatal error: comparison of integers of different signs (#18755)
* fix. fatal error: comparison of integers of different signs

* Update src/server/scripts/Kalimdor/CavernsOfTime/BattleForMountHyjal/boss_kazrogal.cpp

---------

Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com>
2024-04-14 19:37:02 -03:00
amed80
781190c73b fix(Scripts/Hyjal): fix Mark of Kaz'rogal timer (#18753)
fix Mark of Kaz'rogal timer
2024-04-14 20:10:29 +02:00
Andrew
a8471d0f87 fix(Scripts/Hyjal): Azgalor Doom should not be cast on the MT (#18738) 2024-04-14 08:30:27 -03:00
Andrew
4294525084 fix(Core/Spells): Dive Bomb should not share damage (#18740) 2024-04-14 08:30:16 -03:00
Walter Pagani
564192f881 fix. Prevent character deletion if you have an email (#18743)
* fix. Prevent character deletion if you have an email

* Conditional revert

* change message

* original message
2024-04-14 08:00:50 -03:00