Commit Graph

2949 Commits

Author SHA1 Message Date
avarishd
86ea199867 fix(Script/Core): Move hardcoded text to DB (#11829)
* Remove hardcodes from zones

And minor changes on (Q)  The cleansing

* cs

* codestyle
2022-05-30 04:23:29 -03:00
UltraNix
be877a4e5d fix(Scripts/ZulGurub): Re-implemented Hakkar's Insanity. (#11840)
fix(Scripts/ZulGurub): Fixed Jindo's Brain Wash Totem.

Fixes #11760
2022-05-30 04:20:29 -03:00
UltraNix
a0da7417a0 fix(Core/Units): Clear any movement on charm - vol. 2. (#11897)
* fix(Core/Units): Clear any movement on charm - vol. 2.

Fixes #11880

* Update.
2022-05-30 04:19:53 -03:00
UltraNix
1e79b10b79 fix(Scripts/ZulGurub): Massive Geyser should not attack players. (#11909)
Fixes #11563
2022-05-30 04:18:02 -03:00
Stefano Borzì
6a6418f232 fix: temporary workaround for the googletest issue (#11902)
* fix: temporary googletest issue

* chore: use main branch

* fix: typo

* chore: update reference
2022-05-28 17:12:42 +02:00
Axel Cocat
fbd5e981ca fix(Scripts/Commands): fix baninfo command issues (#11871) 2022-05-27 00:21:43 -03:00
UltraNix
7b4e1ef7d3 fix(Core/Spells): Shadow Weaving should not proc off from DoTs. (#11825) 2022-05-25 05:00:05 -03:00
UltraNix
b66586c1d7 fix(Core/Spells): Fixed players being able to mount with all transfor… (#11767)
…m auras.

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-05-25 04:56:35 -03:00
Hanabi
a6a2ca8ef7 feat(Core/GameObjects): Instance gameobject save data implementation (#11113)
* fix(Core): Save gameobject state on instances

Currently, azerothcore doesn't save gameobject states on instances.
Whenever there's a re-start or crash, the instance's gameobjects and
their states aren't saved, producing un-wanted behaviours and blocking instances at times.

Implemented CRUD for new table `instance_saved_data` that holds the states of gameobjects.

- When worldserver launches and gameobjects are loaded, this will check
  if this object's state exists on the DB and sets the previous state.
- On instance deletion (reset) these states are also removed based on
  the instance ID.
- Whenever a gameobject state changes inside a dungeon or raid, we save
  on the database the set state.

* Select query to synchronous and used FindMap()

* loading gameobject states on create

* reseting instance saved data

* missing reset methods and on create state

* database structure

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/GameObject/GameObject.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Entities/Player/PlayerMisc.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Groups/Group.cpp

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* codestyle

* table changes

* table style

* codestyle

* table changes for columns

* data sanitization

* todo:

- Finish loading db data into the containers
- Using containers to find data
- How to get data from ObjectMGR inside Gameobject?

* loading on start up and db changes

* Removing unused data structure

* Uninitialised integer

* Whitespace

* clean-up and hooks to save states on memory

* Codestyle MySQL deprecated backticks

* i dont understand codefactor

* build

* Update data/sql/updates/pending_db_world/rev_1643395587559675400.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* Update src/server/game/Globals/ObjectMgr.h

Co-authored-by: Kargatum <dowlandtop@yandex.com>

* review changes

* unecessary removal

* pushback instead of emplace

* wrong database update

* Update ObjectMgr.cpp

* missing check

* removing entry from the PR

* missing removals

* last delete

* build

* aha! Found the culprit for the sudden assert errors

* type safety, save only important gameobjects

* static cast to unsigned short

* Update data/sql/updates/pending_db_characters/rev_1643629468629316100.sql

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>

* type changes

* queries fix

* fix build

* enabling which gameobjects to save on the database

* deadmines iron clad door

* Adjustment to gameobject onj create state and instances:

- Gnomeregan doors and Grubbis boss state
- Deadmines missing doors
- Stratholme gameobjects state saved

* forgot emi blastfuse change to despawn

* Leaving group logic

* codestyle

* fixing merge issues

* prevent bad behaviour

* brain meltdown

* Update data/sql/updates/pending_db_characters/rev_1643629468629316100.sql

* Update data/sql/updates/pending_db_world/rev_1649359139539727000.sql

Co-authored-by: Claudiodfc <54484196+claudiodfc@users.noreply.github.com>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
Co-authored-by: Kargatum <dowlandtop@yandex.com>
Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2022-05-24 10:33:45 -03:00
UltraNix
b638d44693 fix(Core/Units): Clear any movement on charm. (#11826)
Fixes #10343
2022-05-23 06:04:27 -03:00
Maelthyr
dfc6adb081 refactor(Core/Combat): DeleteThreatLists() become ClearAllThreat() (#11824)
refactor(Chore/Combat): DeleteThreatLists() become ClearAllThreat()
2022-05-23 05:51:52 -03:00
UltraNix
55720eedd3 fix(Scripts/Spells): Sweeping Strikes - improvements. (#11666)
* fix(Scripts/Spells): Sweeping Strikes - improvements.

Fixes #11594

* Buildfix.
2022-05-23 05:49:56 -03:00
temperrr
b6d79ac89e fix(Script/ZulGurub): Skeletons should appear in pit (#11561) 2022-05-23 05:47:30 -03:00
UltraNix
bcfaf2daad fix(Scripts/Spells): Replenishment should proc off from Vampiric Touc… (#11772)
* fix(Scripts/Spells): Replenishment should proc off from Vampiric Touch even if target died from Mind Blast.

Fixes #8502

* Update.
2022-05-23 05:45:01 -03:00
UltraNix
914ea4f9c3 fix(Core/Items): Properly transfer enchantment durations from old to … (#11828)
fix(Core/Items): Properly transfer enchantment durations from old to newly created/summoned items.

Fixes #11687
2022-05-23 04:27:53 -03:00
UltraNix
99f1cd84e2 fix(Core/Spells): Improvements to Far Sight spell: (#11683)
* fix(Core/Spells): Improvements to Far Sight spell:

Far Sight should not interrupt while casting another spell.
Corrected setting Far Sight object as an active object.
Fixed grid activation range for active dynamic objects.
When Far Sight is over, the camera be reset to player.
Enable swapping camera between Far Sight and Sentry Totem.
Fixes #6368

* Update.

* Update.
2022-05-23 04:26:51 -03:00
UltraNix
0c209dae75 fix(Core): Crashfix. (#11821) 2022-05-23 04:25:55 -03:00
Kargatum
b1c5b44500 feat(Cmake/FindMySQL): add support MariaDB 10.9 (#11835) 2022-05-23 04:04:04 +07:00
Kargatum
464eda37e7 fix(Tools/Vmap): correct build (#11834) 2022-05-23 04:03:48 +07:00
Kitzunu
90fccacad5 feat(Core/Movement): Allow waypoints to use 0 as valid facing value (#11681)
* feat(Core/Movement): Allow waypoints to use 0 as valid facing value

* cherry-pick commit (4747515872)

Co-Authored-By: Ovah <18347559+Ovahlord@users.noreply.github.com>

* Update SmartScriptMgr.h

* a

* Update SmartAI.cpp

* Update SmartAI.cpp

* Update SmartAI.cpp

* typo

* Update SmartAI.cpp

* Update SmartAI.cpp

* Compile fix

* compile #2

* Update WaypointMgr.h

* Update SmartScriptMgr.h

* compile fix again

Co-authored-by: Ovah <18347559+Ovahlord@users.noreply.github.com>
Co-authored-by: MDIC <joshua.lee.betts@gmail.com>
2022-05-21 23:42:41 +02:00
avarishd
1b852b4a0c fix(Script/Quest): A Suitable Disguise - Move zone_dalaran to DB from hardcode (#11813)
Update zone_dalaran.cpp
2022-05-21 23:30:58 +02:00
avarishd
634b2e101c fix(Script/Quest): Conversing With the Depths adjustments & zone_dragonblight move to db from hardcode (#11795)
* Update zone_dragonblight.cpp

* Update zone_dragonblight.cpp
2022-05-21 23:29:28 +02:00
avarishd
fbbb287c29 fix(Script/Ulduar): Mimiron - remove hardcode text and fix Computer broadcast. (#11725)
* Remove hardcode from Mimiron

And fix Computer broadcast text with the sql

* Remove unused ObjectAccessor

* Add plasma blast to creature_text (MK II)

And move all text into 1 enum

* cs
2022-05-21 23:26:35 +02:00
avarishd
75c65ce9b0 fix(Script/Ulduar): Thorim - misc fixes & hardcode removal (#11711)
* Remove unused SAY_SPECIAL from Thorim/Ulduar

Remove duplicates from creature_text for Thorim/Ulduar

* missing ;

* Fix chest rotation & set trigger creature flag to traps

* Change SAY_SPECIAL & start at 6/6 adds

* remove urand from KilledUnit

was there because TYPEID_PLAYER wasn't there, prior to now

* Update SQL comment

* Remove unnecessary GetInstanceScript
2022-05-21 23:25:37 +02:00
IntelligentQuantum
324112ff4f feat(Common/Collision): missing fclose (#11753) 2022-05-19 19:13:06 -03:00
avarishd
d94f8b5970 fix(Script/Ulduar): Freya spawning multiple chests (#11794) 2022-05-19 10:59:48 -03:00
acidmanifesto
76d57065e2 fix (core/logging/conf): Fix Logging for Modules (#11601)
* fix (core/logging/conf): Fix Logging for Modules

Fix custom module logging and appender. Also included Logging Async Conf.

* Update Log.cpp

* Core/Logging: Force synchronous logging after io_service shutdown - fixes logging on worldserver shutdown

https: //github.com/TrinityCore/TrinityCore/commit/c71987b1a1403fa20654cc24b37448ca807ff363
Co-Authored-By: Shauren <shauren.trinity@gmail.com>

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-05-19 09:54:08 -04:00
Maelthyr
c5368816fa Core/Combat: rename getThreatMgr() to GetThreatMgr() (#11758) 2022-05-18 05:36:57 -03:00
UltraNix
8c058791ed fix(Core/Spells): Windfury, Flametongue, Healing Stream, Cleansing … (#11761)
...and Mana Tide totems should be affected by shaman T1 3p bonus.
2022-05-18 05:08:57 -03:00
Charlton Lau
3c9b56438e fix(Core/Spell): Enslaved Demon does not auto-attack/auto-cast (#11677) 2022-05-18 04:59:39 -03:00
UltraNix
6a8180e3fd fix(Core/Spells): The Earthshatterer 8/9 set bonus should be removed … (#11757)
…along with Lightning Shield removal.
2022-05-18 04:50:52 -03:00
IntelligentQuantum
8935f9a869 fix(Core/Scripts): Black Template Area Boundary (#11705)
* .

* feat(Core/Scripts): Black Template Area Boundary

* .
2022-05-17 12:03:40 -03:00
Maelthyr
5ede1177c5 refactor(Core/Combat): implement compatiblity layer for ResetAllThreat() (#11778)
* implement ResetAllThreat()

* .
2022-05-17 12:01:25 -03:00
UltraNix
82ae30d4ed fix(Core/Spells): Priest with Spirit of Redemption should be immediat… (#11771)
fix(Core/Spells): Priest with Spirit of Redemption should be immediately killed when fall into abyss.

Fixes #3777
2022-05-17 10:01:11 -03:00
UltraNix
c6b5700ef5 fix(Core): Crashfix. (#11740) 2022-05-17 06:38:13 +02:00
UltraNix
4675f21867 fix(Core): Crashfix. (#11741) 2022-05-17 06:37:48 +02:00
Malcrom
aab3348e65 Fix(Script/SAI/Misc) Eversong Partygoers (#11786)
* Fix(Script/SAI/Misc) Eversong Partygoers

* Update zone_eversong_woods.cpp
2022-05-16 21:36:21 -03:00
UltraNix
7d3809330b fix(DB/Quest): Fixed quest "Krolmir, Hammer of Storms". (#11742)
Fixes #11728
2022-05-16 12:07:55 -03:00
Skjalf
822aff29e6 fix(Scripts/World): fix nullptr crash (#11770) 2022-05-15 18:28:40 +02:00
IntelligentQuantum
5474b00a3d feat(tools/mmaps): isContinentMap (#11727)
* .

* .
2022-05-14 12:41:34 +02:00
acidmanifesto
e60b953a7a add (core): Additional Helper (#11731)
Anticheat Helper for knock back
2022-05-13 13:16:36 -04:00
acidmanifesto
11f151a962 fix (core): Prevent Forced UpdateObjectVisibility Before in World (#11730)
fix (Core): Prevent Forced UpdateObjectVisibility Before in World

TC Cherry Pick: 38dc5667ba

Co-Authored-By: Shauren <shauren.trinity@gmail.com>
Co-Authored-By: Jurgis <326232+chemicstry@users.noreply.github.com>

Co-authored-by: Shauren <shauren.trinity@gmail.com>
Co-authored-by: Jurgis <326232+chemicstry@users.noreply.github.com>
2022-05-13 13:02:43 -04:00
acidmanifesto
06a62538cf fix (core\crash): fix client crash dk starter (#11726)
* fix (core\crash): fix client crash dk starter

Fixing it again. Something regressed.

* adjust timer and text playing

* improved timing

* Update chapter1.cpp
2022-05-13 13:00:59 -04:00
天鹿
0c0a2eac3b fix (core): Build Fix (#11723)
* Update Spell.cpp
2022-05-12 10:43:07 -04:00
Skjalf
b658ba582e feat(Core/Map): Allow disabling the blizzlike PvP line of sight checks (#11692) 2022-05-11 13:06:56 -03:00
UltraNix
930db5d2ae fix(Core/Spells): Everlasting Affliction should be considered as shad… (#11678)
…ow spell.
2022-05-11 03:26:19 -03:00
UltraNix
203450e949 fix(Scripts/BlackwingLair): Warrior Class Call should not restore to default stance on removal. (#11671) 2022-05-10 22:54:11 -03:00
IntelligentQuantum
981ec9d013 fix(Scripts/Outland): boss_kaelthas (#11701)
* .

* Update boss_kaelthas.cpp
2022-05-10 22:38:27 +02:00
UltraNix
0d4adf5a3e fix(Core/Spells): Blink. (#11663)
* fix(Core/Spells): Blink.

Fixes #6427
Fixes #7571

* Update.
2022-05-10 22:37:53 +02:00
Kitzunu
763a521da8 fix(Core/PacketIO): Stop WorldSession packet processing loop immediat… (#11680)
* fix(Core/PacketIO): Stop WorldSession packet processing loop immediately when AntiDOS kicks/bans the player

* cherry-pick commit (0d0cb23a63)

Co-Authored-By: Shauren <shauren.trinity@gmail.com>

* Update WorldSession.cpp

* Update src/server/game/Server/WorldSession.cpp

Co-authored-by: Shauren <shauren.trinity@gmail.com>
2022-05-10 17:17:07 +02:00