Benjamin Jackson
2a93e7d410
chore(Core/Unit): Correct typo of Controlled. ( #22260 )
2025-06-03 08:56:44 +02:00
Benjamin Jackson
52799d76f6
refactor(Core): Add definition file for area table entries. ( #22054 )
2025-05-09 15:48:02 +02:00
Exitare
98ceb1c067
fix(Core/PlayerScript) Align player script function names ( #21020 )
...
Co-authored-by: sudlud <sudlud@users.noreply.github.com >
2025-02-16 14:59:41 +01:00
Anton Popovichenko
fe2627bc91
fix(Core/Pet): Fix possible crash when using dangling pointer as pets spell target and fix possible memory leak. ( #21420 )
2025-02-12 17:34:30 -03:00
Jelle Meeus
638b8ea621
fix(Scripts/Spells): Death Knight Army of the Dead auras ( #19795 )
2024-12-28 14:23:14 +01:00
Tereneckla
8e080f1e60
fix(Core/Pet): Remove unnecessary Pet Class reassignments ( #20614 )
...
remove unnecessary class assignment
2024-12-01 17:16:13 -03:00
Kitzunu
386aea03ee
chore(Core/Misc): Some cleanup ( #19970 )
...
* remove weird blanks
* update if
* ) ) to ))
* missed some ) )
* now switch
* .
2024-09-21 19:34:31 +02:00
Benjamin Jackson
1edac37ac3
refactor(Core): Make more use of helpers. ( #19835 )
...
* Init.
* Reword.
* Update codestyle script.
Co-Authored-By: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Add gameobject type ID check, reorder checks.
* Add helper/codestyle check for unit type.
* `IsUnit()` -> `IsCreature()`
* Add `IsUnit()` method.
* Use type mask.
https: //github.com/TrinityCore/TrinityCore/commit/cc71da35b5dc74abf71f8691161525a23d870bb5
Co-Authored-By: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* Replace instances of `isType` with `IsUnit`.
---------
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com >
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-09-03 14:41:31 -03:00
Grimdhex
643362d697
refactor(Core/Object): adds consistency in the use of type object check ( #19671 )
2024-08-25 09:57:37 -03:00
Saqra1
087acc58bf
fix(Core/PetHandler): Allow PetAI to handle flags ( #19446 )
...
When a pet ability was cast, PetHandler reset all CharmInfo flags before
calling PetAI methods, setting the attack flag to true every time.
This commands the pet to go and chase the target which is not correct
when the state is COMMAND_STAY.
PetAI already handles the scenario, it just wasn't getting the actual
pet attack state.
2024-08-19 13:15:39 -03:00
Grimdhex
9dc20bc261
fix(Core/Entities): crash fix cause by a pointer change in #19622 ( #19633 )
...
* fix(Core/Entities): crash fix cause by a pointer change in #19622
* fix blank space for codestyle check
2024-08-15 16:28:50 -03:00
Grimdhex
7457aef78d
refactor(Core/Entities): Cleanup Unit header file ( #19622 )
...
* move several enum definitions in a new files
* move more things
* remove the include comment
* move the related code to CharmInfo in this own file
*original idea of Ovahlord
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix clang build errors and few blank lines
* missing forward declaration
* new tentative to fix gcc/clang build
* add several include could be necessary for gcc/clang compilation
* .
* revert some include since the last AC update
* fix some loop inconsistencies
* align all enums in UnitDefine.h
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2024-08-15 05:12:44 -03:00
Saqra1
a950a7f44e
fix(Core/Pets): Add option to revive pets with full mana ( #19383 )
...
* fix(Scripts/Spells): Revive pets with full mana in bgs
* Pets were incorrectly revived without restoring its mana
* Closes #15894
* ready for merge
---------
Co-authored-by: Saqra1 <>
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-07-17 12:38:10 +02:00
Jelle Meeus
ee4d728573
fix(Core/Pets): Correct Pet size for pets 3 ( #19319 )
...
* revert
* override maxScale for some families
add more families
sort
* add turtle
2024-07-09 14:16:30 -03:00
Jelle Meeus
37431cd7a6
fix(Core/Pets): Correct Pet size for bigger pets 2 ( #18867 )
...
* scale displayInfo, cap scale to maxScale
* prevent scaling with displayInfo if scale is already increasing the size
2024-07-04 16:34:14 -03:00
Jelle Meeus
cf1185551d
fix(Core/Pet): prevent LoadPetFromDB to trigger a fake summon spell cast in most cases ( #19277 )
...
* add CategoryRecoveryTime check
* add RecoveryTime check
2024-07-04 14:20:24 -03:00
Benjamin Jackson
d6d49a9e45
refactor(Core/ObjectMgr): Implement display probabilities. ( #19068 )
...
* Init.
Cherry-picked from TC commits 9d210476e5 and c488fb219a
Co-Authored-By: Traesh <9392905+traesh@users.noreply.github.com >
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* Add brute data.
Needs validation against what existed before, i.e. Classic change prevention.
* Add validation info for brute data.
* Remove incomplete data queries.
* Requested changes.
* Whitespace.
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Requested change.
Table name.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Resolve the funny merge conflicts.
I wonder why git blame doesn't work on a file with 20k lines in it that's odd huh champ.
* Remove unused parameter.
* Remove uses of unused parameter.
* Use unused parameter.
Hopefully?
* I will cry.
* Sobbing endlessly.
* Remove comment.
* Adjust table structure query.
Remove length parameters and allow null for build value.
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
* Adjust column datatype and add check constraint.
---------
Co-authored-by: Traesh <9392905+traesh@users.noreply.github.com >
Co-authored-by: Shauren <shauren.trinity@gmail.com >
Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com >
2024-06-16 18:12:16 +02:00
Jelle Meeus
f846d79478
fix(Core/Pet): Warlock pet handling ( #19054 )
...
* dismiss summoned non-hunter pets by removing them
* store createdbyspellid
* Revert "dismiss summoned non-hunter pets by removing them"
This reverts commit eb539e841d882a6c90f743792c91304b0d365a5c.
2024-06-13 10:31:35 -03:00
Nathan Handley
df33a57b78
feat(Core/Unit): New helper IsClass and script hook OnPlayerIsClass ( #18243 )
...
* Class Comparison Logic Encapsulation - Parity
* Add Context to IsClass
* Add Unit IsClass script hook
* Replace additional getClass with IsClass
* Update CanUseItem to replace getClass with IsClass
* Add separate context for pet vs ability
* Change Create to Init since not all referenced contexts are creation
* Align spacing in ClassContext
* Drop context on LFGManager max power
* Update IsClass context that wraps around Missle Barrage
* Rename context for swapping weapons
* Be more specific than CLASS_CONTEXT_TALENT
* Remove duplicate context
* Moved IsClass Hook to Player
* Removed unused parameter in virtual base function
* Added maybe_unused to IsClass virtual in order to compile
To match the override signature, the virtual base needs to include the parameter in question, so using [maybe_unused] to signal to the compiler to allow it
* Remove extra blank line
* Add ABILITY_REACTIVE context
* Add context for PET_CHARM
* Remove explicit nullopt check per review
* Code Readability - Change if to if else in pet
Due to the return pattern, this doesn't change functionality in any way
* Add OnPlayer to disambiguate
---------
Co-authored-by: NathanHandley <nathanhandley@protonmail.com >
2024-02-10 12:25:00 -03:00
Andrew
f9f71fff36
fix(Core/Player): Check if the player can summon the warlock pet on B… ( #18064 )
...
fix(Core/Player): Check if the player can summon the warlock pet on BG ress
2024-01-01 14:56:32 +01:00
Winfidonarleyan
eb1ecc38a5
feat(Core/Scripting): move all script objects to separated files ( #17860 )
...
* feat(Core/Scripts): move all script objects to separated files
* Apply 5bfeabde81
* try gcc build
* again
2023-12-02 21:13:20 +01:00
Kitzunu
5bfeabde81
chore(Core/Misc): rename spellInfo pointers ( #17914 )
...
* Rename all
2023-12-02 06:03:15 -03:00
forgives
ca7eb956aa
feature(Core/Pet): Add pet talent rate config ( #17678 )
...
* feat: add pet talent rate config
* feat(Core/Pet): keep consistent with player talent config
* refactor(Core/Pet): delete empty line
2023-11-12 09:33:06 +01:00
Kitzunu
f757e93da5
refactor(Core/Misc): Make DeathState enum class ( #17607 )
2023-10-28 10:54:03 +02:00
Skjalf
c7b7b7dc07
fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet ( #17342 )
...
* fix(Scripts/Spells): Fix Glyph of Voidwalker applying to every pet
* Update src/server/game/Entities/Pet/Pet.cpp
2023-09-25 08:07:09 -03:00
Francesco Borzì
5d01b700fd
refactor(Core): remove unused imports ( #17094 )
2023-08-28 13:39:43 +02:00
Tereneckla
cf87a2d8fe
fix(Core/Pet): Correct (most) warlock pet scaling ( #16769 )
...
* create
* Update Pet.cpp
* remove unwanted change
* Update data/sql/updates/pending_db_world/rev_1689522771491547000.sql
* Update rev_1689522771491547000.sql
2023-08-20 21:38:49 -03:00
Anton Popovichenko
f6b77f9d64
fix(Core/Pets): Fix crash when pet tries to attack deleted object ( #17034 )
...
This situation occurs when, during a fight, a pet receives a command to apply a positive spell to an ally and then resume attacking its previous target.
2023-08-19 22:27:51 +02:00
Kitzunu
026fe7c962
fix(Core/Pets): Hunter pet scaling ( #16959 )
...
* fix(Core/Pets): Hunter pet scaling
* Fix pet scaling to properly take DBC data
* Edge case for Devilsaur where the DBC data is whack, therefore we use Spirit Beast data instead
* updated scale calculation based on client function (f09564b9d0 )
Co-Authored-By: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
* fix gcc
---------
Co-authored-by: Ovahlord <18347559+Ovahlord@users.noreply.github.com >
2023-08-08 19:11:41 -03:00
Webdrian
226408329a
fix(Core/Pets): Corret Pet size for normal and exotics & bigger pets ( #16910 )
...
* fix(Core/Pet)
Pet size fixed
* Update Pet.cpp
* Update Pet.cpp
2023-08-06 02:08:34 +02:00
AiurJordan
f0a4612964
fix(Core/Pets) Pet scaling only being applied to pets with DB Entry ( #16401 )
2023-08-02 14:51:11 -03:00
Angelo Venturini
30f475829a
fix(Core/Spells): Hunter snake trap damage ( #16326 )
2023-05-23 22:39:55 -03:00
Axel Cocat
d028a6253a
fix(Core/Pet): fix Pet::resetTalentsForAllPetsOf for stabled pets ( #15779 )
2023-04-02 14:48:03 +02:00
UltraNix
ac0581bd43
fix(Core/Pet): Fixed set hunter pet's speed on load. ( #15206 )
2023-03-04 17:41:10 -03:00
Kitzunu
f039836a2f
chore(Core/Misc): Change all TODO to doxygen comment ( #14966 )
2023-02-12 10:05:34 -03:00
UltraNix
da70db415b
fix(Core/Config): Added new config to make pet's health be modified b… ( #14051 )
2023-02-11 00:08:28 -03:00
Kitzunu
ed2997ab10
fix(Core/Creature): Check model increase only for Exotic creatures ( #14526 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14525
2023-01-07 20:36:39 +01:00
Kitzunu
8d2dda24ed
fix(Core/Pets): Correct Pet size for bigger pets ( #14511 )
...
* closes https://github.com/azerothcore/azerothcore-wotlk/issues/14488
2023-01-06 03:23:21 +01:00
Angelo Venturini
9e18b86311
fix(Core/Auras): SPELL_AURA_MOD_SCALE should scale additively instead… ( #14425 )
...
...multiplicatively
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2023-01-02 20:43:20 -03:00
Kitzunu
4870b14b1f
refactor(Core/Object): getLevel() -> GetLevel() ( #14122 )
...
* refactor(Core/Object): getLevel() -> GetLevel()
* fix build and sneak some doxygen in
* codeSTLE
* codestyle
2022-12-31 17:39:23 +01:00
UltraNix
79bef9a057
fix(Core/Pets): Save all spell cooldowns to db. ( #13809 )
...
Fixes #13539
2022-11-16 01:26:46 -03:00
UltraNix
670d5724cb
fix(Core/Pets): Tamed hunter pets should deal physical damage. ( #13522 )
...
Fixes #13497
2022-10-29 07:14:07 -03:00
UltraNix
1b0d76e6d2
fix(Core/Spells): Fixed applying Command aura to shaman Feral Spirits. ( #13000 )
2022-09-13 21:35:00 -03:00
Maelthyr
d0d1671745
feat(Core/Debug): GetDebugInfo implementation ( #12705 )
...
Cherry-pick: 9a924fb9d5
Co-authored-by: jackpoz <giacomopoz@gmail.com >
Co-authored-by: jackpoz <giacomopoz@gmail.com >
2022-08-15 09:43:41 -03:00
UltraNix
b81a14976c
fix(Scripts/Spells): Glyph of Felguard. ( #12497 )
...
* fix(Scripts/Spells): Glyph of Felguard.
Fixes #12432
* Update.
2022-07-24 13:38:03 -03:00
Maelthyr
2c7b274bc5
refactor(Core): Improve struct alignment and codestyle ( #12335 )
...
refactor(Core): improve struct alignment and codestyle
2022-07-10 14:19:11 -04:00
UltraNix
255c5d8b72
fix(Core): Crashfix. ( #11903 )
...
* fix(Core): Crashfix.
Fixes #11650
* Update.
2022-06-26 04:50:22 -03:00
UltraNix
d6c95b4db8
fix(Core/Pets): Handle health-aurastates on pet loading. ( #11491 )
...
Fixes #11481
2022-04-23 11:32:46 -03:00
Kitzunu
edb7cac19b
feat(Core/Unit): NPCFlags helpers ( #11286 )
...
* cherry-pick commit (TrinityCore/TrinityCore@d611925 )
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
2022-04-05 13:52:42 +02:00
Kitzunu
535c7451a2
feat(Core/Unit): New helpers for DynamicFlags ( #11230 )
...
* feat(Core/Unit): New helpers for DynamicFlags
* cherry-pick commit (d611925dc7 )
Co-Authored-By: Shauren <shauren.trinity@gmail.com >
* oopsie
Co-authored-by: Shauren <shauren.trinity@gmail.com >
2022-04-01 07:14:29 -03:00