* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
* NULL to nullptr
Co-authored-by: Francesco Borzì <borzifrancesco@gmail.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
PlayerScript#OnFirstLogin was broken in that if you tried to teach the
player a spell or give an item to him that change wouldn't persist.
Meaning that the next time the Player would log in, his awarded spells
or items would be gone.
Meanwhile PlayerScript#OnLogin didn't have this behavior meaning
that the sematics of PlayerScript#OnFirstLogin and PlayerScript#OnLogin
where very different, which is unexpected.
This issue was caused by an implementation detail in Player#learnSpell
(and similiar) which behaves differently depending on
Player#isBeingLoaded phase. This code change makes its that
PlayerOnFirstLogin hook executes when Player#isBeingLoaded == false
fixing the issue.
Alternatives: The fact that Player#learnSpells and others behave
differently depending on the load phase is questionable and from my
research it seems like this impl detail is only used when giving the
player his template spells. We could add a overload to
Player#learnSpell with a flag like `isSpellTemporary` and make
the template spells loading use it. Then we would be able to remove
this implicit temporary spell mechanism when Player#isBeingLoaded
thing. However this is a deeper change and not worth the risk.
* azerothcore + eluna done.
* Remove the Eluna single thread limit.
* Read Eluna Settings file.
* submodule change.
* fix(test) Ubuntu - Cant Link Library after Compile
* The ELUNA is disabled by default.
* remove submodule luaEngine.
* some change
* fix a error
* change cmake
* fix: some onplayerchat does not have hooks.
* Eluna: Add BG event Hooks.
* fix:cmake hook AFTER_LOAD_CONF not work.
* Remove the eluna switch.
* Remove some define in the core.
* fix conf file not read in the linux.
* eluna : change bg hook parameter type
* Remove TC log function call
* change bg hook OnBGEnd parameter type.
Note: to enable Eluna, the module is required
