Commit Graph

4589 Commits

Author SHA1 Message Date
Skjalf
8d08a861aa feat(Core/Scripting): Implement OnAllowedToLootContainerCheck() hook (#17209)
* chore(Core/Loot): Move OnAllowedForPlayerLootCheck() hook call up

* Revert "chore(Core/Loot): Move OnAllowedForPlayerLootCheck() hook call up"

This reverts commit f841ef9da313976179fb788d9573ff8ced05ecb9.

* feat(Core/Scripting): Implement OnAllowedToLootContainerCheck() hook

* Update GlobalScript.cpp
2023-09-08 01:52:02 -03:00
Dan
76d1d02dce fix(Scripts/Magtheridon): add correct way to reset threat list (#17198)
* test

* fix but check

* fix?
2023-09-06 18:33:34 +02:00
Christopher Galbraith
4147418a7a refactor(Scripts/TheEye): Refactor Void Reaver boss script to new scheduler (#17044)
* WiP draft of void reaver refactor

* linting

* remove UpdateAI override

* add delay after pounding

* separate arcane_orb into group to delay

* clang fix

* removed unused context param

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-09-05 13:16:31 -03:00
Dan
189818e781 fix(Scripts/Ulduar): update Winter Jormungar and Snow Mound creature script (#17054)
* initial

* add auras

* spacing
2023-09-05 06:39:44 -03:00
Eddy Vega
056b28ea21 fix(Scripts/Magtheridon): Remove ThreatList before release (#17128)
init
2023-09-05 06:37:04 -03:00
Anton Popovichenko
52d07bbfae fix(Core/InstanceMap): Stop using deleted player in RemovePlayerFromMap (#17069) 2023-09-05 06:36:34 -03:00
Kitzunu
1ed1cd0c73 fix(Core/Player): Allow to swap bags when they are filled (#17086) 2023-09-05 06:35:15 -03:00
Dan
dd647da913 fix(Scripts/MagtheridonsLair): make it so no attack is being done during Quake and fix p1 cheese tactic (#17136)
* initial

- adds condition for taunt speech
- makes it so no attack happens whatsoever during quake

* fix p1 channeler skip bug

* initialise channelers

* doforallminions

* thisiswhathappenswhenyoucodeinbrowser

* Update src/server/scripts/Outland/HellfireCitadel/MagtheridonsLair/boss_magtheridon.cpp

---------

Co-authored-by: Skjalf <47818697+Nyeriah@users.noreply.github.com>
2023-09-04 21:20:09 -03:00
Skjalf
0c90bfcf70 fix(Scripts/Karazhan): Remove redundant Garrote cast and despawn gues… (#17152)
fix(Scripts/Karazhan): Remove redundant Garrote cast and despawn guests on evade
2023-09-04 21:15:18 -03:00
Skjalf
cdc06e1703 fix(Scripts/Karazhan): Remove hacked knockback effect from Aran Flame… (#17174)
fix(Scripts/Karazhan): Remove hacked knockback effect from Aran Flame Wreath
2023-09-04 21:15:03 -03:00
Skjalf
5abfbdff42 fix(Scripts/Karazhan): Fix Nightbane health phase percentages (#17173)
* fix(Scripts/Karazhan): Fix Nightbane health phase percentages

* Update boss_nightbane.cpp
2023-09-04 21:11:58 -03:00
Dan
cacb32f423 fix(Scripts/Karazhan): change to right gossip menu for Barnes (#17151)
* initial

* make sense of ids
2023-09-03 09:44:43 -03:00
Dan
4886dac963 fix(Scripts/Karazhan): make it so door closes when Big Bad Wolf is engaged in Little Red Riding Hood in the Opera (#17172)
* initial

* not a boolean
2023-09-03 09:44:13 -03:00
Skjalf
4ce43d3f1f fix(Scripts/Karazhan): Maiden of Virtue repentance should have a cast… (#17153)
fix(Scripts/Karazhan): Maiden of Virtue repentance should have a cast time
2023-09-03 09:43:16 -03:00
Dan
6ff5f3811e fix(Scripts/Karazhan): fix gossip from the Grandmother in the Big Bad Wolf fight (#17155)
* initial

* switch is better

* add correct menu ids cmangos cherrypick

...

Co-authored-by:  <7995382+killerwife@users.noreply.github.com>

* remove sql
2023-09-02 18:51:28 -03:00
Kitzunu
280822cb83 chore(Deps/Misc): Print an EOL Deprecation warning for MySQL 5.7 and … (#17101)
chore(Deps/Misc): Print an EOL Deprecation warning for MySQL 5.7 and OpenSSL 1.1
2023-08-29 00:24:41 +02:00
Kitzunu
5c0a051fd5 fix(Core/Crypto): fix crash (#17100) 2023-08-28 19:15:22 +02:00
Francesco Borzì
5d01b700fd refactor(Core): remove unused imports (#17094) 2023-08-28 13:39:43 +02:00
Francesco Borzì
eaa6487fc2 refactor(Scripts): remove unused imports (#17097) 2023-08-27 22:25:22 -03:00
Dan
3ce2627c05 fix(Scripts/Karazhan): allow Moroes and adds to reset when an add is pulled out of the room (#17072)
* initial

* doforallsummons

* error fix
2023-08-27 16:08:34 -03:00
Kitzunu
3eb2463c69 chore(Core/Misc): Correct some fmt outputs (#17091) 2023-08-27 06:23:26 +02:00
Christopher Galbraith
aea540181b fix(Spell): set torment of the worgen to have 3% proc chance (#17005)
Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-08-26 17:35:56 +02:00
pvp100
856d17ac36 fix(Core/MiscHandler): Dungeon requirements Message (#16701)
* fix(DB/Gameobject): fix towercanno error location in Flamewatch Tower

adjusted wintergrasp towercanno position

* fix(Core/MiscHandler): dungeon access requirements message parameter

requirements level variable always 0
requirements item cannot get from locale

Co-authored-by: aviar <aviar@sina.com>

* revert: random edits

---------

Co-authored-by: aviar <aviar@sina.com>
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
2023-08-25 09:16:47 -03:00
Anton Popovichenko
f4658a1df2 fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries. (#17070)
* fix(Core/Scripts): Fix scripts where LoadObjectData can leave arrays boundaries.

* Fix build
2023-08-25 09:15:07 -03:00
Synful-Syn
6b583089f3 fix(Core/Spell): Stop Blink from the falling player to move upward by 1y and stop moving backward when facing a wall (#16657)
* blink-bad-warps

* Change formatting of an if
2023-08-25 09:14:27 -03:00
Dan
2aee8bb1c3 fix(Scripts/Karazhan): allow sequence of releases to continue even if Dorothee dies early (#17077)
* initial
initial

Co-authored-by: danqu <3050620+danqu@users.noreply.github.com>

* some changes because reset dun work

* oops

* fixes hopefully

* debug

* more debug

* bruh

* cleanup

---------

Co-authored-by: danqu <3050620+danqu@users.noreply.github.com>
2023-08-25 09:06:30 -03:00
Christopher Galbraith
cee630774c fix(Core/Spells): Add SPELL_ATTR7_DONT_CAUSE_SPELL_PUSHBACK to Hand of Sac and Divine Sac spells (#17041)
* add no spell pushback flag to auras

* Revert "add no spell pushback flag to auras"

This reverts commit 545e9fe4ee69bb079b69a4f2ba6039b834568a59.

* spellInfoCorrection for no pushback on HoS and Divine Sac

---------

Co-authored-by: ChrisCGalbraith <chriscgalbraith@gmai.com>
2023-08-25 09:02:27 -03:00
podmepodme
820eac083c fix(Scripts/Orgrimmar): replace hardcoded gossips in zone_orgrimmar (#16947)
* fix(CORE/Creature): replace hardcoded gossips in zone_orgrimmar

Closes AzerothCore issue #4179

* fix(CORE): Codestyle

* refactor(CORE/Character): Switch statement for thrall dialog

* fix(CORE): Codestyle
2023-08-25 08:52:51 -03:00
The GhostRider
b1c8b0eaa2 fix(Core/Item): Complimentary Brewfest Sampler (#16992)
* Fix(DB/C++):Item - Complimentary Brewfest Sampler

* Delete PlayerStorage.cpp

* Update rev_1691843684176706600.sql

Correction

* Ripristino il file PlayerStorage.cpp

* New file: SpellInfoCorrections.cpp

* Update rev_1691843684176706600.sql
2023-08-25 08:45:06 -03:00
Dan
d63aba78bd refactor(Scripts/SSC): modernise Morogrim Tidewalker with BossAI (#17028)
* fix ohf

* revert

* initial

* make bench happy

* make bench happier
2023-08-25 08:40:41 -03:00
Anton Popovichenko
4c287e2873 fix(Core/Vehicles): Fix crash in Vehicle::AddPassenger (#17038)
* fix(Crash): Fix crash in Vehicle::AddPassenger

As I understand it, a try-catch block cannot intercept the ABORT function. Therefore, let's use a simple if statement instead.

* Address code review feedback
2023-08-22 12:13:36 +02:00
Gultask
e42f43784c feat(Core/SmartAI): Implement SMART_ACTION_FOLLOW_GROUP (#17033)
* Update SmartScript.cpp

* INIT

* add as coauthor as well :)

Co-Authored-By: cyberium <346907+cyberium@users.noreply.github.com>

* codestyle

* test?

---------

Co-authored-by: cyberium <346907+cyberium@users.noreply.github.com>
2023-08-22 12:11:21 +02:00
Kitzunu
12456b5496 refactor(Misc/Conf): DBErrors is now Errors (#17053)
* refactor(Misc/Conf): DBErrors is now StartupErrors

* pt2

* Update ci-error-check.sh

* Update ci-error-check.sh
2023-08-22 12:08:53 +02:00
Skjalf
f24fb95575 fix(Scripts/Arcatraz): Fix not being able to try Skyriss a second time after wipes (#17018)
* fix(Scripts/Arcatraz): Revive Warden Mellichar on wipes at Skyriss

* Update boss_harbinger_skyriss.cpp
2023-08-22 00:12:49 -03:00
Walter Pagani
957ccdb845 fix(Script/Spells): Book of Fel Names (#17051) 2023-08-21 21:15:00 +02:00
Tereneckla
cf87a2d8fe fix(Core/Pet): Correct (most) warlock pet scaling (#16769)
* create

* Update Pet.cpp

* remove unwanted change

* Update data/sql/updates/pending_db_world/rev_1689522771491547000.sql

* Update rev_1689522771491547000.sql
2023-08-20 21:38:49 -03:00
Skjalf
80a8f6d47a fix(Scripts/OHF): Don't update the escort steps when Drake dies (#17024)
* fix(Scripts/OHF): Don't update the escort steps when Drake dies

* update gossip req

* Update rev_1692233536025387200.sql
2023-08-20 15:46:39 -03:00
Kitzunu
6185b1d73b fix(Core/Events): Implement Spirit of Competition event (#16963)
* fix(Core/Events): Implement Spirit of Competition event

Co-Authored-By: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* more stuff

* bye bye magic numbers

* fix dberrors

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

Co-Authored-By: Anton Popovichenko <walkline.ua@gmail.com>

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update Battleground.cpp

* Update rev_1691529514989936100.sql

* commoneers

* Update src/server/game/Battlegrounds/Battleground.cpp

Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>

* ci

* Update rev_1691529514989936100.sql

* unnecessary whitespace

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update src/server/game/Battlegrounds/Battleground.cpp

* Update Battleground.cpp

---------

Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Co-authored-by: Anton Popovichenko <walkline.ua@gmail.com>
2023-08-20 00:41:44 +02:00
Anton Popovichenko
1a1a320ea1 fix(Scripts/Dragonblight): Fix crash from Wintergarde Gryphon. (#17032)
fix(Vehicle): Fix crash on ExitVehicle from Wintergarde Gryphon.
2023-08-19 22:30:39 +02:00
Anton Popovichenko
f6b77f9d64 fix(Core/Pets): Fix crash when pet tries to attack deleted object (#17034)
This situation occurs when, during a fight, a pet receives a command to apply a positive spell to an ally and then resume attacking its previous target.
2023-08-19 22:27:51 +02:00
Grimgravy
edc92b4282 fix(Scripts/Quest): Improved Varedis Must Be Stopped (#16799)
* fix(Scripts/Quest): Varedis Must Be Stopped

* Update spell_quest.cpp

* Update data/sql/updates/pending_db_world/rev_1689813586760998100.sql

---------

Co-authored-by: Kitzunu <24550914+Kitzunu@users.noreply.github.com>
2023-08-19 22:13:56 +02:00
Mike Delago
cf30d534f1 fix(Tools/DBImport): Add Env var support to DBimport tool (#17019)
add env var support for dbimport
2023-08-19 18:52:12 +02:00
Anton Popovichenko
57e0b496bd fix(Core/Transport): Fixes crash with loading player on deleted transport (#17021)
* fix(Crash): Fixes crash with loading player on deleted transport

* Remove whitespace
2023-08-18 16:13:43 +02:00
Kitzunu
4f015d0967 refactor(Deps/MySQL): Tidy up FindMySQL for windows (#16948) 2023-08-14 23:39:03 +02:00
Kitzunu
39ec7464ef fix(build): macOS (#17007)
* fix(build): macOS

* Revert "fix(build): macOS"

This reverts commit 612c41e41b2aea55069c0cfaf751c3ba7205e52f.

* Update Config.cpp
2023-08-14 23:38:30 +02:00
Anton Popovichenko
d69ee90ed3 feat(Core/Config): Implement config override with env vars (#16817)
* Core/Config: Implement config override with env vars

Implement overriding of configuration from the .conf file with environment variables.
Environment variables keys are autogenerated based on the keys defined in .conf file.

Usage example:

$ export TC_DATA_DIR=/usr
$ AC_WORLD_SERVER_PORT=8080 ./worldserver

* Add tests for env vars config
2023-08-14 22:07:43 +02:00
Dan
8621118b83 fix(Scripts/OHF): Fix not being able to start the escort if you already killed Lt. Drake (#17006) 2023-08-14 13:05:20 -03:00
Skjalf
49c2eabea1 fix(Scripts/Karazhan): Fix Servant Quarters rares not spawning (#17001)
* fix(Scripts/Karazhan): Fix Servant Quarters rares not spawning

* Update rev_1691944209332122100.sql
2023-08-13 13:51:43 -03:00
Skjalf
8dc8424f09 fix(Scripts/OHF): Killing Drake should not be required to start Thral… (#17000)
fix(Scripts/OHF): Killing Drake should not be required to start Thrall's escort
2023-08-13 13:39:08 -03:00
Gultask
8d803334eb feat(Core/SmartAI): Add new event parameter, event_param6 (#16944)
* init

* pt2

* this template stuff must go

* also for my other event
2023-08-12 14:53:15 -03:00