From fd2fcc127599cf2a26c35ddb106eb3d8802db05e Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Fri, 17 Mar 2023 10:24:15 +0100 Subject: [PATCH] fix(Core/Achievements): Add log for missing achievement (#15425) * fix(Core/Achievements): Add log for missing achievement * cherry-pick commit (https://github.com/TrinityCore/TrinityCore/commit/af5bd270c3b6628b126e0fde8aa2069a552484bd) Co-authored-by: Shauren --- src/server/game/Achievements/AchievementMgr.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/server/game/Achievements/AchievementMgr.cpp b/src/server/game/Achievements/AchievementMgr.cpp index 3c3061058..4b2e18d08 100644 --- a/src/server/game/Achievements/AchievementMgr.cpp +++ b/src/server/game/Achievements/AchievementMgr.cpp @@ -2481,6 +2481,12 @@ void AchievementGlobalMgr::LoadAchievementCriteriaList() if (!criteria) continue; + if (!GetAchievement(criteria->referredAchievement)) + { + LOG_DEBUG("server.loading", "Achievement {} referenced by criteria {} doesn't exist, criteria not loaded.", criteria->referredAchievement, criteria->ID); + continue; + } + _achievementCriteriasByType[criteria->requiredType].push_back(criteria); _achievementCriteriaListByAchievement[criteria->referredAchievement].push_back(criteria);