From ecf85a2f3e5b84b46c749abfd4e9f861c09ce435 Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Fri, 15 Sep 2023 02:32:36 +0200 Subject: [PATCH] =?UTF-8?q?chore(Core/Misc):=20Silence=20compile=20warning?= =?UTF-8?q?=20in=20boost::process=20with=20vers=E2=80=A6=20(#17251)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit chore(Core/Misc): Silence compile warning in boost::process with version 1.83 * Cherry-pick commit https://github.com/TrinityCore/TrinityCore/commit/d8c98579d4a2c4191e42c2542901274ffe53083c Co-authored-by: Shauren --- src/common/Utilities/StartProcess.cpp | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/common/Utilities/StartProcess.cpp b/src/common/Utilities/StartProcess.cpp index 7fbe053a8..a8b35578b 100644 --- a/src/common/Utilities/StartProcess.cpp +++ b/src/common/Utilities/StartProcess.cpp @@ -72,8 +72,22 @@ namespace Acore std::string const& logger, std::string const& input, bool secure) { +#if AC_COMPILER == AC_COMPILER_MICROSOFT +#pragma warning(push) +#pragma warning(disable:4297) +/* + Silence warning with boost 1.83 + boost/process/pipe.hpp(132,5): warning C4297: 'boost::process::basic_pipebuf>::~basic_pipebuf': function assumed not to throw an exception but does + boost/process/pipe.hpp(132,5): message : destructor or deallocator has a (possibly implicit) non-throwing exception specification + boost/process/pipe.hpp(124,6): message : while compiling class template member function 'boost::process::basic_pipebuf>::~basic_pipebuf(void)' + boost/process/pipe.hpp(304,42): message : see reference to class template instantiation 'boost::process::basic_pipebuf>' being compiled +*/ +#endif ipstream outStream; ipstream errStream; +#if AC_COMPILER == AC_COMPILER_MICROSOFT +#pragma warning(pop) +#endif if (!secure) {