feat(CI/Codestyle): added codestyle check (#3668)

This commit is contained in:
Kargatum
2021-01-09 17:59:50 +07:00
committed by GitHub
parent 57aa46244d
commit ea93a5c1a1
400 changed files with 238 additions and 748 deletions

View File

@@ -6328,7 +6328,6 @@ void AuraEffect::HandlePeriodicHealthLeechAuraTick(Unit* target, Unit* caster) c
if (caster)
caster->SendSpellNonMeleeDamageLog(target, GetId(), damage + absorb + resist, GetSpellInfo()->GetSchoolMask(), absorb, resist, false, 0, crit);
int32 new_damage;
new_damage = Unit::DealDamage(caster, target, damage, &cleanDamage, DOT, GetSpellInfo()->GetSchoolMask(), GetSpellInfo(), false);
@@ -6824,7 +6823,6 @@ void AuraEffect::HandleRaidProcFromChargeAuraProc(AuraApplication* aurApp, ProcE
target->CastSpell(target, triggerSpellId, true, NULL, this, GetCasterGUID());
}
void AuraEffect::HandleRaidProcFromChargeWithValueAuraProc(AuraApplication* aurApp, ProcEventInfo& /*eventInfo*/)
{
Unit* target = aurApp->GetTarget();

View File

@@ -116,7 +116,6 @@ private:
// xinef: channel information for channel triggering
ChannelTargetData* m_channelData;
SpellModifier* m_spellmod;
int32 m_periodicTimer;

View File

@@ -2758,4 +2758,3 @@ void DynObjAura::FillTargetMap(std::map<Unit*, uint8>& targets, Unit* /*caster*/
}
}
}

View File

@@ -263,7 +263,6 @@ GameObject* SpellCastTargets::GetGOTarget() const
return nullptr;
}
void SpellCastTargets::SetGOTarget(GameObject* target)
{
if (!target)
@@ -1817,7 +1816,6 @@ void Spell::SelectImplicitTrajTargets(SpellEffIndex effIndex, SpellImplicitTarge
float srcToDestDelta = m_targets.GetDstPos()->m_positionZ - m_targets.GetSrcPos()->m_positionZ;
// xinef: supply correct target type, DEST_DEST and similar are ALWAYS undefined
// xinef: correct target is stored in TRIGGERED SPELL, however as far as i noticed, all checks are ENTRY, ENEMY
std::list<WorldObject*> targets;
@@ -3407,7 +3405,6 @@ SpellCastResult Spell::prepare(SpellCastTargets const* targets, AuraEffect const
return SPELL_FAILED_SPELL_IN_PROGRESS;
}
LoadScripts();
OnSpellLaunch();
@@ -5356,7 +5353,6 @@ SpellCastResult Spell::CheckCast(bool strict)
return SPELL_FAILED_NOT_READY;
}
if (m_spellInfo->HasAttribute(SPELL_ATTR7_IS_CHEAT_SPELL) && !m_caster->HasFlag(UNIT_FIELD_FLAGS_2, UNIT_FLAG2_ALLOW_CHEAT_SPELLS))
{
m_customError = SPELL_CUSTOM_ERROR_GM_ONLY;
@@ -5481,7 +5477,6 @@ SpellCastResult Spell::CheckCast(bool strict)
return SPELL_FAILED_MOVING;
}
Vehicle* vehicle = m_caster->GetVehicle();
if (vehicle && !(_triggeredCastFlags & TRIGGERED_IGNORE_CASTER_MOUNTED_OR_ON_VEHICLE))
{
@@ -8561,4 +8556,3 @@ namespace acore
}
} //namespace acore

View File

@@ -1717,10 +1717,8 @@ void Spell::DoCreateItem(uint8 /*effIndex*/, uint32 itemId)
/* == gem perfection handling over == */
/* == profession specialization handling == */
// init items_count to 1, since 1 item will be created regardless of specialization
int32 itemsCount = 1;
float additionalCreateChance = 0.0f;

View File

@@ -1631,7 +1631,6 @@ void SpellMgr::LoadSpellGroups()
++count;
} while (result->NextRow());
sLog->outString(">> Loaded %u spell group definitions in %u ms", count, GetMSTimeDiffToNow(oldMSTime));
sLog->outString();
}
@@ -1672,7 +1671,6 @@ void SpellMgr::LoadSpellGroupStackRules()
break;
}
if (!present)
{
sLog->outErrorDb("SpellGroup id %u listed in `spell_group_stack_rules` does not exist", group_id);
@@ -3978,7 +3976,6 @@ void SpellMgr::LoadDbcDataCorrections()
spellInfo->Dispel = DISPEL_NONE;
});
//////////////////////////////////////////
////////// ULDUAR
//////////////////////////////////////////
@@ -7243,7 +7240,6 @@ void SpellMgr::LoadDbcDataCorrections()
}
if (spellInfo->activeIconID == 2158) // flight
{
spellInfo->Attributes |= SPELL_ATTR0_PASSIVE;
@@ -7275,7 +7271,6 @@ void SpellMgr::LoadDbcDataCorrections()
areaEntry->flags |= AREA_FLAG_REST_ZONE_ALLIANCE;
}
// Xinef: fix for something?
SummonPropertiesEntry* properties = const_cast<SummonPropertiesEntry*>(sSummonPropertiesStore.LookupEntry(121));
properties->Type = SUMMON_TYPE_TOTEM;
@@ -7291,21 +7286,18 @@ void SpellMgr::LoadDbcDataCorrections()
CreatureDisplayInfoEntry* displayEntry = const_cast<CreatureDisplayInfoEntry*>(sCreatureDisplayInfoStore.LookupEntry(17028)); // Kurken
displayEntry->scale = 2.5f;
// Oracles and Frenzyheart faction
FactionEntry* factionEntry = const_cast<FactionEntry*>(sFactionStore.LookupEntry(1104));
factionEntry->ReputationFlags[0] = 0;
factionEntry = const_cast<FactionEntry*>(sFactionStore.LookupEntry(1105));
factionEntry->ReputationFlags[0] = 0;
// Various factions, added 14, 16 to hostile mask
FactionTemplateEntry* factionTemplateEntry = const_cast<FactionTemplateEntry*>(sFactionTemplateStore.LookupEntry(1978)); // Warsong Offensive
factionTemplateEntry->hostileMask |= 8;
factionTemplateEntry = const_cast<FactionTemplateEntry*>(sFactionTemplateStore.LookupEntry(1921)); // The Taunka
factionTemplateEntry->hostileMask |= 8;
// Remove vehicles attr, making accessories selectable
VehicleSeatEntry* vse = const_cast<VehicleSeatEntry*>(sVehicleSeatStore.LookupEntry(4689)); // Siege Engine, Accessory
vse->m_flags &= ~VEHICLE_SEAT_FLAG_PASSENGER_NOT_SELECTABLE;
@@ -7318,7 +7310,6 @@ void SpellMgr::LoadDbcDataCorrections()
vse = const_cast<VehicleSeatEntry*>(sVehicleSeatStore.LookupEntry(3077)); // Salvaged Demolisher Seat, Ulduar - not allow to change seats
vse->m_flags &= ~VEHICLE_SEAT_FLAG_CAN_SWITCH;
// pussywizard: fix z offset for some vehicles:
vse = const_cast<VehicleSeatEntry*>(sVehicleSeatStore.LookupEntry(6206)); // Marrowgar - Bone Spike
vse->m_attachmentOffsetZ = 4.0f;
@@ -7348,13 +7339,10 @@ void SpellMgr::LoadDbcDataCorrections()
vse->m_attachmentOffsetX += 0.0f;
vse->m_attachmentOffsetY += 1.6f;
// Once Bitten, Twice Shy (10 player) - Icecrown Citadel
AchievementEntry* achievement = const_cast<AchievementEntry*>(sAchievementStore.LookupEntry(4539));
achievement->mapID = 631; // Correct map requirement (currently has Ulduar)
// Ring of Valor starting Locations
GraveyardStruct const* entry = sGraveyard->GetGraveyard(1364);
const_cast<GraveyardStruct*>(entry)->z += 6.0f;

View File

@@ -77,7 +77,6 @@ enum SpellFamilyFlag
SPELLFAMILYFLAG_SHAMAN_TOTEM_EFFECTS = 0x04000000, // Seems to be linked to most totems and some totem effects
};
#define SPELL_LINKED_MAX_SPELLS 200000
enum SpellLinkedType
@@ -88,7 +87,6 @@ enum SpellLinkedType
SPELL_LINK_REMOVE = 0,
};
// Spell proc event related declarations (accessed using SpellMgr functions)
enum ProcFlags
{
@@ -444,7 +442,7 @@ private:
typedef std::unordered_map<uint32, uint32> PetAuraMap;
public:
PetAura()
PetAura()
{
auras.clear();
}

View File

@@ -1148,4 +1148,3 @@ AuraApplication const* AuraScript::GetTargetApplication() const
{
return m_auraApplication;
}