diff --git a/src/common/Common.h b/src/common/Common.h index c050ee16b..cb488bd00 100644 --- a/src/common/Common.h +++ b/src/common/Common.h @@ -42,16 +42,14 @@ #define MAX_NETCLIENT_PACKET_SIZE (32767 - 1) // Client hardcap: int16 with trailing zero space otherwise crash on memory free -enum TimeConstants -{ - MINUTE = 60, - HOUR = MINUTE * 60, - DAY = HOUR * 24, - WEEK = DAY * 7, - MONTH = DAY * 30, - YEAR = MONTH * 12, - IN_MILLISECONDS = 1000 -}; +// TimeConstants +constexpr auto MINUTE = 60; +constexpr auto HOUR = MINUTE * 60; +constexpr auto DAY = HOUR * 24; +constexpr auto WEEK = DAY * 7; +constexpr auto MONTH = DAY * 30; +constexpr auto YEAR = MONTH * 12; +constexpr auto IN_MILLISECONDS = 1000; enum AccountTypes { diff --git a/src/server/game/AuctionHouse/AuctionHouseMgr.cpp b/src/server/game/AuctionHouse/AuctionHouseMgr.cpp index 78d422519..383ecfac5 100644 --- a/src/server/game/AuctionHouse/AuctionHouseMgr.cpp +++ b/src/server/game/AuctionHouse/AuctionHouseMgr.cpp @@ -12,7 +12,6 @@ #include "DatabaseEnv.h" #include "DBCStores.h" #include "Item.h" -#include "Language.h" #include "Logging/Log.h" #include "ObjectMgr.h" #include "Player.h" @@ -22,10 +21,7 @@ #include "WorldSession.h" #include -enum eAuctionHouse -{ - AH_MINIMUM_DEPOSIT = 100, -}; +constexpr auto AH_MINIMUM_DEPOSIT = 100; AuctionHouseMgr::AuctionHouseMgr() { @@ -563,7 +559,7 @@ bool AuctionHouseObject::BuildListAuctionItems(WorldPacket& data, Player* player for (AuctionEntryMap::const_iterator itr = AuctionsMap.begin(); itr != AuctionsMap.end(); ++itr) { - if (AsyncAuctionListingMgr::IsAuctionListingAllowed() == false) // pussywizard: World::Update is waiting for us... + if (!AsyncAuctionListingMgr::IsAuctionListingAllowed()) // pussywizard: World::Update is waiting for us... if ((itrcounter++) % 100 == 0) // check condition every 100 iterations if (avgDiffTracker.getAverage() >= 30 || getMSTimeDiff(World::GetGameTimeMS(), getMSTime()) >= 10) // pussywizard: stop immediately if diff is high or waiting too long return false; diff --git a/src/server/game/Battlefield/Battlefield.h b/src/server/game/Battlefield/Battlefield.h index 5c158e5bc..03db34557 100644 --- a/src/server/game/Battlefield/Battlefield.h +++ b/src/server/game/Battlefield/Battlefield.h @@ -44,10 +44,7 @@ enum BattlefieldSounds BF_START = 3439 }; -enum BattlefieldTimers -{ - BATTLEFIELD_OBJECTIVE_UPDATE_INTERVAL = 1000 -}; +constexpr auto BATTLEFIELD_OBJECTIVE_UPDATE_INTERVAL = 1000; const uint32 BattlefieldFactions[BG_TEAMS_COUNT] = { diff --git a/src/server/scripts/Northrend/AzjolNerub/ahnkahet/boss_prince_taldaram.cpp b/src/server/scripts/Northrend/AzjolNerub/ahnkahet/boss_prince_taldaram.cpp index 4e69e5d1a..8e34bb8b0 100644 --- a/src/server/scripts/Northrend/AzjolNerub/ahnkahet/boss_prince_taldaram.cpp +++ b/src/server/scripts/Northrend/AzjolNerub/ahnkahet/boss_prince_taldaram.cpp @@ -281,8 +281,8 @@ public: me->CastSpell(me, me->GetMap()->IsHeroic() ? SPELL_FLAME_SPHERE_PERIODIC_H : SPELL_FLAME_SPHERE_PERIODIC, true); float angle = rand_norm() * 2 * M_PI; - float x = me->GetPositionX() + DATA_SPHERE_DISTANCE * cos(angle); - float y = me->GetPositionY() + DATA_SPHERE_DISTANCE * sin(angle); + float x = me->GetPositionX() + static_cast(DATA_SPHERE_DISTANCE) * cos(angle); + float y = me->GetPositionY() + static_cast(DATA_SPHERE_DISTANCE) * sin(angle); me->GetMotionMaster()->MovePoint(0, x, y, me->GetPositionZ()); } }