nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-16 18:40:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core\OpCode): HandleFarSightOpcode (#9965)

Browse Source 
* Change TO ThreadUNSAFE

This will process the far sight packet as a is not thread-safe - process it in World::UpdateSessions() compared to the former packet is thread-safe - process it in Map::Update().
This matches up with tc in everything we have with the HandleFarSightOpcode.

* Further Adjustments

* Move to Debug Loggin

TC has it as move to Debug Logging. Stating its a weird opcode handling issue which is not really known why.
This commit is contained in:
acidmanifesto
2022-01-06 13:22:08 +01:00
committed by GitHub
parent 93322bcb4d
commit d504a62293
5 changed files with 12 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/server/game/Entities/Unit/Unit.cpp
View File

@@ -351,19 +351,6 @@ Unit::~Unit()
ASSERT(!m_attacking);
ASSERT(m_attackers.empty());
// pussywizard: clear m_sharedVision along with back references
if (!m_sharedVision.empty())
{
LOG_INFO("misc", "Unit::~Unit (B1)");
do
{
LOG_INFO("misc", "Unit::~Unit (B2)");
Player* p = *(m_sharedVision.begin());
p->m_isInSharedVisionOf.erase(this);
m_sharedVision.erase(p);
} while (!m_sharedVision.empty());
}
ASSERT(m_Controlled.empty());
ASSERT(m_appliedAuras.empty());
ASSERT(m_ownedAuras.empty());
@@ -10624,15 +10611,13 @@ void Unit::AddPlayerToVision(Player* player)
setActive(true);
SetWorldObject(true);
}
m_sharedVision.insert(player);
player->m_isInSharedVisionOf.insert(this);
m_sharedVision.push_back(player);
}
// only called in Player::SetSeer
void Unit::RemovePlayerFromVision(Player* player)
{
m_sharedVision.erase(player);
player->m_isInSharedVisionOf.erase(this);
m_sharedVision.remove(player);
if (m_sharedVision.empty())
{
setActive(false);