refactor(Core): apply clang-tidy modernize-use-override (#3817)

src/server/scripts/OutdoorPvP/OutdoorPvPEP.cpp

@@ -763,7 +763,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPEP();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPEP.h

@@ -177,15 +177,15 @@ public:
 
     OPvPCapturePointEP_EWT(OutdoorPvP* pvp);
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
 protected:
 
@@ -206,15 +206,15 @@ public:
 
     OPvPCapturePointEP_NPT(OutdoorPvP* pvp);
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
 protected:
 
@@ -235,15 +235,15 @@ public:
 
     OPvPCapturePointEP_CGT(OutdoorPvP* pvp);
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
 protected:
 
@@ -264,15 +264,15 @@ public:
 
     OPvPCapturePointEP_PWT(OutdoorPvP* pvp);
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
 protected:
 
@@ -293,16 +293,16 @@ public:
 
     OutdoorPvPEP();
 
-    bool SetupOutdoorPvP();
+    bool SetupOutdoorPvP() override;
 
-    void HandlePlayerEnterZone(Player* player, uint32 zone);
-    void HandlePlayerLeaveZone(Player* player, uint32 zone);
+    void HandlePlayerEnterZone(Player* player, uint32 zone) override;
+    void HandlePlayerLeaveZone(Player* player, uint32 zone) override;
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void SendRemoveWorldStates(Player* player);
+    void SendRemoveWorldStates(Player* player) override;
 
     void BuffTeams();
 

src/server/scripts/OutdoorPvP/OutdoorPvPGH.cpp

@@ -112,7 +112,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPGH();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPGH.h

@@ -29,8 +29,8 @@ class OutdoorPvPGH : public OutdoorPvP
 {
 public:
     OutdoorPvPGH();
-    bool SetupOutdoorPvP();
-    void SendRemoveWorldStates(Player* player);
+    bool SetupOutdoorPvP() override;
+    void SendRemoveWorldStates(Player* player) override;
 
 private:
     OPvPCapturePointGH* m_obj;
@@ -41,13 +41,13 @@ class OPvPCapturePointGH : public OPvPCapturePoint
 public:
     OPvPCapturePointGH(OutdoorPvP* pvp);
 
-    void ChangeState();
-    void SendChangePhase();
+    void ChangeState() override;
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 };
 
 #endif

src/server/scripts/OutdoorPvP/OutdoorPvPHP.cpp

@@ -357,7 +357,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPHP();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPHP.h

@@ -80,15 +80,15 @@ public:
 
     OPvPCapturePointHP(OutdoorPvP* pvp, OutdoorPvPHPTowerType type);
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
 private:
 
@@ -101,18 +101,18 @@ public:
 
     OutdoorPvPHP();
 
-    bool SetupOutdoorPvP();
+    bool SetupOutdoorPvP() override;
 
-    void HandlePlayerEnterZone(Player* player, uint32 zone);
-    void HandlePlayerLeaveZone(Player* player, uint32 zone);
+    void HandlePlayerEnterZone(Player* player, uint32 zone) override;
+    void HandlePlayerLeaveZone(Player* player, uint32 zone) override;
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void SendRemoveWorldStates(Player* player);
+    void SendRemoveWorldStates(Player* player) override;
 
-    void HandleKillImpl(Player* player, Unit* killed);
+    void HandleKillImpl(Player* player, Unit* killed) override;
 
     uint32 GetAllianceTowersControlled() const;
     void SetAllianceTowersControlled(uint32 count);

src/server/scripts/OutdoorPvP/OutdoorPvPNA.cpp

@@ -656,7 +656,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPNA();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPNA.h

@@ -245,21 +245,21 @@ public:
 
     OPvPCapturePointNA(OutdoorPvP* pvp);
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
-    bool HandleCustomSpell(Player* player, uint32 spellId, GameObject* go);
+    bool HandleCustomSpell(Player* player, uint32 spellId, GameObject* go) override;
 
-    int32 HandleOpenGo(Player* player, uint64 guid);
+    int32 HandleOpenGo(Player* player, uint64 guid) override;
 
     uint32 GetAliveGuardsCount();
     TeamId GetControllingFaction() const;
@@ -304,18 +304,18 @@ public:
 
     OutdoorPvPNA();
 
-    bool SetupOutdoorPvP();
+    bool SetupOutdoorPvP() override;
 
-    void HandlePlayerEnterZone(Player* player, uint32 zone);
-    void HandlePlayerLeaveZone(Player* player, uint32 zone);
+    void HandlePlayerEnterZone(Player* player, uint32 zone) override;
+    void HandlePlayerLeaveZone(Player* player, uint32 zone) override;
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void SendRemoveWorldStates(Player* player);
+    void SendRemoveWorldStates(Player* player) override;
 
-    void HandleKillImpl(Player* player, Unit* killed);
+    void HandleKillImpl(Player* player, Unit* killed) override;
 
 private:
 

src/server/scripts/OutdoorPvP/OutdoorPvPSI.cpp

@@ -240,7 +240,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPSI();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPSI.h

@@ -46,22 +46,22 @@ public:
 
     OutdoorPvPSI();
 
-    bool SetupOutdoorPvP();
+    bool SetupOutdoorPvP() override;
 
-    void HandlePlayerEnterZone(Player* player, uint32 zone);
-    void HandlePlayerLeaveZone(Player* player, uint32 zone);
+    void HandlePlayerEnterZone(Player* player, uint32 zone) override;
+    void HandlePlayerLeaveZone(Player* player, uint32 zone) override;
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void SendRemoveWorldStates(Player* player);
+    void SendRemoveWorldStates(Player* player) override;
 
-    bool HandleAreaTrigger(Player* player, uint32 trigger);
+    bool HandleAreaTrigger(Player* player, uint32 trigger) override;
 
-    bool HandleDropFlag(Player* player, uint32 spellId);
+    bool HandleDropFlag(Player* player, uint32 spellId) override;
 
-    bool HandleCustomSpell(Player* player, uint32 spellId, GameObject* go);
+    bool HandleCustomSpell(Player* player, uint32 spellId, GameObject* go) override;
 
     void UpdateWorldState();
 

src/server/scripts/OutdoorPvP/OutdoorPvPTF.cpp

@@ -356,7 +356,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPTF();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPTF.h

@@ -116,17 +116,17 @@ public:
 
     OPvPCapturePointTF(OutdoorPvP* pvp, OutdoorPvPTF_TowerType type);
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
     void UpdateTowerState();
 
@@ -143,16 +143,16 @@ public:
 
     OutdoorPvPTF();
 
-    bool SetupOutdoorPvP();
+    bool SetupOutdoorPvP() override;
 
-    void HandlePlayerEnterZone(Player* player, uint32 zone);
-    void HandlePlayerLeaveZone(Player* player, uint32 zone);
+    void HandlePlayerEnterZone(Player* player, uint32 zone) override;
+    void HandlePlayerLeaveZone(Player* player, uint32 zone) override;
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void SendRemoveWorldStates(Player* player);
+    void SendRemoveWorldStates(Player* player) override;
 
     uint32 GetAllianceTowersControlled() const;
     void SetAllianceTowersControlled(uint32 count);

src/server/scripts/OutdoorPvP/OutdoorPvPZM.cpp

@@ -450,7 +450,7 @@ public:
     {
     }
 
-    OutdoorPvP* GetOutdoorPvP() const
+    OutdoorPvP* GetOutdoorPvP() const override
     {
         return new OutdoorPvPZM();
     }

src/server/scripts/OutdoorPvP/OutdoorPvPZM.h

@@ -161,15 +161,15 @@ public:
 
     OPvPCapturePointZM_Beacon(OutdoorPvP* pvp, ZM_BeaconType type);
 
-    void ChangeState();
+    void ChangeState() override;
 
-    void SendChangePhase();
+    void SendChangePhase() override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     // used when player is activated/inactivated in the area
-    bool HandlePlayerEnter(Player* player);
-    void HandlePlayerLeave(Player* player);
+    bool HandlePlayerEnter(Player* player) override;
+    void HandlePlayerLeave(Player* player) override;
 
     void UpdateTowerState();
 
@@ -192,23 +192,23 @@ public:
 
     OPvPCapturePointZM_GraveYard(OutdoorPvP* pvp);
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void ChangeState() {}
+    void ChangeState() override {}
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
     void UpdateTowerState();
 
-    int32 HandleOpenGo(Player* player, uint64 guid);
+    int32 HandleOpenGo(Player* player, uint64 guid) override;
 
     void SetBeaconState(TeamId controlling_teamId); // not good atm
 
-    bool HandleGossipOption(Player* player, uint64 guid, uint32 gossipid);
+    bool HandleGossipOption(Player* player, uint64 guid, uint32 gossipid) override;
 
-    bool HandleDropFlag(Player* player, uint32 spellId);
+    bool HandleDropFlag(Player* player, uint32 spellId) override;
 
-    bool CanTalkTo(Player* player, Creature* creature, GossipMenuItems const& gso);
+    bool CanTalkTo(Player* player, Creature* creature, GossipMenuItems const& gso) override;
 
     uint32 GetGraveYardState() const;
 
@@ -228,18 +228,18 @@ public:
 
     OutdoorPvPZM();
 
-    bool SetupOutdoorPvP();
+    bool SetupOutdoorPvP() override;
 
-    void HandlePlayerEnterZone(Player* player, uint32 zone);
-    void HandlePlayerLeaveZone(Player* player, uint32 zone);
+    void HandlePlayerEnterZone(Player* player, uint32 zone) override;
+    void HandlePlayerLeaveZone(Player* player, uint32 zone) override;
 
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
-    void FillInitialWorldStates(WorldPacket& data);
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void SendRemoveWorldStates(Player* player);
+    void SendRemoveWorldStates(Player* player) override;
 
-    void HandleKillImpl(Player* player, Unit* killed);
+    void HandleKillImpl(Player* player, Unit* killed) override;
 
     uint32 GetAllianceTowersControlled() const;
     void SetAllianceTowersControlled(uint32 count);