refactor(Core): apply clang-tidy modernize-use-override (#3817)

src/server/game/Entities/Corpse/Corpse.h

@@ -38,7 +38,7 @@ class Corpse : public WorldObject, public GridObject<Corpse>
 {
 public:
     explicit Corpse(CorpseType type = CORPSE_BONES);
-    ~Corpse();
+    ~Corpse() override;
 
     void AddToWorld() override;
     void RemoveFromWorld() override;

src/server/game/Entities/Creature/Creature.h

@@ -430,7 +430,7 @@ class Creature : public Unit, public GridObject<Creature>, public MovableMapObje
 public:
 
     explicit Creature(bool isWorldObject = false);
-    virtual ~Creature();
+    ~Creature() override;
 
     void AddToWorld() override;
     void RemoveFromWorld() override;
@@ -523,8 +523,8 @@ public:
     void SetMeleeDamageSchool(SpellSchools school) { m_meleeDamageSchoolMask = SpellSchoolMask(1 << school); }
 
     void _AddCreatureSpellCooldown(uint32 spell_id, uint32 end_time);
-    virtual void AddSpellCooldown(uint32 spell_id, uint32 /*itemid*/, uint32 end_time, bool needSendToClient = false, bool forceSendToSpectator = false) override;
-    virtual bool HasSpellCooldown(uint32 spell_id) const override;
+    void AddSpellCooldown(uint32 spell_id, uint32 /*itemid*/, uint32 end_time, bool needSendToClient = false, bool forceSendToSpectator = false) override;
+    bool HasSpellCooldown(uint32 spell_id) const override;
     uint32 GetSpellCooldown(uint32 spell_id) const;
     void ProhibitSpellSchool(SpellSchoolMask idSchoolMask, uint32 unTimeMs) override;
     bool IsSpellProhibited(SpellSchoolMask idSchoolMask) const;
@@ -799,7 +799,7 @@ class AssistDelayEvent : public BasicEvent
 public:
     AssistDelayEvent(uint64 victim, Unit& owner) : BasicEvent(), m_victim(victim), m_owner(owner) { }
 
-    bool Execute(uint64 e_time, uint32 p_time);
+    bool Execute(uint64 e_time, uint32 p_time) override;
     void AddAssistant(uint64 guid) { m_assistants.push_back(guid); }
 private:
     AssistDelayEvent();
@@ -813,7 +813,7 @@ class ForcedDespawnDelayEvent : public BasicEvent
 {
 public:
     ForcedDespawnDelayEvent(Creature& owner) : BasicEvent(), m_owner(owner) { }
-    bool Execute(uint64 e_time, uint32 p_time);
+    bool Execute(uint64 e_time, uint32 p_time) override;
 
 private:
     Creature& m_owner;

src/server/game/Entities/Creature/TemporarySummon.h

@@ -29,14 +29,14 @@ class TempSummon : public Creature
 {
 public:
     explicit TempSummon(SummonPropertiesEntry const* properties, uint64 owner, bool isWorldObject);
-    virtual ~TempSummon() {}
-    void Update(uint32 time);
+    ~TempSummon() override {}
+    void Update(uint32 time) override;
     virtual void InitStats(uint32 lifetime);
     virtual void InitSummon();
     virtual void UnSummon(uint32 msTime = 0);
-    void RemoveFromWorld();
+    void RemoveFromWorld() override;
     void SetTempSummonType(TempSummonType type);
-    void SaveToDB(uint32 /*mapid*/, uint8 /*spawnMask*/, uint32 /*phaseMask*/) {}
+    void SaveToDB(uint32 /*mapid*/, uint8 /*spawnMask*/, uint32 /*phaseMask*/) override {}
     Unit* GetSummoner() const;
     uint64 GetSummonerGUID() { return m_summonerGUID; }
     TempSummonType const& GetSummonType() { return m_type; }
@@ -55,14 +55,14 @@ class Minion : public TempSummon
 {
 public:
     Minion(SummonPropertiesEntry const* properties, uint64 owner, bool isWorldObject);
-    void InitStats(uint32 duration);
-    void RemoveFromWorld();
+    void InitStats(uint32 duration) override;
+    void RemoveFromWorld() override;
     Unit* GetOwner() const;
-    float GetFollowAngle() const { return m_followAngle; }
+    float GetFollowAngle() const override { return m_followAngle; }
     void SetFollowAngle(float angle) { m_followAngle = angle; }
     bool IsPetGhoul() const {return GetEntry() == 26125 /*normal ghoul*/ || GetEntry() == 30230 /*Raise Ally ghoul*/;} // Ghoul may be guardian or pet
     bool IsGuardianPet() const;
-    void setDeathState(DeathState s, bool despawn = false);                   // override virtual Unit::setDeathState
+    void setDeathState(DeathState s, bool despawn = false) override;                   // override virtual Unit::setDeathState
 protected:
     const uint64 m_owner;
     float m_followAngle;
@@ -72,27 +72,27 @@ class Guardian : public Minion
 {
 public:
     Guardian(SummonPropertiesEntry const* properties, uint64 owner, bool isWorldObject);
-    void InitStats(uint32 duration);
+    void InitStats(uint32 duration) override;
     bool InitStatsForLevel(uint8 level);
-    void InitSummon();
+    void InitSummon() override;
 
-    bool UpdateStats(Stats stat);
-    bool UpdateAllStats();
-    void UpdateArmor();
-    void UpdateMaxHealth();
-    void UpdateMaxPower(Powers power);
-    void UpdateAttackPowerAndDamage(bool ranged = false);
-    void UpdateDamagePhysical(WeaponAttackType attType);
+    bool UpdateStats(Stats stat) override;
+    bool UpdateAllStats() override;
+    void UpdateArmor() override;
+    void UpdateMaxHealth() override;
+    void UpdateMaxPower(Powers power) override;
+    void UpdateAttackPowerAndDamage(bool ranged = false) override;
+    void UpdateDamagePhysical(WeaponAttackType attType) override;
 };
 
 class Puppet : public Minion
 {
 public:
     Puppet(SummonPropertiesEntry const* properties, uint64 owner);
-    void InitStats(uint32 duration);
-    void InitSummon();
-    void Update(uint32 time);
-    void RemoveFromWorld();
+    void InitStats(uint32 duration) override;
+    void InitSummon() override;
+    void Update(uint32 time) override;
+    void RemoveFromWorld() override;
 protected:
     Player* GetOwner() const;
     const uint64 m_owner;
@@ -102,7 +102,7 @@ class ForcedUnsummonDelayEvent : public BasicEvent
 {
 public:
     ForcedUnsummonDelayEvent(TempSummon& owner) : BasicEvent(), m_owner(owner) { }
-    bool Execute(uint64 e_time, uint32 p_time);
+    bool Execute(uint64 e_time, uint32 p_time) override;
 
 private:
     TempSummon& m_owner;

src/server/game/Entities/DynamicObject/DynamicObject.h

@@ -24,7 +24,7 @@ class DynamicObject : public WorldObject, public GridObject<DynamicObject>, publ
 {
 public:
     DynamicObject(bool isWorldObject);
-    ~DynamicObject();
+    ~DynamicObject() override;
 
     void AddToWorld() override;
     void RemoveFromWorld() override;

src/server/game/Entities/GameObject/GameObject.h

@@ -731,7 +731,7 @@ class GameObject : public WorldObject, public GridObject<GameObject>, public Mov
 {
 public:
     explicit GameObject();
-    ~GameObject();
+    ~GameObject() override;
 
     void BuildValuesUpdate(uint8 updatetype, ByteBuffer* data, Player* target) const override;
 

src/server/game/Entities/Item/Container/Bag.h

@@ -18,12 +18,12 @@ class Bag : public Item
 public:
 
     Bag();
-    ~Bag();
+    ~Bag() override;
 
-    void AddToWorld();
-    void RemoveFromWorld();
+    void AddToWorld() override;
+    void RemoveFromWorld() override;
 
-    bool Create(uint32 guidlow, uint32 itemid, Player const* owner);
+    bool Create(uint32 guidlow, uint32 itemid, Player const* owner) override;
 
     void Clear();
     void StoreItem(uint8 slot, Item* pItem, bool update);
@@ -40,13 +40,13 @@ public:
 
     // DB operations
     // overwrite virtual Item::SaveToDB
-    void SaveToDB(SQLTransaction& trans);
+    void SaveToDB(SQLTransaction& trans) override;
     // overwrite virtual Item::LoadFromDB
-    bool LoadFromDB(uint32 guid, uint64 owner_guid, Field* fields, uint32 entry);
+    bool LoadFromDB(uint32 guid, uint64 owner_guid, Field* fields, uint32 entry) override;
     // overwrite virtual Item::DeleteFromDB
-    void DeleteFromDB(SQLTransaction& trans);
+    void DeleteFromDB(SQLTransaction& trans) override;
 
-    void BuildCreateUpdateBlockForPlayer(UpdateData* data, Player* target) const;
+    void BuildCreateUpdateBlockForPlayer(UpdateData* data, Player* target) const override;
 
 protected:
 

src/server/game/Entities/Item/Item.h

@@ -306,8 +306,8 @@ public:
         uState = state;
     }
 
-    bool hasQuest(uint32 quest_id) const { return GetTemplate()->StartQuest == quest_id; }
-    bool hasInvolvedQuest(uint32 /*quest_id*/) const { return false; }
+    bool hasQuest(uint32 quest_id) const override { return GetTemplate()->StartQuest == quest_id; }
+    bool hasInvolvedQuest(uint32 /*quest_id*/) const override { return false; }
     bool IsPotion() const { return GetTemplate()->IsPotion(); }
     bool IsWeaponVellum() const { return GetTemplate()->IsWeaponVellum(); }
     bool IsArmorVellum() const { return GetTemplate()->IsArmorVellum(); }
@@ -331,7 +331,7 @@ public:
     void ClearSoulboundTradeable(Player* currentOwner);
     bool CheckSoulboundTradeExpire();
 
-    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet&);
+    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet&) override;
 
     uint32 GetScriptId() const { return GetTemplate()->ScriptId; }
 private:

src/server/game/Entities/Object/Object.h

@@ -764,7 +764,7 @@ class WorldObject : public Object, public WorldLocation
 protected:
     explicit WorldObject(bool isWorldObject); //note: here it means if it is in grid object list or world object list
 public:
-    virtual ~WorldObject();
+    ~WorldObject() override;
 
 #ifdef ELUNA
     virtual void Update(uint32 /*time_diff*/);
@@ -773,7 +773,7 @@ public:
 #endif
     void _Create(uint32 guidlow, HighGuid guidhigh, uint32 phaseMask);
 
-    virtual void RemoveFromWorld()
+    void RemoveFromWorld() override
     {
         if (!IsInWorld())
             return;
@@ -1005,7 +1005,7 @@ public:
 
     void DestroyForNearbyPlayers();
     virtual void UpdateObjectVisibility(bool forced = true, bool fromUpdate = false);
-    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet& player_set);
+    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet& player_set) override;
     void GetCreaturesWithEntryInRange(std::list<Creature*>& creatureList, float radius, uint32 entry);
 
     //relocation and visibility system functions

src/server/game/Entities/Pet/Pet.h

@@ -45,7 +45,7 @@ class Pet : public Guardian
 {
 public:
     explicit Pet(Player* owner, PetType type = MAX_PET_TYPE);
-    virtual ~Pet();
+    ~Pet() override;
 
     void AddToWorld() override;
     void RemoveFromWorld() override;

src/server/game/Entities/Player/Player.h

@@ -1138,7 +1138,7 @@ class Player : public Unit, public GridObject<Player>
     friend void Item::RemoveFromUpdateQueueOf(Player* player);
 public:
     explicit Player(WorldSession* session);
-    ~Player();
+    ~Player() override;
 
     void CleanupsBeforeDelete(bool finalCleanup = true) override;
 
@@ -1805,12 +1805,12 @@ public:
 
     static uint32 const infinityCooldownDelay = 0x9A7EC800;  // used for set "infinity cooldowns" for spells and check, MONTH*IN_MILLISECONDS
     static uint32 const infinityCooldownDelayCheck = 0x4D3F6400; //MONTH*IN_MILLISECONDS/2;
-    virtual bool HasSpellCooldown(uint32 spell_id) const override
+    bool HasSpellCooldown(uint32 spell_id) const override
     {
         SpellCooldowns::const_iterator itr = m_spellCooldowns.find(spell_id);
         return itr != m_spellCooldowns.end() && itr->second.end > World::GetGameTimeMS();
     }
-    virtual bool HasSpellItemCooldown(uint32 spell_id, uint32 itemid) const override
+    bool HasSpellItemCooldown(uint32 spell_id, uint32 itemid) const override
     {
         SpellCooldowns::const_iterator itr = m_spellCooldowns.find(spell_id);
         return itr != m_spellCooldowns.end() && itr->second.end > World::GetGameTimeMS() && itr->second.itemid == itemid;
@@ -2048,7 +2048,7 @@ public:
     void SendResetInstanceFailed(uint32 reason, uint32 MapId);
     void SendResetFailedNotify(uint32 mapid);
 
-    virtual bool UpdatePosition(float x, float y, float z, float orientation, bool teleport = false) override;
+    bool UpdatePosition(float x, float y, float z, float orientation, bool teleport = false) override;
     bool UpdatePosition(const Position& pos, bool teleport = false) { return UpdatePosition(pos.GetPositionX(), pos.GetPositionY(), pos.GetPositionZ(), pos.GetOrientation(), teleport); }
     void UpdateUnderwaterState(Map* m, float x, float y, float z) override;
 

src/server/game/Entities/Totem/Totem.h

@@ -25,26 +25,26 @@ class Totem : public Minion
 {
 public:
     explicit Totem(SummonPropertiesEntry const* properties, uint64 owner);
-    virtual ~Totem() {};
-    void Update(uint32 time);
-    void InitStats(uint32 duration);
-    void InitSummon();
-    void UnSummon(uint32 msTime = 0);
+    ~Totem() override {};
+    void Update(uint32 time) override;
+    void InitStats(uint32 duration) override;
+    void InitSummon() override;
+    void UnSummon(uint32 msTime = 0) override;
     uint32 GetSpell(uint8 slot = 0) const { return m_spells[slot]; }
     uint32 GetTotemDuration() const { return m_duration; }
     void SetTotemDuration(uint32 duration) { m_duration = duration; }
     TotemType GetTotemType() const { return m_type; }
 
-    bool UpdateStats(Stats /*stat*/) { return true; }
-    bool UpdateAllStats() { return true; }
-    void UpdateResistances(uint32 /*school*/) {}
-    void UpdateArmor() {}
-    void UpdateMaxHealth() {}
-    void UpdateMaxPower(Powers /*power*/) {}
-    void UpdateAttackPowerAndDamage(bool /*ranged*/) {}
-    void UpdateDamagePhysical(WeaponAttackType /*attType*/) {}
+    bool UpdateStats(Stats /*stat*/) override { return true; }
+    bool UpdateAllStats() override { return true; }
+    void UpdateResistances(uint32 /*school*/) override {}
+    void UpdateArmor() override {}
+    void UpdateMaxHealth() override {}
+    void UpdateMaxPower(Powers /*power*/) override {}
+    void UpdateAttackPowerAndDamage(bool /*ranged*/) override {}
+    void UpdateDamagePhysical(WeaponAttackType /*attType*/) override {}
 
-    bool IsImmunedToSpellEffect(SpellInfo const* spellInfo, uint32 index) const;
+    bool IsImmunedToSpellEffect(SpellInfo const* spellInfo, uint32 index) const override;
 
 protected:
     TotemType m_type;

src/server/game/Entities/Transport/Transport.h

@@ -18,8 +18,8 @@ class Transport : public GameObject, public TransportBase
 {
 public:
     Transport() : GameObject() {}
-    void CalculatePassengerPosition(float& x, float& y, float& z, float* o = nullptr) const { TransportBase::CalculatePassengerPosition(x, y, z, o, GetPositionX(), GetPositionY(), GetPositionZ(), GetOrientation()); }
-    void CalculatePassengerOffset(float& x, float& y, float& z, float* o = nullptr) const { TransportBase::CalculatePassengerOffset(x, y, z, o, GetPositionX(), GetPositionY(), GetPositionZ(), GetOrientation()); }
+    void CalculatePassengerPosition(float& x, float& y, float& z, float* o = nullptr) const override { TransportBase::CalculatePassengerPosition(x, y, z, o, GetPositionX(), GetPositionY(), GetPositionZ(), GetOrientation()); }
+    void CalculatePassengerOffset(float& x, float& y, float& z, float* o = nullptr) const override { TransportBase::CalculatePassengerOffset(x, y, z, o, GetPositionX(), GetPositionY(), GetPositionZ(), GetOrientation()); }
 
     typedef std::set<WorldObject*> PassengerSet;
     virtual void AddPassenger(WorldObject* passenger, bool withAll = false) = 0;
@@ -38,18 +38,18 @@ class MotionTransport : public Transport
     friend MotionTransport* TransportMgr::CreateTransport(uint32, uint32, Map*);
     MotionTransport();
 public:
-    ~MotionTransport();
+    ~MotionTransport() override;
 
     bool CreateMoTrans(uint32 guidlow, uint32 entry, uint32 mapid, float x, float y, float z, float ang, uint32 animprogress);
-    void CleanupsBeforeDelete(bool finalCleanup = true);
-    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet&);
+    void CleanupsBeforeDelete(bool finalCleanup = true) override;
+    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet&) override;
 
-    void Update(uint32 diff);
+    void Update(uint32 diff) override;
     void DelayedUpdate(uint32 diff);
     void UpdatePosition(float x, float y, float z, float o);
 
-    void AddPassenger(WorldObject* passenger, bool withAll = false);
-    void RemovePassenger(WorldObject* passenger, bool withAll = false);
+    void AddPassenger(WorldObject* passenger, bool withAll = false) override;
+    void RemovePassenger(WorldObject* passenger, bool withAll = false) override;
     Creature* CreateNPCPassenger(uint32 guid, CreatureData const* data);
     GameObject* CreateGOPassenger(uint32 guid, GameObjectData const* data);
 
@@ -100,19 +100,19 @@ class StaticTransport : public Transport
 {
 public:
     StaticTransport();
-    ~StaticTransport();
+    ~StaticTransport() override;
 
-    virtual bool Create(uint32 guidlow, uint32 name_id, Map* map, uint32 phaseMask, float x, float y, float z, float ang, G3D::Quat const& rotation, uint32 animprogress, GOState go_state, uint32 artKit = 0);
-    void CleanupsBeforeDelete(bool finalCleanup = true);
-    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet&);
+    bool Create(uint32 guidlow, uint32 name_id, Map* map, uint32 phaseMask, float x, float y, float z, float ang, G3D::Quat const& rotation, uint32 animprogress, GOState go_state, uint32 artKit = 0) override;
+    void CleanupsBeforeDelete(bool finalCleanup = true) override;
+    void BuildUpdate(UpdateDataMapType& data_map, UpdatePlayerSet&) override;
 
-    void Update(uint32 diff);
+    void Update(uint32 diff) override;
     void RelocateToProgress(uint32 progress);
     void UpdatePosition(float x, float y, float z, float o);
     void UpdatePassengerPositions();
 
-    void AddPassenger(WorldObject* passenger, bool withAll = false);
-    void RemovePassenger(WorldObject* passenger, bool withAll = false);
+    void AddPassenger(WorldObject* passenger, bool withAll = false) override;
+    void RemovePassenger(WorldObject* passenger, bool withAll = false) override;
 
     uint32 GetPauseTime() const { return GetUInt32Value(GAMEOBJECT_LEVEL); }
     void SetPauseTime(uint32 val) { SetUInt32Value(GAMEOBJECT_LEVEL, val); }

src/server/game/Entities/Unit/Unit.cpp

@@ -19074,7 +19074,7 @@ class AuraMunchingQueue : public BasicEvent
 public:
     AuraMunchingQueue(Unit& owner, uint64 targetGUID, int32 basePoints, uint32 spellId) : _owner(owner), _targetGUID(targetGUID), _basePoints(basePoints), _spellId(spellId) { }
 
-    bool Execute(uint64 /*eventTime*/, uint32 /*updateTime*/)
+    bool Execute(uint64 /*eventTime*/, uint32 /*updateTime*/) override
     {
         if (_owner.IsInWorld() && _owner.FindMap())
             if (Unit* target = ObjectAccessor::GetUnit(_owner, _targetGUID))

src/server/game/Entities/Unit/Unit.h

@@ -1373,7 +1373,7 @@ public:
 
     typedef std::map<uint8, AuraApplication*> VisibleAuraMap;
 
-    virtual ~Unit();
+    ~Unit() override;
 
     UnitAI* GetAI() { return i_AI; }
     void SetAI(UnitAI* newAI) { i_AI = newAI; }
@@ -1394,7 +1394,7 @@ public:
     float GetSpellMaxRangeForTarget(Unit const* target, SpellInfo const* spellInfo) const;
     float GetSpellMinRangeForTarget(Unit const* target, SpellInfo const* spellInfo) const;
 
-    virtual void Update(uint32 time) override;
+    void Update(uint32 time) override;
 
     void setAttackTimer(WeaponAttackType type, int32 time) { m_attackTimer[type] = time; }
     void resetAttackTimer(WeaponAttackType type = BASE_ATTACK);
@@ -2638,7 +2638,7 @@ class ConflagrateAuraStateDelayEvent : public BasicEvent
 {
 public:
     ConflagrateAuraStateDelayEvent(uint64 ownerGUID, uint64 casterGUID) : BasicEvent(), m_owner(ownerGUID), m_caster(casterGUID) { }
-    bool Execute(uint64 e_time, uint32 p_time);
+    bool Execute(uint64 e_time, uint32 p_time) override;
 
 private:
     uint64 m_owner;
@@ -2649,7 +2649,7 @@ class RedirectSpellEvent : public BasicEvent
 {
 public:
     RedirectSpellEvent(Unit& self, uint64 auraOwnerGUID, AuraEffect* auraEffect) : _self(self), _auraOwnerGUID(auraOwnerGUID), _auraEffect(auraEffect) { }
-    bool Execute(uint64 e_time, uint32 p_time);
+    bool Execute(uint64 e_time, uint32 p_time) override;
 
 protected:
     Unit& _self;
@@ -2661,7 +2661,7 @@ class VehicleDespawnEvent : public BasicEvent
 {
 public:
     VehicleDespawnEvent(Unit& self, uint32 duration) : _self(self), _duration(duration) { }
-    bool Execute(uint64 e_time, uint32 p_time);
+    bool Execute(uint64 e_time, uint32 p_time) override;
 
 protected:
     Unit& _self;

src/server/game/Entities/Vehicle/Vehicle.h

@@ -52,7 +52,7 @@ protected:
     friend bool Unit::CreateVehicleKit(uint32 id, uint32 creatureEntry);
     Vehicle(Unit* unit, VehicleEntry const* vehInfo, uint32 creatureEntry);
     friend void Unit::RemoveVehicleKit();
-    ~Vehicle();
+    ~Vehicle() override;
 
 private:
     enum Status
@@ -65,7 +65,7 @@ private:
     void InitMovementInfoForBase();
 
     /// This method transforms supplied transport offsets into global coordinates
-    void CalculatePassengerPosition(float& x, float& y, float& z, float* o /*= NULL*/) const
+    void CalculatePassengerPosition(float& x, float& y, float& z, float* o /*= NULL*/) const override
     {
         TransportBase::CalculatePassengerPosition(x, y, z, o,
                 GetBase()->GetPositionX(), GetBase()->GetPositionY(),
@@ -73,7 +73,7 @@ private:
     }
 
     /// This method transforms supplied global coordinates into local offsets
-    void CalculatePassengerOffset(float& x, float& y, float& z, float* o /*= NULL*/) const
+    void CalculatePassengerOffset(float& x, float& y, float& z, float* o /*= NULL*/) const override
     {
         TransportBase::CalculatePassengerOffset(x, y, z, o,
                                                 GetBase()->GetPositionX(), GetBase()->GetPositionY(),