refactor(Core): apply clang-tidy modernize-use-override (#3817)

src/server/game/Battlefield/Battlefield.h

@@ -203,7 +203,7 @@ public:
     /// Constructor
     Battlefield();
     /// Destructor
-    virtual ~Battlefield();
+    ~Battlefield() override;
 
     /// typedef of map witch store capturepoint and the associate gameobject entry
     typedef std::map<uint32 /*lowguid */, BfCapturePoint*> BfCapturePointMap;
@@ -258,12 +258,12 @@ public:
     void HandlePlayerLeaveZone(Player* player, uint32 zone);
 
     // All-purpose data storage 64 bit
-    virtual uint64 GetData64(uint32 dataId) const { return m_Data64[dataId]; }
-    virtual void SetData64(uint32 dataId, uint64 value) { m_Data64[dataId] = value; }
+    uint64 GetData64(uint32 dataId) const override { return m_Data64[dataId]; }
+    void SetData64(uint32 dataId, uint64 value) override { m_Data64[dataId] = value; }
 
     // All-purpose data storage 32 bit
-    virtual uint32 GetData(uint32 dataId) const { return m_Data32[dataId]; }
-    virtual void SetData(uint32 dataId, uint32 value) { m_Data32[dataId] = value; }
+    uint32 GetData(uint32 dataId) const override { return m_Data32[dataId]; }
+    void SetData(uint32 dataId, uint32 value) override { m_Data32[dataId] = value; }
     virtual void UpdateData(uint32 index, int32 pad) { m_Data32[index] += pad; }
 
     // Battlefield - generic methods

src/server/game/Battlefield/Zones/BattlefieldWG.h

@@ -250,7 +250,7 @@ public:
 
     void LinkToWorkshop(WGWorkshop* workshop) { m_Workshop = workshop; }
 
-    void ChangeTeam(TeamId oldteam);
+    void ChangeTeam(TeamId oldteam) override;
     TeamId GetTeam() const { return m_team; }
 
 protected:
@@ -264,14 +264,14 @@ protected:
 class BattlefieldWG : public Battlefield
 {
 public:
-    ~BattlefieldWG();
+    ~BattlefieldWG() override;
     /**
      * \brief Called when the battle start
      * - Spawn relic and turret
      * - Rebuild tower and wall
      * - Invite player to war
      */
-    void OnBattleStart();
+    void OnBattleStart() override;
 
     /**
      * \brief Called when battle end
@@ -282,13 +282,13 @@ public:
      * - Remove vehicle
      * \param endByTimer : true if battle ended when timer is at 00:00, false if battle ended by clicking on relic
      */
-    void OnBattleEnd(bool endByTimer);
+    void OnBattleEnd(bool endByTimer) override;
 
     /**
      * \brief Called when grouping starts (15 minutes before battlestart)
      * - Invite all player in zone to join queue
      */
-    void OnStartGrouping();
+    void OnStartGrouping() override;
 
     /**
      * \brief Called when player accept invite to join battle
@@ -298,20 +298,20 @@ public:
      * - Update tenacity
      * \param player: Player who accepted invite
      */
-    void OnPlayerJoinWar(Player* player);
+    void OnPlayerJoinWar(Player* player) override;
 
     /**
      * \brief Called when player left the battle
      * - Update player aura
      * \param player : Player who left the battle
      */
-    void OnPlayerLeaveWar(Player* player);
+    void OnPlayerLeaveWar(Player* player) override;
 
     /**
      * \brief Called when player left the WG zone
      * \param player : Player who left the zone
      */
-    void OnPlayerLeaveZone(Player* player);
+    void OnPlayerLeaveZone(Player* player) override;
 
     /**
      * \brief Called when player enters in WG zone
@@ -319,7 +319,7 @@ public:
      * - Update worldstate
      * \param player : Player who enters the zone
      */
-    void OnPlayerEnterZone(Player* player);
+    void OnPlayerEnterZone(Player* player) override;
 
     /**
      * \brief Called for update battlefield data
@@ -327,24 +327,24 @@ public:
      * - Update imunity aura from graveyard
      * \param diff : time elapsed since the last call (in ms)
      */
-    bool Update(uint32 diff);
+    bool Update(uint32 diff) override;
 
     /**
      * \brief Called when a creature is created
      * - Update vehicle count
      */
-    void OnCreatureCreate(Creature* creature);
+    void OnCreatureCreate(Creature* creature) override;
 
     /**
      * \brief Called when a creature is removed
      * - Update vehicle count
      */
-    void OnCreatureRemove(Creature* creature);
+    void OnCreatureRemove(Creature* creature) override;
 
     /**
      * \brief Called when a gameobject is created
      */
-    void OnGameObjectCreate(GameObject* go);
+    void OnGameObjectCreate(GameObject* go) override;
 
     /**
      * \brief Called when a wall/tower is broken
@@ -372,7 +372,7 @@ public:
     /**
      * \brief Called when battlefield is setup, at server start
      */
-    bool SetupBattlefield();
+    bool SetupBattlefield() override;
 
     /// Return pointer to relic object
     GameObject* GetRelic() { return ObjectAccessor::GetObjectInWorld(m_titansRelic, (GameObject*)NULL); }
@@ -392,18 +392,18 @@ public:
     void CapturePointTaken(uint32 areaId);
 
     void SendInitWorldStatesTo(Player* player);
-    void SendInitWorldStatesToAll();
-    void FillInitialWorldStates(WorldPacket& data);
+    void SendInitWorldStatesToAll() override;
+    void FillInitialWorldStates(WorldPacket& data) override;
 
-    void HandleKill(Player* killer, Unit* victim);
-    void OnUnitDeath(Unit* unit);
+    void HandleKill(Player* killer, Unit* victim) override;
+    void OnUnitDeath(Unit* unit) override;
     void PromotePlayer(Player* killer);
 
     uint32 GetHonorBuff(int32 stack) const;
     void UpdateTenacity();
     void AddUpdateTenacity(Player* player);
     void RemoveUpdateTenacity(Player* player);
-    void ProcessEvent(WorldObject* obj, uint32 eventId);
+    void ProcessEvent(WorldObject* obj, uint32 eventId) override;
 
     bool FindAndRemoveVehicleFromList(Unit* vehicle);
 
@@ -411,7 +411,7 @@ public:
     uint8 GetSpiritGraveyardId(uint32 areaId) const;
     uint32 GetAreaByGraveyardId(uint8 gId) const;
 
-    uint32 GetData(uint32 data) const;
+    uint32 GetData(uint32 data) const override;
 
     bool IsKeepNpc(uint32 entry)
     {