refactor(Core): apply clang-tidy modernize-use-override (#3817)

src/common/Database/AdhocStatement.h

@@ -17,9 +17,9 @@ class BasicStatementTask : public SQLOperation
 public:
     BasicStatementTask(const char* sql);
     BasicStatementTask(const char* sql, QueryResultFuture result);
-    ~BasicStatementTask();
+    ~BasicStatementTask() override;
 
-    bool Execute();
+    bool Execute() override;
 
 private:
     const char* m_sql;      //- Raw query to be executed

src/common/Database/DatabaseWorker.h

@@ -18,8 +18,8 @@ public:
     DatabaseWorker(ACE_Activation_Queue* new_queue, MySQLConnection* con);
 
     ///- Inherited from ACE_Task_Base
-    int svc();
-    int wait() { return ACE_Task_Base::wait(); }
+    int svc() override;
+    int wait() override { return ACE_Task_Base::wait(); }
 
 private:
     DatabaseWorker() : ACE_Task_Base() { }

src/common/Database/DatabaseWorkerPool.h

@@ -24,7 +24,7 @@
 class PingOperation : public SQLOperation
 {
     //! Operation for idle delaythreads
-    bool Execute()
+    bool Execute() override
     {
         m_conn->Ping();
         return true;

src/common/Database/Implementation/CharacterDatabase.h

@@ -18,7 +18,7 @@ public:
     CharacterDatabaseConnection(ACE_Activation_Queue* q, MySQLConnectionInfo& connInfo) : MySQLConnection(q, connInfo) {}
 
     //- Loads database type specific prepared statements
-    void DoPrepareStatements();
+    void DoPrepareStatements() override;
 };
 
 typedef DatabaseWorkerPool<CharacterDatabaseConnection> CharacterDatabaseWorkerPool;

src/common/Database/Implementation/LoginDatabase.h

@@ -18,7 +18,7 @@ public:
     LoginDatabaseConnection(ACE_Activation_Queue* q, MySQLConnectionInfo& connInfo) : MySQLConnection(q, connInfo) { }
 
     //- Loads database type specific prepared statements
-    void DoPrepareStatements();
+    void DoPrepareStatements() override;
 };
 
 typedef DatabaseWorkerPool<LoginDatabaseConnection> LoginDatabaseWorkerPool;

src/common/Database/Implementation/WorldDatabase.h

@@ -18,7 +18,7 @@ public:
     WorldDatabaseConnection(ACE_Activation_Queue* q, MySQLConnectionInfo& connInfo) : MySQLConnection(q, connInfo) { }
 
     //- Loads database type specific prepared statements
-    void DoPrepareStatements();
+    void DoPrepareStatements() override;
 };
 
 typedef DatabaseWorkerPool<WorldDatabaseConnection> WorldDatabaseWorkerPool;

src/common/Database/PreparedStatement.h

@@ -144,9 +144,9 @@ class PreparedStatementTask : public SQLOperation
 public:
     PreparedStatementTask(PreparedStatement* stmt);
     PreparedStatementTask(PreparedStatement* stmt, PreparedQueryResultFuture result);
-    ~PreparedStatementTask();
+    ~PreparedStatementTask() override;
 
-    bool Execute();
+    bool Execute() override;
 
 protected:
     PreparedStatement* m_stmt;

src/common/Database/QueryHolder.h

@@ -39,7 +39,7 @@ private:
 public:
     SQLQueryHolderTask(SQLQueryHolder* holder, QueryResultHolderFuture res)
         : m_holder(holder), m_result(res) { };
-    bool Execute();
+    bool Execute() override;
 
 };
 

src/common/Database/SQLOperation.h

@@ -49,7 +49,7 @@ class SQLOperation : public ACE_Method_Request
 {
 public:
     SQLOperation(): m_conn(NULL) { }
-    virtual int call()
+    int call() override
     {
         Execute();
         return 0;

src/common/Database/Transaction.h

@@ -49,10 +49,10 @@ class TransactionTask : public SQLOperation
 
 public:
     TransactionTask(SQLTransaction trans) : m_trans(trans) { } ;
-    ~TransactionTask() { };
+    ~TransactionTask() override { };
 
 protected:
-    bool Execute();
+    bool Execute() override;
 
     SQLTransaction m_trans;
 };