refactor(Core): remove unused imports (#9767)

src/server/scripts/Commands/cs_arena.cpp

@@ -25,7 +25,6 @@ EndScriptData */
 #include "ArenaTeamMgr.h"
 #include "Chat.h"
 #include "Language.h"
-#include "ObjectMgr.h"
 #include "Player.h"
 #include "ScriptMgr.h"
 

src/server/scripts/Commands/cs_guild.cpp

@@ -26,7 +26,6 @@ EndScriptData */
 #include "Guild.h"
 #include "GuildMgr.h"
 #include "Language.h"
-#include "ObjectAccessor.h"
 #include "ScriptMgr.h"
 
 #if AC_COMPILER == AC_COMPILER_GNU

src/server/scripts/Commands/cs_message.cpp

@@ -23,7 +23,6 @@ Category: commandscripts
 EndScriptData */
 
 #include "Channel.h"
-#include "ChannelMgr.h"
 #include "Chat.h"
 #include "DBCStores.h"
 #include "DatabaseEnv.h"

src/server/scripts/Commands/cs_misc.cpp

@@ -23,7 +23,6 @@
 #include "Chat.h"
 #include "GameGraveyard.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "GroupMgr.h"
 #include "GuildMgr.h"
@@ -43,6 +42,12 @@
 #include "TargetedMovementGenerator.h"
 #include "WeatherMgr.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 #if AC_COMPILER == AC_COMPILER_GNU
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #endif

src/server/scripts/Events/hallows_end.cpp

@@ -19,7 +19,6 @@
 #include "GameObjectAI.h"
 #include "GossipDef.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "Group.h"
 #include "LFGMgr.h"
 #include "PassiveAI.h"
@@ -29,6 +28,12 @@
 #include "SpellScript.h"
 #include "TaskScheduler.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 ///////////////////////////////////////
 ////// ITEMS FIXES, BASIC STUFF
 ///////////////////////////////////////

src/server/scripts/Kalimdor/CavernsOfTime/EscapeFromDurnholdeKeep/instance_old_hillsbrad.cpp

@@ -18,7 +18,6 @@
 #include "InstanceScript.h"
 #include "Player.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "old_hillsbrad.h"
 
 const Position instancePositions[INSTANCE_POSITIONS_COUNT] =

src/server/scripts/Kalimdor/zone_silithus.cpp

@@ -28,7 +28,6 @@ quest_a_pawn_on_the_eternal_pawn
 EndContentData */
 
 #include "AccountMgr.h"
-#include "BanMgr.h"
 #include "GameObject.h"
 #include "GameObjectAI.h"
 #include "Group.h"
@@ -38,7 +37,6 @@ EndContentData */
 #include "ScriptedGossip.h"
 #include "Spell.h"
 #include "SpellInfo.h"
-#include "WorldSession.h"
 
 /*####
 # quest_a_pawn_on_the_eternal_board (Defines)

src/server/scripts/Northrend/zone_zuldrak.cpp

@@ -15,12 +15,10 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "CombatAI.h"
 #include "PassiveAI.h"
 #include "Player.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
-#include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellAuras.h"
 #include "SpellInfo.h"

src/server/scripts/Outland/HellfireCitadel/MagtheridonsLair/instance_magtheridons_lair.cpp

@@ -17,7 +17,6 @@
 
 #include "InstanceScript.h"
 #include "ScriptMgr.h"
-#include "ScriptedCreature.h"
 #include "magtheridons_lair.h"
 
 DoorData const doorData[] =

src/server/scripts/Outland/zone_blades_edge_mountains.cpp

@@ -31,7 +31,6 @@ EndContentData */
 #include "Cell.h"
 #include "CellImpl.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
@@ -40,6 +39,12 @@ EndContentData */
 #include "SpellInfo.h"
 #include "SpellScript.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 // Ours
 enum deathsdoorfell
 {

src/server/scripts/Outland/zone_shadowmoon_valley.cpp

@@ -44,7 +44,6 @@ EndContentData */
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
 #include "SpellScript.h"
-#include "WorldSession.h"
 
 // Ours
 class spell_q10612_10613_the_fel_and_the_furious : public SpellScriptLoader

src/server/scripts/Outland/zone_shattrath_city.cpp

@@ -36,7 +36,6 @@ EndContentData */
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 /*######
 ## npc_raliq_the_drunk

src/server/scripts/Outland/zone_terokkar_forest.cpp

@@ -40,7 +40,6 @@ EndContentData */
 #include "ScriptedGossip.h"
 #include "SpellAuras.h"
 #include "SpellScript.h"
-#include "WorldSession.h"
 
 // Ours
 enum fumping

src/server/scripts/Outland/zone_zangarmarsh.cpp

@@ -36,7 +36,6 @@ EndContentData */
 #include "ScriptedCreature.h"
 #include "ScriptedEscortAI.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 // Ours
 enum eNaturalist

src/server/scripts/Pet/pet_dk.cpp

@@ -24,12 +24,17 @@
 #include "CellImpl.h"
 #include "CombatAI.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
 #include "PassiveAI.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "SpellAuraEffects.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 enum DeathKnightSpells
 {
     SPELL_DK_SUMMON_GARGOYLE_1      = 49206,

src/server/scripts/Spells/spell_generic.cpp

@@ -45,6 +45,7 @@
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue
 //  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
 
 // 46642 - 5,000 Gold

src/server/scripts/Spells/spell_hunter.cpp

@@ -34,6 +34,7 @@
 // TODO: this import is not necessary for compilation and marked as unused by the IDE
 //  however, for some reasons removing it would cause a damn linking issue
 //  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
 #include "GridNotifiersImpl.h"
 
 enum HunterSpells

src/server/scripts/World/boss_emerald_dragons.cpp

@@ -16,7 +16,6 @@
  */
 
 #include "GridNotifiers.h"
-#include "ObjectMgr.h"
 #include "PassiveAI.h"
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"

src/server/scripts/World/npc_innkeeper.cpp

@@ -20,7 +20,6 @@
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 constexpr auto SPELL_TRICK = 24714;
 constexpr auto SPELL_TREAT = 24715;

src/server/scripts/World/npc_professions.cpp

@@ -27,7 +27,6 @@ EndScriptData */
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
 #include "SpellInfo.h"
-#include "WorldSession.h"
 
 /*
 A few notes for future developement:

src/server/scripts/World/npc_taxi.cpp

@@ -27,7 +27,6 @@ EndScriptData
 #include "ScriptMgr.h"
 #include "ScriptedCreature.h"
 #include "ScriptedGossip.h"
-#include "WorldSession.h"
 
 #define GOSSIP_NETHER_DRAKE     "I'm ready to fly! Take me up, dragon!"
 #define GOSSIP_IRONWING         "I'd like to take a flight around Stormwind Harbor."

src/server/scripts/World/npcs_special.cpp

@@ -36,7 +36,6 @@ npc_locksmith            75%    list of keys needs to be confirmed
 npc_firework            100%    NPC's summoned by rockets and rocket clusters, for making them cast visual
 EndContentData */
 
-#include "Cell.h"
 #include "CellImpl.h"
 #include "Chat.h"
 #include "CombatAI.h"
@@ -44,8 +43,6 @@ EndContentData */
 #include "DBCStructure.h"
 #include "GameEventMgr.h"
 #include "GridNotifiers.h"
-#include "GridNotifiersImpl.h"
-#include "Group.h"
 #include "ObjectMgr.h"
 #include "PassiveAI.h"
 #include "Pet.h"
@@ -58,6 +55,12 @@ EndContentData */
 #include "WaypointMgr.h"
 #include "World.h"
 
+// TODO: this import is not necessary for compilation and marked as unused by the IDE
+//  however, for some reasons removing it would cause a damn linking issue
+//  there is probably some underlying problem with imports which should properly addressed
+//  see: https://github.com/azerothcore/azerothcore-wotlk/issues/9766
+#include "GridNotifiersImpl.h"
+
 enum elderClearwater
 {
     EVENT_CLEARWATER_ANNOUNCE           = 1,