From c77f9b0fa3f522f81a372da0bcfe02d928ca8094 Mon Sep 17 00:00:00 2001 From: Anton Popovichenko Date: Wed, 5 Jun 2024 11:58:50 +0200 Subject: [PATCH] fix(Core/Networking): Fix crash in Proxy Protocol when removing closed sockets. (#19011) --- src/server/shared/Network/NetworkThread.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/shared/Network/NetworkThread.h b/src/server/shared/Network/NetworkThread.h index b1f18a3ae..25be6790e 100644 --- a/src/server/shared/Network/NetworkThread.h +++ b/src/server/shared/Network/NetworkThread.h @@ -173,8 +173,8 @@ protected: } } - for (int removeIndex : newSocketsToRemoveIndexes) - _newSockets.erase(_newSockets.begin() + removeIndex); + for (auto it = newSocketsToRemoveIndexes.rbegin(); it != newSocketsToRemoveIndexes.rend(); ++it) + _newSockets.erase(_newSockets.begin() + *it); } void Run()