From c3a2b83eba21d92c6fa979653757f552372c83ea Mon Sep 17 00:00:00 2001 From: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> Date: Thu, 20 Jun 2024 21:06:49 -0400 Subject: [PATCH] fix(Scripts/Midsummer): Resolve Ribbon Pole crash. (#19108) * Init. * Add todo. For you, Nyeriah. :stuck_out_tongue: --- src/server/scripts/Events/midsummer.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/server/scripts/Events/midsummer.cpp b/src/server/scripts/Events/midsummer.cpp index 33106da38..5e8925068 100644 --- a/src/server/scripts/Events/midsummer.cpp +++ b/src/server/scripts/Events/midsummer.cpp @@ -709,7 +709,8 @@ struct npc_midsummer_ribbon_pole_target : public ScriptedAI // remove non-dancing players from list std::erase_if(_dancerList, [](Player* dancer) { - return !dancer->HasAura(SPELL_RIBBON_POLE_PERIODIC_VISUAL); + if (dancer) /// @todo: replace with GUID storage rather than Player object + return !dancer->HasAura(SPELL_RIBBON_POLE_PERIODIC_VISUAL); }); }