From 8b2f411d19dc514c591d58c243aedf4363c6d842 Mon Sep 17 00:00:00 2001 From: Mike Delago <32778141+michaeldelago@users.noreply.github.com> Date: Mon, 8 Jan 2024 13:37:05 -0500 Subject: [PATCH 01/14] refactor(CI): Squash docker ci into one workflow (#17880) * refactor(CI): Squash docker ci into one workflow * fiddle with variable * use proper dockerfile target --- .../actions/docker-tag-and-build/action.yml | 6 +- .github/workflows/docker_build.yml | 110 +++++------------- 2 files changed, 35 insertions(+), 81 deletions(-) diff --git a/.github/actions/docker-tag-and-build/action.yml b/.github/actions/docker-tag-and-build/action.yml index af988bed6..436bf8fd4 100644 --- a/.github/actions/docker-tag-and-build/action.yml +++ b/.github/actions/docker-tag-and-build/action.yml @@ -13,6 +13,10 @@ inputs: description: version tag to use for docker image required: true type: string + dockerfile: + description: dockerfile to use + required: false + default: apps/docker/Dockerfile runs: using: composite steps: @@ -29,7 +33,7 @@ runs: uses: docker/build-push-action@v5 with: context: ${{ github.workspace }} - file: apps/docker/Dockerfile + file: ${{ inputs.dockerfile }} push: ${{ inputs.push }} tags: ${{ steps.meta.outputs.tags }} target: ${{ inputs.component-name }} diff --git a/.github/workflows/docker_build.yml b/.github/workflows/docker_build.yml index ffc3104a7..0f23f9ad7 100644 --- a/.github/workflows/docker_build.yml +++ b/.github/workflows/docker_build.yml @@ -14,76 +14,19 @@ concurrency: group: ${{ github.head_ref }} || concat(${{ github.ref }}, ${{ github.workflow }}) cancel-in-progress: true +env: + COMPOSE_DOCKER_CLI_BUILD: 1 + DOCKER_BUILDKIT: 1 + RUNNING_ON_PRIMARY_BRANCH: | + ${{ (github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master') && 'true' || 'false' }} + jobs: - docker-build-n-deploy-dev: + build-containers: runs-on: "ubuntu-latest" if: | github.repository == 'azerothcore/azerothcore-wotlk' && !github.event.pull_request.draft && (github.ref_name == 'master' || contains(github.event.pull_request.labels.*.name, 'run-build') || github.event.label.name == 'run-build') - env: - COMPOSE_DOCKER_CLI_BUILD: 1 - DOCKER_BUILDKIT: 1 - - steps: - - name: Free up disk space - run: | - sudo rm -rf /usr/local/lib/android - sudo rm -rf /usr/share/dotnet - sudo rm -rf /opt/ghc - sudo rm -rf "$AGENT_TOOLSDIRECTORY" - - - uses: actions/checkout@v4 - - - name: Login to Docker Hub - if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' - uses: docker/login-action@v1 - with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} - - - name: Get version - id: version - run: | - output=$(./acore.sh version | grep "AzerothCore Rev. ") - version=${output#"AzerothCore Rev. "} - echo "version=$version" >> $GITHUB_OUTPUT - - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v3 - - - name: Docker meta - id: meta - uses: docker/metadata-action@v5 - with: - images: acore/ac-wotlk-dev-server - tags: | - type=raw,value=${{ steps.version.outputs.version }} - type=ref,event=branch - - - name: Build and push - uses: docker/build-push-action@v5 - with: - context: ${{ github.workspace }} - file: apps/docker/Dockerfile.dev-server - push: ${{ github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' }} - tags: ${{ steps.meta.outputs.tags }} - build-args: | - USER_ID=1000 - GROUP_ID=1000 - DOCKER_USER=acore - - # TODO: rename this job - docker-build-n-deploy-prod: - runs-on: "ubuntu-latest" - if: | - github.repository == 'azerothcore/azerothcore-wotlk' - && !github.event.pull_request.draft - && (github.ref_name == 'master' || contains(github.event.pull_request.labels.*.name, 'run-build') || github.event.label.name == 'run-build') - env: - COMPOSE_DOCKER_CLI_BUILD: 1 - DOCKER_BUILDKIT: 1 - steps: - name: Free up disk space run: | @@ -100,14 +43,14 @@ jobs: # If you're wanting containers without mod-eluna, the best solution is to # build them locally (such as with `docker compose build`) - name: Download Eluna - if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' + if: env.RUNNING_ON_PRIMARY_BRANCH == 'true' uses: actions/checkout@v4 with: repository: azerothcore/mod-eluna path: modules/mod-eluna - name: Login to Docker Hub - if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' + if: env.RUNNING_ON_PRIMARY_BRANCH == 'true' uses: docker/login-action@v1 with: username: ${{ secrets.DOCKERHUB_USERNAME }} @@ -116,8 +59,7 @@ jobs: - name: Get version id: version run: | - output=$(./acore.sh version | grep "AzerothCore Rev. ") - version=${output#"AzerothCore Rev. "} + version="$(jq -r '.version' acore.json)" echo "version=$version" >> $GITHUB_OUTPUT - name: Set up Docker Buildx @@ -128,45 +70,53 @@ jobs: with: component-name: worldserver version: ${{ steps.version.outputs.version }} - push: ${{ github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' }} + push: ${{ env.RUNNING_ON_PRIMARY_BRANCH }} - name: build authserver uses: ./.github/actions/docker-tag-and-build with: component-name: authserver version: ${{ steps.version.outputs.version }} - push: ${{ github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' }} + push: ${{ env.RUNNING_ON_PRIMARY_BRANCH }} - name: build db-import uses: ./.github/actions/docker-tag-and-build with: component-name: db-import version: ${{ steps.version.outputs.version }} - push: ${{ github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' }} + push: ${{ env.RUNNING_ON_PRIMARY_BRANCH }} - name: build client-data uses: ./.github/actions/docker-tag-and-build with: component-name: client-data version: ${{ steps.version.outputs.version }} - push: ${{ github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' }} + push: ${{ env.RUNNING_ON_PRIMARY_BRANCH }} - name: build tools uses: ./.github/actions/docker-tag-and-build with: component-name: tools version: ${{ steps.version.outputs.version }} - push: ${{ github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' }} + push: ${{ env.RUNNING_ON_PRIMARY_BRANCH }} - dispatch-acore-docker: - needs: [ docker-build-n-deploy-prod , docker-build-n-deploy-dev] - runs-on: ubuntu-latest - steps: - - name: Repository Dispatch - if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' + - name: build dev-server + uses: ./.github/actions/docker-tag-and-build + with: + component-name: dev + version: ${{ steps.version.outputs.version }} + push: ${{ env.RUNNING_ON_PRIMARY_BRANCH }} + dockerfile: apps/docker/Dockerfile.dev-server + + - name: Trigger acore-docker CI + if: env.RUNNING_ON_PRIMARY_BRANCH == 'true' uses: peter-evans/repository-dispatch@v2 with: token: ${{ secrets.ACORE_DOCKER_REPO_ACCESS_TOKEN }} repository: azerothcore/acore-docker event-type: azerothcore-new-images - client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}' + client-payload: > + { + "ref": "${{ github.ref }}", + "sha": "${{ github.sha }}" + } From 9c95ac6d2eb6dc9bc368141a36579c9c021c5323 Mon Sep 17 00:00:00 2001 From: daobashun <49193927+fangshun2004@users.noreply.github.com> Date: Tue, 9 Jan 2024 02:41:26 +0800 Subject: [PATCH 02/14] fix(Scripts/PilgrimsBounty): Correct text for Turkey Tracker (#18123) * closes https://github.com/chromiecraft/chromiecraft/issues/6356 --- src/server/scripts/Events/pilgrims_bounty.cpp | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/server/scripts/Events/pilgrims_bounty.cpp b/src/server/scripts/Events/pilgrims_bounty.cpp index 0327a3d40..e3386ca53 100644 --- a/src/server/scripts/Events/pilgrims_bounty.cpp +++ b/src/server/scripts/Events/pilgrims_bounty.cpp @@ -515,7 +515,15 @@ class spell_pilgrims_bounty_feast_on_generic : public SpellScript enum tTracker { SPELL_TURKEY_TRACKER = 62014, - SPELL_ACHI_TURKINATOR_CREDIT = 62021, + SPELL_ACHI_TURKINATOR_CREDIT = 62021 +}; + +enum Say +{ + SAY_TURKEY_HUNTER = 33163, + SAY_TURKEY_DOMINATION = 33164, + SAY_TURKEY_SLAUGHTER = 33165, + SAY_TURKEY_TRIUMPH = 33167 }; class spell_pilgrims_bounty_turkey_tracker : public SpellScript @@ -532,16 +540,16 @@ class spell_pilgrims_bounty_turkey_tracker : public SpellScript switch (stackAmount) { case 10: - target->TextEmote("Turkey Hunter!", target, true); + target->Whisper(SAY_TURKEY_HUNTER, target, true); break; case 20: - target->TextEmote("Turkey Domination!", target, true); + target->Whisper(SAY_TURKEY_DOMINATION, target, true); break; case 30: - target->TextEmote("Turkey Slaughter!", target, true); + target->Whisper(SAY_TURKEY_SLAUGHTER, target, true); break; case 40: - target->TextEmote("TURKEY TRIUMPH!", target, true); + target->Whisper(SAY_TURKEY_TRIUMPH, target, true); target->CastSpell(target, SPELL_ACHI_TURKINATOR_CREDIT, true); aurEff->GetBase()->Remove(); break; From db4a6bab3471d7f7721168541bcaec45d08a7e01 Mon Sep 17 00:00:00 2001 From: Grimgravy Date: Mon, 8 Jan 2024 15:46:05 -0300 Subject: [PATCH 03/14] fix(Scripts/Quest): improve Securing the Celestial Ridge (#17847) * fix(Scripts/Quest): improve Securing the Celestial Ridge * update --- .../rev_1700913491921182500.sql | 9 ++++++ .../scripts/Outland/zone_netherstorm.cpp | 32 +++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1700913491921182500.sql diff --git a/data/sql/updates/pending_db_world/rev_1700913491921182500.sql b/data/sql/updates/pending_db_world/rev_1700913491921182500.sql new file mode 100644 index 000000000..72d7db1a2 --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1700913491921182500.sql @@ -0,0 +1,9 @@ +-- +DELETE FROM `smart_scripts` WHERE (`source_type` = 0 AND `entryorguid` = 18544); +INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES +(18544, 0, 0, 0, 1, 0, 100, 257, 0, 0, 0, 0, 0, 69, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 0, 3832.74, 1448.12, -138.4, 0, 'Veraku - Out of Combat - Move To Position'), +(18544, 0, 1, 0, 54, 0, 100, 0, 0, 0, 0, 0, 0, 49, 0, 0, 0, 0, 0, 0, 21, 100, 0, 0, 0, 0, 0, 0, 0, 'Veraku - On Just Summoned - Start Attacking'); + +DELETE FROM `spell_script_names` WHERE `ScriptName`='spell_challenge_veraku'; +INSERT INTO `spell_script_names` (`spell_id`,`ScriptName`) VALUES +(34895, 'spell_challenge_veraku'); diff --git a/src/server/scripts/Outland/zone_netherstorm.cpp b/src/server/scripts/Outland/zone_netherstorm.cpp index bdaa848d8..e61baf0ff 100644 --- a/src/server/scripts/Outland/zone_netherstorm.cpp +++ b/src/server/scripts/Outland/zone_netherstorm.cpp @@ -950,6 +950,37 @@ class spell_q10190_battery_recharging_blaster_aura : public AuraScript } }; +enum Veraku +{ + NPC_VERAKU = 18544, + SPELL_CHALLENGE_VERAKU = 34895 +}; + +class spell_challenge_veraku : public SpellScript +{ +public: + PrepareSpellScript(spell_challenge_veraku); + + bool Validate(SpellInfo const* /*SpellInfo*/) override + { + return ValidateSpellInfo({ SPELL_CHALLENGE_VERAKU }); + } + + SpellCastResult CheckRequirement() + { + if (Unit* caster = GetCaster()) + if (Creature* veraku = caster->FindNearestCreature(NPC_VERAKU, 100.0f)) + if (!veraku->HasAura(SPELL_CHALLENGE_VERAKU)) + return SPELL_FAILED_CASTER_AURASTATE; + return SPELL_CAST_OK; + } + + void Register() override + { + OnCheckCast += SpellCheckCastFn(spell_challenge_veraku::CheckRequirement); + } +}; + void AddSC_netherstorm() { // Ours @@ -962,5 +993,6 @@ void AddSC_netherstorm() new npc_bessy(); new npc_maxx_a_million_escort(); RegisterSpellAndAuraScriptPair(spell_q10190_battery_recharging_blaster, spell_q10190_battery_recharging_blaster_aura); + RegisterSpellScript(spell_challenge_veraku); } From 508b1658fcbc4e625f939da75963480be2354430 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 8 Jan 2024 18:47:53 +0000 Subject: [PATCH 04/14] chore(DB): import pending files Referenced commit(s): db4a6bab3471d7f7721168541bcaec45d08a7e01 --- .../rev_1700913491921182500.sql => db_world/2024_01_08_02.sql} | 1 + 1 file changed, 1 insertion(+) rename data/sql/updates/{pending_db_world/rev_1700913491921182500.sql => db_world/2024_01_08_02.sql} (95%) diff --git a/data/sql/updates/pending_db_world/rev_1700913491921182500.sql b/data/sql/updates/db_world/2024_01_08_02.sql similarity index 95% rename from data/sql/updates/pending_db_world/rev_1700913491921182500.sql rename to data/sql/updates/db_world/2024_01_08_02.sql index 72d7db1a2..308ed2131 100644 --- a/data/sql/updates/pending_db_world/rev_1700913491921182500.sql +++ b/data/sql/updates/db_world/2024_01_08_02.sql @@ -1,3 +1,4 @@ +-- DB update 2024_01_08_01 -> 2024_01_08_02 -- DELETE FROM `smart_scripts` WHERE (`source_type` = 0 AND `entryorguid` = 18544); INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES From 48283c2b14ee10f23d23d221190ebd012078a743 Mon Sep 17 00:00:00 2001 From: sudlud Date: Mon, 8 Jan 2024 19:58:20 +0100 Subject: [PATCH 05/14] fix(DB/Creature): Orgrimmar Grunt directions for barber shop (#18131) --- data/sql/updates/pending_db_world/rev_1704657014016572900.sql | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1704657014016572900.sql diff --git a/data/sql/updates/pending_db_world/rev_1704657014016572900.sql b/data/sql/updates/pending_db_world/rev_1704657014016572900.sql new file mode 100644 index 000000000..ae570f1a6 --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1704657014016572900.sql @@ -0,0 +1,2 @@ +-- Fix Orgrimmar Grunt directions for barber shop +UPDATE `npc_text` SET `BroadcastTextID0` = 0 WHERE `ID` = 13889; From f2cf359045e89860de7fd7866dfd3d2356a48c9c Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Mon, 8 Jan 2024 18:59:21 +0000 Subject: [PATCH 06/14] chore(DB): import pending files Referenced commit(s): 48283c2b14ee10f23d23d221190ebd012078a743 --- .../rev_1704657014016572900.sql => db_world/2024_01_08_03.sql} | 1 + 1 file changed, 1 insertion(+) rename data/sql/updates/{pending_db_world/rev_1704657014016572900.sql => db_world/2024_01_08_03.sql} (72%) diff --git a/data/sql/updates/pending_db_world/rev_1704657014016572900.sql b/data/sql/updates/db_world/2024_01_08_03.sql similarity index 72% rename from data/sql/updates/pending_db_world/rev_1704657014016572900.sql rename to data/sql/updates/db_world/2024_01_08_03.sql index ae570f1a6..d45244b9a 100644 --- a/data/sql/updates/pending_db_world/rev_1704657014016572900.sql +++ b/data/sql/updates/db_world/2024_01_08_03.sql @@ -1,2 +1,3 @@ +-- DB update 2024_01_08_02 -> 2024_01_08_03 -- Fix Orgrimmar Grunt directions for barber shop UPDATE `npc_text` SET `BroadcastTextID0` = 0 WHERE `ID` = 13889; From fdbde0b866300f5647a0df0211b7cfda2e6d66b5 Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Mon, 8 Jan 2024 20:10:25 +0100 Subject: [PATCH 07/14] fix(CI): Probably fix vanishing CIs from PRs (#18124) * Update core-build-nopch.yml * Update core-build-pch.yml * Update core-build-nopch.yml --- .github/workflows/core-build-nopch.yml | 4 ++-- .github/workflows/core-build-pch.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/core-build-nopch.yml b/.github/workflows/core-build-nopch.yml index 2c29bd391..1e31fabdf 100644 --- a/.github/workflows/core-build-nopch.yml +++ b/.github/workflows/core-build-nopch.yml @@ -4,7 +4,7 @@ on: branches: - 'master' pull_request: - types: ['labeled', 'opened', 'synchronize', 'reopened'] + types: ['opened', 'synchronize', 'reopened'] concurrency: group: ${{ github.head_ref }} || concat(${{ github.ref }}, ${{ github.workflow }}) @@ -25,7 +25,7 @@ jobs: name: ${{ matrix.os }}-${{ matrix.compiler }}-nopch env: COMPILER: ${{ matrix.compiler }} - if: github.repository == 'azerothcore/azerothcore-wotlk' && !github.event.pull_request.draft + if: github.repository == 'azerothcore/azerothcore-wotlk' steps: - uses: actions/checkout@v4 - name: Cache diff --git a/.github/workflows/core-build-pch.yml b/.github/workflows/core-build-pch.yml index 7420d2b17..7535ab5d5 100644 --- a/.github/workflows/core-build-pch.yml +++ b/.github/workflows/core-build-pch.yml @@ -4,7 +4,7 @@ on: branches: - 'master' pull_request: - types: ['labeled', 'opened', 'synchronize', 'reopened'] + types: ['opened', 'synchronize', 'reopened'] concurrency: group: ${{ github.head_ref }} || concat(${{ github.ref }}, ${{ github.workflow }}) From 7ec2585cc80b08db87441ac374cefec14a42c56e Mon Sep 17 00:00:00 2001 From: Mike Delago <32778141+michaeldelago@users.noreply.github.com> Date: Wed, 10 Jan 2024 07:53:45 -0500 Subject: [PATCH 08/14] fix(CI): revert `if` in job conditionals on docker build (#18147) Don't use env in step.if --- .github/workflows/docker_build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/docker_build.yml b/.github/workflows/docker_build.yml index 0f23f9ad7..141d34036 100644 --- a/.github/workflows/docker_build.yml +++ b/.github/workflows/docker_build.yml @@ -43,14 +43,14 @@ jobs: # If you're wanting containers without mod-eluna, the best solution is to # build them locally (such as with `docker compose build`) - name: Download Eluna - if: env.RUNNING_ON_PRIMARY_BRANCH == 'true' + if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' uses: actions/checkout@v4 with: repository: azerothcore/mod-eluna path: modules/mod-eluna - name: Login to Docker Hub - if: env.RUNNING_ON_PRIMARY_BRANCH == 'true' + if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' uses: docker/login-action@v1 with: username: ${{ secrets.DOCKERHUB_USERNAME }} @@ -109,7 +109,7 @@ jobs: dockerfile: apps/docker/Dockerfile.dev-server - name: Trigger acore-docker CI - if: env.RUNNING_ON_PRIMARY_BRANCH == 'true' + if: github.repository == 'azerothcore/azerothcore-wotlk' && github.ref_name == 'master' uses: peter-evans/repository-dispatch@v2 with: token: ${{ secrets.ACORE_DOCKER_REPO_ACCESS_TOKEN }} From 96d8d1d89afff5ba6deedc390cd9bedbaf7ac141 Mon Sep 17 00:00:00 2001 From: sudlud Date: Thu, 11 Jan 2024 15:15:41 +0100 Subject: [PATCH 09/14] fix(Core/Creature): Reduce z offset for automated spawn correction (#18153) - this is necessary to correctly spawn creatures within small defines - 0.42f is as good as 1.0f to detect and correct reasonable z errors in DB spawn data --- src/server/game/Entities/Creature/Creature.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/game/Entities/Creature/Creature.cpp b/src/server/game/Entities/Creature/Creature.cpp index 105723e48..93f03ea4b 100644 --- a/src/server/game/Entities/Creature/Creature.cpp +++ b/src/server/game/Entities/Creature/Creature.cpp @@ -1669,8 +1669,8 @@ bool Creature::LoadCreatureFromDB(ObjectGuid::LowType spawnId, Map* map, bool ad // xinef: fix from db if ((addToMap || gridLoad) && !data->overwrittenZ) { - float tz = map->GetHeight(data->posX, data->posY, data->posZ + 1.0f, true); - if (tz >= data->posZ && tz - data->posZ <= 1.0f) + float tz = map->GetHeight(data->posX, data->posY, data->posZ + 0.42f, true); + if (tz >= data->posZ && tz - data->posZ <= 0.42f) const_cast(data)->posZ = tz + 0.1f; const_cast(data)->overwrittenZ = true; From 3a07dffe9df19937d6d80c81fabb2232ef99afa2 Mon Sep 17 00:00:00 2001 From: sudlud Date: Thu, 11 Jan 2024 23:29:27 +0100 Subject: [PATCH 10/14] fix(DB/Creature): Sniffed Values for 28344 'Blazzle' (#18154) --- .../sql/updates/pending_db_world/rev_1705005159549564700.sql | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 data/sql/updates/pending_db_world/rev_1705005159549564700.sql diff --git a/data/sql/updates/pending_db_world/rev_1705005159549564700.sql b/data/sql/updates/pending_db_world/rev_1705005159549564700.sql new file mode 100644 index 000000000..da1e7edd6 --- /dev/null +++ b/data/sql/updates/pending_db_world/rev_1705005159549564700.sql @@ -0,0 +1,5 @@ +-- Update creature 28344 'Blazzle' with sniffed values +-- new spawns +DELETE FROM `creature` WHERE (`id1` = 28344) AND (`guid` IN (116)); +INSERT INTO `creature` (`guid`, `id1`, `map`, `spawnMask`, `phaseMask`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `wander_distance`, `MovementType`, `npcflag`, `unit_flags`, `dynamicflags`, `ScriptName`, `VerifiedBuild`, `CreateObject`, `Comment`) VALUES +(116, 28344, 530, 1, 1, 0, 3063.40625, 3677.5703125, 142.7606658935546875, 4.276056766510009765, 120, 0, 0, 0, 0, 0, "", 50063, 1, NULL); From b13596a62525ec0a3574dc190c66c8722e8113f2 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Thu, 11 Jan 2024 22:30:46 +0000 Subject: [PATCH 11/14] chore(DB): import pending files Referenced commit(s): 3a07dffe9df19937d6d80c81fabb2232ef99afa2 --- .../rev_1705005159549564700.sql => db_world/2024_01_11_00.sql} | 1 + 1 file changed, 1 insertion(+) rename data/sql/updates/{pending_db_world/rev_1705005159549564700.sql => db_world/2024_01_11_00.sql} (92%) diff --git a/data/sql/updates/pending_db_world/rev_1705005159549564700.sql b/data/sql/updates/db_world/2024_01_11_00.sql similarity index 92% rename from data/sql/updates/pending_db_world/rev_1705005159549564700.sql rename to data/sql/updates/db_world/2024_01_11_00.sql index da1e7edd6..75864296b 100644 --- a/data/sql/updates/pending_db_world/rev_1705005159549564700.sql +++ b/data/sql/updates/db_world/2024_01_11_00.sql @@ -1,3 +1,4 @@ +-- DB update 2024_01_08_03 -> 2024_01_11_00 -- Update creature 28344 'Blazzle' with sniffed values -- new spawns DELETE FROM `creature` WHERE (`id1` = 28344) AND (`guid` IN (116)); From c863a8cfb59ed17692f9da2956b85a53ecc09ed7 Mon Sep 17 00:00:00 2001 From: Andrew <47818697+Nyeriah@users.noreply.github.com> Date: Fri, 12 Jan 2024 02:28:32 -0300 Subject: [PATCH 12/14] fix(Scripts/Rogue): Fix Vanish not granting stealth (#18155) --- src/server/scripts/Spells/spell_rogue.cpp | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/server/scripts/Spells/spell_rogue.cpp b/src/server/scripts/Spells/spell_rogue.cpp index f9a469025..5fb73879d 100644 --- a/src/server/scripts/Spells/spell_rogue.cpp +++ b/src/server/scripts/Spells/spell_rogue.cpp @@ -695,7 +695,8 @@ class spell_rog_pickpocket : public SpellScript enum vanish { - SPELL_PARALYZE = 38132, + SPELL_STEALTH = 1784, + SPELL_PARALYZE = 38132, SPELL_CLEAN_ESCAPE_AURA = 23582, SPELL_CLEAN_ESCAPE_HEAL = 23583 }; @@ -742,8 +743,22 @@ class spell_rog_vanish : public SpellScript void HandleEffect(SpellEffIndex /*effIndex*/) { - if (GetCaster() && GetCaster()->HasAura(SPELL_CLEAN_ESCAPE_AURA)) - GetCaster()->CastSpell(GetCaster(), SPELL_CLEAN_ESCAPE_HEAL, true); + if (GetCaster()) + { + GetCaster()->RemoveAurasByType(SPELL_AURA_MOD_STALKED); + + if (!GetCaster()->HasAura(SPELL_STEALTH)) + { + // Remove stealth cooldown if needed. + if (GetCaster()->IsPlayer() && GetCaster()->HasSpellCooldown(SPELL_STEALTH)) + GetCaster()->ToPlayer()->RemoveSpellCooldown(SPELL_STEALTH); + + GetCaster()->CastSpell(GetCaster(), SPELL_STEALTH, true); + } + + if (GetCaster()->HasAura(SPELL_CLEAN_ESCAPE_AURA)) + GetCaster()->CastSpell(GetCaster(), SPELL_CLEAN_ESCAPE_HEAL, true); + } } void Register() override From a1891d8d8f8acd42dc1bd0c55ef4be3a8763cac9 Mon Sep 17 00:00:00 2001 From: Angelo Venturini Date: Sat, 13 Jan 2024 05:45:43 -0300 Subject: [PATCH 13/14] fix(Core/ThreatMgr): Remove temp threat on resetting threat list (#18162) --- src/server/game/Combat/ThreatMgr.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/server/game/Combat/ThreatMgr.cpp b/src/server/game/Combat/ThreatMgr.cpp index c1041da49..21b3741d8 100644 --- a/src/server/game/Combat/ThreatMgr.cpp +++ b/src/server/game/Combat/ThreatMgr.cpp @@ -654,8 +654,12 @@ void ThreatMgr::ResetAllThreat() if (threatList.empty()) return; - for (ThreatContainer::StorageType::iterator itr = threatList.begin(); itr != threatList.end(); ++itr) - (*itr)->SetThreat(0); + for (HostileReference* ref : threatList) + { + // Reset temp threat before setting threat back to 0. + ref->resetTempThreat(); + ref->SetThreat(0.f); + } setDirty(true); } From 4321b8a4dee98fce5f7b66dae43afa44b5c22a12 Mon Sep 17 00:00:00 2001 From: Nathan Handley Date: Sat, 13 Jan 2024 17:10:49 -0600 Subject: [PATCH 14/14] feat(Core/Scripting): Implement new hook OnBeforePlayerLogout() (#18163) * new hook OnPlayerPreLogout * Changed PreLogout to BeforeLogout per review * Renamed OnPlayerBeforeLogout to OnBeforePlayerLogout per review --------- Co-authored-by: NathanHandley --- src/server/game/Scripting/ScriptDefines/PlayerScript.cpp | 8 ++++++++ src/server/game/Scripting/ScriptDefines/PlayerScript.h | 3 +++ src/server/game/Scripting/ScriptMgr.h | 1 + src/server/game/Server/WorldSession.cpp | 3 +++ 4 files changed, 15 insertions(+) diff --git a/src/server/game/Scripting/ScriptDefines/PlayerScript.cpp b/src/server/game/Scripting/ScriptDefines/PlayerScript.cpp index 8060d5e32..ed2465695 100644 --- a/src/server/game/Scripting/ScriptDefines/PlayerScript.cpp +++ b/src/server/game/Scripting/ScriptDefines/PlayerScript.cpp @@ -361,6 +361,14 @@ void ScriptMgr::OnPlayerLoadFromDB(Player* player) }); } +void ScriptMgr::OnBeforePlayerLogout(Player* player) +{ + ExecuteScript([&](PlayerScript* script) + { + script->OnBeforeLogout(player); + }); +} + void ScriptMgr::OnPlayerLogout(Player* player) { ExecuteScript([&](PlayerScript* script) diff --git a/src/server/game/Scripting/ScriptDefines/PlayerScript.h b/src/server/game/Scripting/ScriptDefines/PlayerScript.h index 7bab66fe4..788474390 100644 --- a/src/server/game/Scripting/ScriptDefines/PlayerScript.h +++ b/src/server/game/Scripting/ScriptDefines/PlayerScript.h @@ -132,6 +132,9 @@ public: // Called when a player logs in. virtual void OnLogin(Player* /*player*/) { } + // Called before the player is logged out + virtual void OnBeforeLogout(Player* /*player*/) { } + // Called when a player logs out. virtual void OnLogout(Player* /*player*/) { } diff --git a/src/server/game/Scripting/ScriptMgr.h b/src/server/game/Scripting/ScriptMgr.h index 6499e177b..c39c10980 100644 --- a/src/server/game/Scripting/ScriptMgr.h +++ b/src/server/game/Scripting/ScriptMgr.h @@ -329,6 +329,7 @@ public: /* PlayerScript */ void OnPlayerSpellCast(Player* player, Spell* spell, bool skipCheck); void OnPlayerLogin(Player* player); void OnPlayerLoadFromDB(Player* player); + void OnBeforePlayerLogout(Player* player); void OnPlayerLogout(Player* player); void OnPlayerCreate(Player* player); void OnPlayerSave(Player* player); diff --git a/src/server/game/Server/WorldSession.cpp b/src/server/game/Server/WorldSession.cpp index a3a94d7ac..c7fc5abf8 100644 --- a/src/server/game/Server/WorldSession.cpp +++ b/src/server/game/Server/WorldSession.cpp @@ -579,6 +579,9 @@ void WorldSession::LogoutPlayer(bool save) if (_player) { + //! Call script hook before other logout events + sScriptMgr->OnBeforePlayerLogout(_player); + if (ObjectGuid lguid = _player->GetLootGUID()) DoLootRelease(lguid);