fix(Core/Misc): all GCC warnings (#3457)

This commit is contained in:
Francesco Borzì
2020-09-14 17:31:12 +02:00
committed by GitHub
parent 80b149b218
commit b61ae8abcd
34 changed files with 157 additions and 75 deletions

View File

@@ -29,10 +29,11 @@ void LfgGroupData::SetState(LfgState state)
case LFG_STATE_NONE:
m_Dungeon = 0;
m_KicksLeft = LFG_GROUP_MAX_KICKS;
[[fallthrough]];
case LFG_STATE_FINISHED_DUNGEON:
case LFG_STATE_DUNGEON:
m_OldState = state;
// No break on purpose
[[fallthrough]];
default:
m_State = state;
}

View File

@@ -524,19 +524,28 @@ void LFGMgr::JoinLfg(Player* player, uint8 roles, LfgDungeonSet& dungeons, const
{
case LFG_TYPE_RANDOM:
if (dungeons.size() > 1) // Only allow 1 random dungeon
{
joinData.result = LFG_JOIN_DUNGEON_INVALID;
}
else
{
rDungeonId = (*dungeons.begin());
}
// No break on purpose (Random can only be dungeon or heroic dungeon)
[[fallthrough]];
case LFG_TYPE_HEROIC:
case LFG_TYPE_DUNGEON:
if (isRaid)
{
joinData.result = LFG_JOIN_MIXED_RAID_DUNGEON;
}
isDungeon = true;
break;
case LFG_TYPE_RAID:
if (isDungeon)
{
joinData.result = LFG_JOIN_MIXED_RAID_DUNGEON;
}
isRaid = true;
break;
default:

View File

@@ -30,10 +30,10 @@ void LfgPlayerData::SetState(LfgState state)
m_Roles = 0;
m_SelectedDungeons.clear();
m_Comment = "";
// No break on purpose
[[fallthrough]];
case LFG_STATE_DUNGEON:
m_OldState = state;
// No break on purpose
[[fallthrough]];
default:
m_State = state;
}