refactor(Core): apply clang-tidy modernize-pass-by-value (#3823)

This commit is contained in:
Francesco Borzì
2020-12-13 01:11:15 +01:00
committed by GitHub
parent 282966c117
commit adf436c937
10 changed files with 36 additions and 24 deletions

View File

@@ -7,10 +7,12 @@
#define _CRT_SECURE_NO_DEPRECATE
#include "dbcfile.h"
#include "mpq_libmpq04.h"
DBCFile::DBCFile(const std::string& filename):
filename(filename), recordSize(0), recordCount(0), fieldCount(0), stringSize(0), data(nullptr), stringTable(nullptr)
#include "mpq_libmpq04.h"
#include <utility>
DBCFile::DBCFile(std::string filename):
filename(std::move(filename)), recordSize(0), recordCount(0), fieldCount(0), stringSize(0), data(nullptr), stringTable(nullptr)
{
}

View File

@@ -8,11 +8,12 @@
#define DBCFILE_H
#include <cassert>
#include <string>
#include <utility>
class DBCFile
{
public:
DBCFile(const std::string& filename);
DBCFile(std::string filename);
~DBCFile();
// Open database. It must be openened before it can be used.
@@ -22,7 +23,7 @@ public:
class Exception
{
public:
Exception(const std::string& message): message(message)
Exception(std::string message): message(std::move(message))
{ }
virtual ~Exception() = default;
const std::string& getMessage() {return message;}