From ac8dfeef4f111def53f7e9e3a924c641c644df4b Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Fri, 6 Aug 2021 09:32:51 +0200 Subject: [PATCH] fix(Core/SOAP): mem leak and new/free mismatch (#7181) Co-Authored-By: Giacomo Pozzoni --- src/server/worldserver/ACSoap/ACSoap.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/server/worldserver/ACSoap/ACSoap.cpp b/src/server/worldserver/ACSoap/ACSoap.cpp index bc85a0dd9..38cdf1ddb 100644 --- a/src/server/worldserver/ACSoap/ACSoap.cpp +++ b/src/server/worldserver/ACSoap/ACSoap.cpp @@ -42,6 +42,8 @@ void ACSoapThread(const std::string& host, uint16 port) process_message(thread_soap); } + soap_destroy(&soap); + soap_end(&soap); soap_done(&soap); } @@ -52,8 +54,7 @@ void process_message(struct soap* soap_message) soap_serve(soap_message); soap_destroy(soap_message); // dealloc C++ data soap_end(soap_message); // dealloc data and clean up - soap_done(soap_message); // detach soap struct - free(soap_message); + soap_free(soap_message); // detach soap struct and fre up the memory } /*