From 7dec2e59a68a2f88cb8f658b528134d7422805fa Mon Sep 17 00:00:00 2001 From: sh3rp <6485321+sh3rp@users.noreply.github.com> Date: Sat, 21 Jan 2023 12:12:26 -0500 Subject: [PATCH] =?UTF-8?q?fix(DB/Gameobject):=20Fixed=20overlapping=20Mil?= =?UTF-8?q?k=20Barrel=20/=20Food=20Crates=20in=20St=E2=80=A6=20(#14730)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix(DB/Gameobject): Fixed overlapping Milk Barrel / Food Crates in Stormwind City ## Changes Proposed: Add Water Barrel and Food Create to a pool. ## Issues Addressed: - Closes https://github.com/azerothcore/azerothcore-wotlk/issues/11776 ## SOURCE: n/a ## Tests Performed: Logged in, ported to object, verified only 1 object spawns at a time. Verified alternating spawns of the object. ## How to Test the Changes: 1. Login 2. .go gameobject 31401 || .go gameobject 33607 3. Verify only 1 object has spawned. 4. Open object and take items, causing despawn. 5. Wait for respawn of another object. 6. Respawn of other object in pool. 7. Repeat 3-5. ## Known Issues and TODO List: n/a ## How to Test AzerothCore PRs When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**. You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here: http://www.azerothcore.org/wiki/How-to-test-a-PR **REMEMBER**: when testing a PR that changes something **generic** (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but **especially** check that the PR does not cause any regression (i.e. introducing new bugs). **For example**: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but **we should test Y and Z as well**. * Update data/sql/updates/pending_db_world/fix-11776.sql added space for readability Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com> Co-authored-by: Gultask <100873791+Gultask@users.noreply.github.com> --- data/sql/updates/pending_db_world/fix-11776.sql | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 data/sql/updates/pending_db_world/fix-11776.sql diff --git a/data/sql/updates/pending_db_world/fix-11776.sql b/data/sql/updates/pending_db_world/fix-11776.sql new file mode 100644 index 000000000..bc2301247 --- /dev/null +++ b/data/sql/updates/pending_db_world/fix-11776.sql @@ -0,0 +1,13 @@ + +SET @POOL = 60011; +SET @MILKBARREL = 33607; +SET @FOODCRATE = 31401; + +DELETE FROM `pool_template` WHERE `entry`=@POOL; +INSERT INTO `pool_template` (`entry`, `max_limit`, `description`) VALUES +(@POOL, 1, 'Milk Barrel (33607) / Food Crate (31401) - Stormwind City'); + +DELETE FROM `pool_gameobject` WHERE `pool_entry`=@POOL; +INSERT INTO `pool_gameobject` (`guid`, `pool_entry`, `chance`, `description`) VALUES +(@MILKBARREL, @POOL, 0, 'Milk Barrel (33607) - Stormwind City'), +(@FOODCRATE, @POOL, 0, 'Food Crate (31401) - Stormwind City');