Merge branch 'master' into Playerbot

src/common/DataStores/DBCFileLoader.cpp

@@ -17,7 +17,6 @@
 
 #include "DBCFileLoader.h"
 #include "Errors.h"
-#include <stdio.h>
 #include <string.h>
 
 DBCFileLoader::DBCFileLoader() : recordSize(0), recordCount(0), fieldCount(0), stringSize(0), fieldsOffset(nullptr), data(nullptr), stringTable(nullptr) { }

src/common/Dynamic/TypeContainer.h

@@ -25,7 +25,6 @@
 
 #include "Dynamic/TypeList.h"
 #include "GridRefMgr.h"
-#include <map>
 #include <unordered_map>
 
 /*

src/common/Logging/AppenderFile.h

@@ -19,7 +19,7 @@
 #define APPENDERFILE_H
 
 #include "Appender.h"
-#include <atomic>
+#include <atomic> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 #include <vector>
 
 class AppenderFile : public Appender

src/common/Logging/enuminfo_LogCommon.cpp

@@ -19,6 +19,7 @@
 #include "Define.h"
 #include "SmartEnum.h"
 #include <stdexcept>
+#include <vector>
 
 namespace Acore::Impl::EnumUtilsImpl
 {

src/common/Metric/Metric.h

@@ -22,7 +22,7 @@
 #include "Duration.h"
 #include "MPSCQueue.h"
 #include <functional>
-#include <memory>
+#include <memory> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 #include <string>
 #include <unordered_map>
 #include <vector>

src/common/Threading/MPSCQueue.h

@@ -19,7 +19,6 @@
 #define MPSCQueue_h__
 
 #include <atomic>
-#include <memory>
 
 namespace Acore::Impl
 {

src/common/Utilities/ByteConverter.h

@@ -23,7 +23,7 @@
  */
 
 #include "Define.h"
-#include <algorithm>
+#include <vector>
 
 namespace ByteConverter
 {

src/common/Utilities/IteratorPair.h

@@ -18,7 +18,7 @@
 #ifndef IteratorPair_h__
 #define IteratorPair_h__
 
-#include <utility>
+#include <vector> // NOTE: this import is NEEDED (even though some IDEs report it as unused)
 
 namespace Acore
 {

src/common/Utilities/SFMTRand.cpp

@@ -17,8 +17,8 @@
 
 #include "SFMTRand.h"
 #include "Timer.h"
+#include <algorithm>
 #include <array>
-#include <functional>
 #include <random>
 
 #if defined(__aarch64__)

src/common/Utilities/SmartEnum.h

@@ -19,7 +19,6 @@
 #define AC_SMARTENUM_H
 
 #include "IteratorPair.h"
-#include <iterator>
 
 struct EnumText
 {