From 4d1dba4a09fee6bd097f57023d341f34dd3c5e87 Mon Sep 17 00:00:00 2001 From: Exitare Date: Wed, 18 Dec 2024 16:58:32 -0800 Subject: [PATCH] fix(Core/Player): Quest failure sound when inventory full (#20970) * Add quest failure sound when inventory is full or quest failed * Fix sound being played for all players & move call to correct function --- src/server/game/Entities/Player/PlayerQuest.cpp | 1 + src/server/game/Entities/Player/PlayerStorage.cpp | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/game/Entities/Player/PlayerQuest.cpp b/src/server/game/Entities/Player/PlayerQuest.cpp index ef2bbb9ed..679c59ca5 100644 --- a/src/server/game/Entities/Player/PlayerQuest.cpp +++ b/src/server/game/Entities/Player/PlayerQuest.cpp @@ -279,6 +279,7 @@ bool Player::CanAddQuest(Quest const* quest, bool msg) else if (msg2 != EQUIP_ERR_OK) { SendEquipError(msg2, nullptr, nullptr, srcitem); + PlayDirectSound(QUEST_SOUND_FAILURE, this); // Play failure sound return false; } } diff --git a/src/server/game/Entities/Player/PlayerStorage.cpp b/src/server/game/Entities/Player/PlayerStorage.cpp index ce2f55ca5..8c7b9da6f 100644 --- a/src/server/game/Entities/Player/PlayerStorage.cpp +++ b/src/server/game/Entities/Player/PlayerStorage.cpp @@ -4059,7 +4059,6 @@ void Player::SendEquipError(InventoryResult msg, Item* pItem, Item* pItem2, uint } } GetSession()->SendPacket(&data); - PlayDirectSound(QUEST_SOUND_FAILURE); // Play failure sound } void Player::SendBuyError(BuyResult msg, Creature* creature, uint32 item, uint32 param)