From 4bc373b37f149dac41edfbbe9a37fe9088ea34de Mon Sep 17 00:00:00 2001 From: Mike Delago <32778141+michaeldelago@users.noreply.github.com> Date: Fri, 29 Mar 2024 21:35:30 -0400 Subject: [PATCH] Fix(CI): Don't use PCH on nopch builds (#18627) gha yaml makes me want to scream --- .github/actions/linux-build/action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/actions/linux-build/action.yml b/.github/actions/linux-build/action.yml index b3edb12ad..3a8fefd77 100644 --- a/.github/actions/linux-build/action.yml +++ b/.github/actions/linux-build/action.yml @@ -100,8 +100,8 @@ runs: -DCMAKE_CXX_COMPILER_LAUNCHER="ccache" \ -DCMAKE_C_COMPILER_LAUNCHER="ccache" \ -DBUILD_TESTING="ON" \ - -DUSE_SCRIPTPCH=${{ inputs.pch && 'ON' || '' }} \ - -DUSE_COREPCH=${{ inputs.pch && 'ON' || '' }} \ + -DUSE_SCRIPTPCH=${{ inputs.pch == 'true' && 'ON' || '' }} \ + -DUSE_COREPCH=${{ inputs.pch == 'true' && 'ON' || '' }} \ ${{ !inputs.pch && '-DNOPCH=true' || '' }} - name: build