From 47fad16967da5facc6c0e8978a8cdde3fe8d57dd Mon Sep 17 00:00:00 2001
From: Silker <61223313+Si1ker@users.noreply.github.com>
Date: Wed, 24 Mar 2021 13:49:53 -0600
Subject: [PATCH] feat(IssueTemplate/BugReport): Improve templates and add
 "source" field (#4959)

---
 .github/ISSUE_TEMPLATE/bug_report.md | 73 ++++++++++++++++------------
 pull_request_template.md             | 34 +++++++------
 2 files changed, 62 insertions(+), 45 deletions(-)

diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
index 504f64a6b..43d1ea0e7 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.md
+++ b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -7,24 +7,32 @@ assignees: ''
 
 ---
 
-<!-- IF YOU DO NOT FILL THIS TEMPLATE OUT, WE WILL CLOSE YOUR ISSUE! -->
+<!-- IF YOU DO NOT FILL THIS TEMPLATE OUT, WE WILL CLOSE YOUR ISSUE -->
 
-<!-- This template is for problem reports, for feature suggestion etc... feel free to edit it.
- If this is a crash report, upload the crashlog on https://gist.github.com/
- For issues containing a fix, please create a Pull Request following this tutorial: http://www.azerothcore.org/wiki/Contribute#how-to-create-a-pull-request -->
-
-
-<!-- WRITE A RELEVANT TITLE -->
+<!-- This template is for problem reports. If this is a crash report, upload the crash log on https://gist.github.com/
+ For issues containing a fix, please create a Pull Request following this tutorial: https://www.azerothcore.org/wiki/How-to-create-a-PR -->
 
 
 ##### CURRENT BEHAVIOUR:
-<!-- Describe the bug in detail. Database to link spells, NPCs, quests etc https://wowgaming.altervista.org/aowow/ -->
+<!-- Describe the bug or issue in detail, if it includes any quest/spell/item/NPC/object from the game, please use database links from https://wowgaming.altervista.org/aowow/ 
+-->
 
 
 
 
 ##### EXPECTED BLIZZLIKE BEHAVIOUR:
-<!-- Describe how it should be working without the bug. -->
+<!-- Describe how it should be working without the bug/issue 
+-->
+
+
+
+
+##### SOURCE:
+<!-- If this report is linked with in-game content, please include any evidence/documentation/video or further proof in order to guarantee that the behavior described above is the correct one.
+ - If it is described in a guide/post or Wowhead comment, please include the link.
+ - Can you link a video that confirms it?
+ - Please share the source which states how it should work.
+-->
 
 
 
@@ -34,48 +42,51 @@ assignees: ''
  - Which commands to use? Which NPC to teleport to?
  - Do we need to have debug flags on Cmake?
  - Do we need to look at the console while the bug happens?
- - Other steps
--->
+ - Describe as much as possible how to detect or check the bug -->
 
 1. 
 2. 
 3. 
 
 ##### EXTRA NOTES:
-<!--
-Any information that can help the developers to identify and fix the issue should be put here.
+<!-- Please share any additional information that can help the developers to identify and fix the issue.
 Examples:
-- was this bug always present in AzerothCore? if it was introduced after a change, please mention it
-- the code line(s) that cause the issue
-- does this feature work in other server applications (e.g. CMaNGOS, TrinityCore, etc...) ?
+- Was this bug always present in AzerothCore? if no, from which change/commit it started?
+- Is there any code line(s) causing the bug/issue?
+- Does this feature work in other server applications like CMaNGOS or TrinityCore? 
 -->
 
 
 
 
-
-
 ##### AC HASH/COMMIT:
 <!-- IF YOU DO NOT FILL THIS OUT, WE WILL CLOSE YOUR ISSUE! NEVER WRITE "LATEST", ALWAYS PUT THE ACTUAL VALUE INSTEAD.
-Find the commit hash (unique identifier) by running "git log" on your own clone of AzerothCore or by looking at here https://github.com/azerothcore/azerothcore-wotlk/commits/master -->
+Find the commit hash (unique identifier) by running "git log" on your own clone of AzerothCore or by looking at here https://github.com/azerothcore/azerothcore-wotlk/commits/master 
+-->
+
 
 
 
 ##### OPERATING SYSTEM:
-<!-- Windows 7/10, Debian 8/9/10, Ubuntu 16/18 etc... -->
+<!-- On which operating system the bug/issue was found?
+ Examples: Windows 7/10, Debian 8/9/10, Ubuntu 16/18 or macOS 10/11 
+ -->
+
 
 
 
 ##### MODULES:
-<!-- Are you using modules? If yes, list them (note them down in a .txt for opening future issues) -->
+<!-- Are you using modules? if yes, please list them all 
+-->
 
 
 
-##### OTHER CUSTOMIZATIONS:
-<!-- Are you using any extra script?
+
+##### CUSTOMIZATIONS:
+<!-- Are you using any extra content that could affect your client/server?
  - Did you apply any core patch/diff?
  - Did you modify your database?
- - Or do you have other customizations? If yes please specify them here.
+ - Do you have any other client/server customizations? If yes please specify them here 
 -->
 
 
@@ -84,12 +95,12 @@ Find the commit hash (unique identifier) by running "git log" on your own clone
 <!-- ------------------------- THE END ------------------------------
 Thank you for your contribution.
 If you use AzerothCore regularly, we really NEED your help to:
- - TEST our fixes ( http://www.azerothcore.org/wiki/Contribute#how-to-test-a-pull-request )
- - Report issues
- - Improve the documentation/wiki
-With your help the project can evolve much quicker!
--->
+ - Test our fixes: https://www.azerothcore.org/wiki/How-to-test-a-PR
+ - Report issues or suggestions: https://github.com/azerothcore/azerothcore-wotlk/issues/new/choose
+ - Improve the documentation/wiki: https://www.azerothcore.org/wiki/home
+With your help, the project can evolve much quicker! -->
 
 
-<!-- NOTE: If you intend to contribute more than once, you should really join us on our discord channel! We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! The link is on our site http://azerothcore.org/
--->
+<!-- NOTE
+If you intend to contribute repeatedly to our project, it is a good idea to join our discord channel.
+We set ranks for our contributors and give them access to special resources or knowledge: https://discord.com/invite/DasJqPba -->
diff --git a/pull_request_template.md b/pull_request_template.md
index 3b5652e6a..4473bb8e9 100644
--- a/pull_request_template.md
+++ b/pull_request_template.md
@@ -1,9 +1,7 @@
 <!-- First of all, THANK YOU for your contribution.
- Please fill this template unless your PR is very simple/straightforward.
- Do not forget to have a look at our Pull Request tutorial: http://www.azerothcore.org/wiki/Contribute#how-to-create-a-pull-request
+ Please fill this template and do not forget to have a look at our Pull Request tutorial: https://www.azerothcore.org/wiki/How-to-create-a-PR
 -->
 
-<!-- WRITE A RELEVANT TITLE -->
 
 ## Changes Proposed:
 -  
@@ -12,21 +10,29 @@
 
 ## Issues Addressed:
 - Closes 
-<!-- If the issue doesn't exist, describe it and how to reproduce it, please. If the issue already exists, just paste the link to the issue you close, like this: Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 -->
+<!-- If the issue does not exist, please describe it and how to reproduce it. If the issue already exists, just paste the link to the issue you close, like this: Closes https://github.com/azerothcore/azerothcore-wotlk/issues/967 -->
+
+
+##### SOURCE:
+<!-- If this report is linked with in-game content, please include any evidence/documentation/video or further proof in order to guarantee that the behavior described above is the correct one.
+ - If it is described in a guide/post or Wowhead comment, please include the link.
+ - Can you link a video that confirms it?
+ - Please share the source which states how it should work.
+-->
 
 
 ## Tests Performed:
--
--
-<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux, Mac or Windows? Other tests performed -->
+<!-- Does it build without errors? Did you test in-game? What did you test? Did you do all these tests on Linux/Mac/Windows? Describe any other tests performed -->
+- 
+- 
 
 
 ## How to Test the Changes:
-<!-- We need to confirm the changes first, so try to make the work easy for testers (who are not necessarily coders), please:
+<!-- We need to confirm the changes are going to be working, so please describe in general and for non-developers how to test the changes:
  - Which commands to use? Which NPC to teleport to?
  - Do we need to enable debug flags on Cmake?
- - Do we need to look at the console? etc...
- - Other steps
+ - Do we need to look at the console?
+ - Describe any other steps
 -->
 
 
@@ -40,10 +46,10 @@
 - [x] Master
 
 
-<!-- NOTE: You do not need to squash your commits, on merge we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy to read history). -->
+<!-- NOTES: 
+ - You do not need to squash your commits, on merge, we will squash them for you (when there are too many commits we merge them into one big commit for a cleaner and easy-to-read history).
+ - If you intend to contribute repeatedly to our project, it is a good idea to join our discord channel. We set ranks for our contributors and give them access to special resources or knowledge: https://discord.com/invite/DasJqPba -->
 
-<!-- NOTE2: If you intend to contribute more than once, you should really join us on our discord channel!
- The link is on our site http://azerothcore.org/ We set cosmetic ranks for our contributors and may give access to special resources/knowledge to them! -->
 
 
 <!-- Do not remove the instructions below about testing, they will help users to test your PR -->
@@ -52,6 +58,6 @@
  
 When a PR is ready to be tested, it will be marked as **[WAITING TO BE TESTED]**.
 
-You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:
+You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
 
 http://www.azerothcore.org/wiki/How-to-test-a-PR