refactor(Scripts/Creature): convert pets into new system (#9046)

2026-01-16 02:20:27 +00:00 · 2021-11-09 11:44:09 +01:00
parent 6654b98312
commit 47c44d74c3
5 changed files with 867 additions and 1076 deletions
--- a/src/server/scripts/Pet/pet_mage.cpp
+++ b/src/server/scripts/Pet/pet_mage.cpp
@@ -53,182 +53,171 @@ private:
    Creature& _owner;
 };

-class npc_pet_mage_mirror_image : public CreatureScript
+struct npc_pet_mage_mirror_image : CasterAI
 {
-public:
-    npc_pet_mage_mirror_image() : CreatureScript("npc_pet_mage_mirror_image") { }
+    npc_pet_mage_mirror_image(Creature* creature) : CasterAI(creature) { }

-    struct npc_pet_mage_mirror_imageAI : CasterAI
+    uint32 selectionTimer;
+    ObjectGuid _ebonGargoyleGUID;
+    uint32 checktarget;
+    uint32 dist = urand(1, 5);
+
+    void InitializeAI() override
    {
-        npc_pet_mage_mirror_imageAI(Creature* creature) : CasterAI(creature) { }
+        CasterAI::InitializeAI();
+        Unit* owner = me->GetOwner();
+        if (!owner)
+            return;

-        uint32 selectionTimer;
-        ObjectGuid _ebonGargoyleGUID;
-        uint32 checktarget;
-        uint32 dist = urand(1, 5);
+        // Clone Me!
+        owner->CastSpell(me, SPELL_MAGE_CLONE_ME, true);

-        void InitializeAI() override
+        // xinef: Glyph of Mirror Image (4th copy)
+        float angle = 0.0f;
+        switch (me->GetUInt32Value(UNIT_CREATED_BY_SPELL))
        {
-            CasterAI::InitializeAI();
-            Unit* owner = me->GetOwner();
-            if (!owner)
-                return;
+            case SPELL_SUMMON_MIRROR_IMAGE1:
+                angle = 0.5f * M_PI;
+                break;
+            case SPELL_SUMMON_MIRROR_IMAGE2:
+                angle = M_PI;
+                break;
+            case SPELL_SUMMON_MIRROR_IMAGE3:
+                angle = 1.5f * M_PI;
+                break;
+        }

-            // Clone Me!
-            owner->CastSpell(me, SPELL_MAGE_CLONE_ME, true);
+        ((Minion*)me)->SetFollowAngle(angle);
+        if (owner->IsInCombat())
+            me->NearTeleportTo(me->GetPositionX() + cos(angle)*dist, me->GetPositionY() + sin(angle)*dist, me->GetPositionZ(), me->GetOrientation(), false, false, false, false);
+        else
+            me->GetMotionMaster()->MoveFollow(owner, PET_FOLLOW_DIST, me->GetFollowAngle(), MOTION_SLOT_ACTIVE);

-            // xinef: Glyph of Mirror Image (4th copy)
-            float angle = 0.0f;
-            switch (me->GetUInt32Value(UNIT_CREATED_BY_SPELL))
+        me->SetReactState(REACT_DEFENSIVE);
+
+        // Xinef: Inherit Master's Threat List (not yet implemented)
+        //owner->CastSpell((Unit*)nullptr, SPELL_MAGE_MASTERS_THREAT_LIST, true);
+        HostileReference* ref = owner->getHostileRefMgr().getFirst();
+        while (ref)
+        {
+            if (Unit* unit = ref->GetSource()->GetOwner())
+                unit->AddThreat(me, ref->getThreat() - ref->getTempThreatModifier());
+            ref = ref->next();
+        }
+
+        _ebonGargoyleGUID.Clear();
+
+        // Xinef: copy caster auras
+        Unit::VisibleAuraMap const* visibleAuraMap = owner->GetVisibleAuras();
+        for (Unit::VisibleAuraMap::const_iterator itr = visibleAuraMap->begin(); itr != visibleAuraMap->end(); ++itr)
+            if (Aura* visAura = itr->second->GetBase())
            {
-                case SPELL_SUMMON_MIRROR_IMAGE1:
-                    angle = 0.5f * M_PI;
-                    break;
-                case SPELL_SUMMON_MIRROR_IMAGE2:
-                    angle = M_PI;
-                    break;
-                case SPELL_SUMMON_MIRROR_IMAGE3:
-                    angle = 1.5f * M_PI;
-                    break;
+                // Ebon Gargoyle
+                if (visAura->GetId() == 49206 && me->GetUInt32Value(UNIT_CREATED_BY_SPELL) == SPELL_SUMMON_MIRROR_IMAGE1)
+                {
+                    if (Unit* gargoyle = visAura->GetCaster())
+                        _ebonGargoyleGUID = gargoyle->GetGUID();
+                    continue;
+                }
+                SpellScriptsBounds bounds = sObjectMgr->GetSpellScriptsBounds(visAura->GetId());
+                if (bounds.first != bounds.second)
+                    continue;
+                std::vector<int32> const* spellTriggered = sSpellMgr->GetSpellLinked(visAura->GetId() + SPELL_LINK_AURA);
+                if (!spellTriggered || !spellTriggered->empty())
+                    continue;
+                if (Aura* newAura = me->AddAura(visAura->GetId(), me))
+                    newAura->SetDuration(visAura->GetDuration());
            }

-            ((Minion*)me)->SetFollowAngle(angle);
-            if (owner->IsInCombat())
-                me->NearTeleportTo(me->GetPositionX() + cos(angle)*dist, me->GetPositionY() + sin(angle)*dist, me->GetPositionZ(), me->GetOrientation(), false, false, false, false);
-            else
-                me->GetMotionMaster()->MoveFollow(owner, PET_FOLLOW_DIST, me->GetFollowAngle(), MOTION_SLOT_ACTIVE);
+        me->m_Events.AddEvent(new DeathEvent(*me), me->m_Events.CalculateTime(29500));
+    }

-            me->SetReactState(REACT_DEFENSIVE);
+    // Do not reload Creature templates on evade mode enter - prevent visual lost
+    void EnterEvadeMode() override
+    {
+        if (me->IsInEvadeMode() || !me->IsAlive())
+            return;

-            // Xinef: Inherit Master's Threat List (not yet implemented)
-            //owner->CastSpell((Unit*)nullptr, SPELL_MAGE_MASTERS_THREAT_LIST, true);
-            HostileReference* ref = owner->getHostileRefMgr().getFirst();
-            while (ref)
-            {
-                if (Unit* unit = ref->GetSource()->GetOwner())
-                    unit->AddThreat(me, ref->getThreat() - ref->getTempThreatModifier());
-                ref = ref->next();
-            }
+        Unit* owner = me->GetCharmerOrOwner();

+        me->CombatStop(true);
+        if (owner && !me->HasUnitState(UNIT_STATE_FOLLOW))
+        {
+            me->GetMotionMaster()->Clear(false);
+            me->GetMotionMaster()->MoveFollow(owner, PET_FOLLOW_DIST, me->GetFollowAngle(), MOTION_SLOT_ACTIVE);
+        }
+    }
+
+    void MySelectNextTarget()
+    {
+        if (_ebonGargoyleGUID)
+        {
+            Unit* gargoyle = ObjectAccessor::GetUnit(*me, _ebonGargoyleGUID);
+            if (gargoyle && gargoyle->GetAI())
+                gargoyle->GetAI()->AttackStart(me);
            _ebonGargoyleGUID.Clear();
-
-            // Xinef: copy caster auras
-            Unit::VisibleAuraMap const* visibleAuraMap = owner->GetVisibleAuras();
-            for (Unit::VisibleAuraMap::const_iterator itr = visibleAuraMap->begin(); itr != visibleAuraMap->end(); ++itr)
-                if (Aura* visAura = itr->second->GetBase())
-                {
-                    // Ebon Gargoyle
-                    if (visAura->GetId() == 49206 && me->GetUInt32Value(UNIT_CREATED_BY_SPELL) == SPELL_SUMMON_MIRROR_IMAGE1)
-                    {
-                        if (Unit* gargoyle = visAura->GetCaster())
-                            _ebonGargoyleGUID = gargoyle->GetGUID();
-                        continue;
-                    }
-                    SpellScriptsBounds bounds = sObjectMgr->GetSpellScriptsBounds(visAura->GetId());
-                    if (bounds.first != bounds.second)
-                        continue;
-                    std::vector<int32> const* spellTriggered = sSpellMgr->GetSpellLinked(visAura->GetId() + SPELL_LINK_AURA);
-                    if (!spellTriggered || !spellTriggered->empty())
-                        continue;
-                    if (Aura* newAura = me->AddAura(visAura->GetId(), me))
-                        newAura->SetDuration(visAura->GetDuration());
-                }
-
-            me->m_Events.AddEvent(new DeathEvent(*me), me->m_Events.CalculateTime(29500));
        }
-
-        // Do not reload Creature templates on evade mode enter - prevent visual lost
-        void EnterEvadeMode() override
+        Unit* owner = me->GetOwner();
+        if (owner && owner->GetTypeId() == TYPEID_PLAYER)
        {
-            if (me->IsInEvadeMode() || !me->IsAlive())
-                return;
+            Unit* selection = owner->ToPlayer()->GetSelectedUnit();

-            Unit* owner = me->GetCharmerOrOwner();
-
-            me->CombatStop(true);
-            if (owner && !me->HasUnitState(UNIT_STATE_FOLLOW))
+            if (selection)
            {
-                me->GetMotionMaster()->Clear(false);
-                me->GetMotionMaster()->MoveFollow(owner, PET_FOLLOW_DIST, me->GetFollowAngle(), MOTION_SLOT_ACTIVE);
+                me->getThreatMgr().resetAllAggro();
+                me->AddThreat(selection, 1000000.0f);
+
+                if (owner->IsInCombat())
+                    AttackStart(selection);
            }
+
+            if (!owner->IsInCombat() && !me->GetVictim())
+                EnterEvadeMode();
+        }
+    }
+
+    void Reset() override
+    {
+        selectionTimer = 0;
+        checktarget = 0;
+    }
+
+    void UpdateAI(uint32 diff) override
+    {
+        events.Update(diff);
+        if (events.GetTimer() < 1200)
+            return;
+
+        if (!me->IsInCombat() || !me->GetVictim())
+        {
+            MySelectNextTarget();
+            return;
        }

-        void MySelectNextTarget()
+        checktarget += diff;
+
+        if (checktarget >= 1000)
        {
-            if (_ebonGargoyleGUID)
-            {
-                Unit* gargoyle = ObjectAccessor::GetUnit(*me, _ebonGargoyleGUID);
-                if (gargoyle && gargoyle->GetAI())
-                    gargoyle->GetAI()->AttackStart(me);
-                _ebonGargoyleGUID.Clear();
-            }
-            Unit* owner = me->GetOwner();
-            if (owner && owner->GetTypeId() == TYPEID_PLAYER)
-            {
-                Unit* selection = owner->ToPlayer()->GetSelectedUnit();
-
-                if (selection)
-                {
-                    me->getThreatMgr().resetAllAggro();
-                    me->AddThreat(selection, 1000000.0f);
-
-                    if (owner->IsInCombat())
-                        AttackStart(selection);
-                }
-
-                if (!owner->IsInCombat() && !me->GetVictim())
-                    EnterEvadeMode();
-            }
-        }
-
-        void Reset() override
-        {
-            selectionTimer = 0;
-            checktarget = 0;
-        }
-
-        void UpdateAI(uint32 diff) override
-        {
-            events.Update(diff);
-            if (events.GetTimer() < 1200)
-                return;
-
-            if (!me->IsInCombat() || !me->GetVictim())
+            if (me->GetVictim()->HasBreakableByDamageCrowdControlAura() || !me->GetVictim()->IsAlive())
            {
                MySelectNextTarget();
+                me->InterruptNonMeleeSpells(true); // Stop casting if target is CC or not Alive.
                return;
            }
-
-            checktarget += diff;
-
-            if (checktarget >= 1000)
-            {
-                if (me->GetVictim()->HasBreakableByDamageCrowdControlAura() || !me->GetVictim()->IsAlive())
-                {
-                    MySelectNextTarget();
-                    me->InterruptNonMeleeSpells(true); // Stop casting if target is CC or not Alive.
-                    return;
-                }
-            }
-
-            if (me->HasUnitState(UNIT_STATE_CASTING))
-                return;
-
-            if (uint32 spellId = events.ExecuteEvent())
-            {
-                events.RescheduleEvent(spellId, spellId == 59637 ? 6500 : 2500);
-                me->CastSpell(me->GetVictim(), spellId, false);
-            }
        }
-    };

-    CreatureAI* GetAI(Creature* creature) const override
-    {
-        return new npc_pet_mage_mirror_imageAI(creature);
+        if (me->HasUnitState(UNIT_STATE_CASTING))
+            return;
+
+        if (uint32 spellId = events.ExecuteEvent())
+        {
+            events.RescheduleEvent(spellId, spellId == 59637 ? 6500 : 2500);
+            me->CastSpell(me->GetVictim(), spellId, false);
+        }
    }
 };

 void AddSC_mage_pet_scripts()
 {
-    new npc_pet_mage_mirror_image();
+    RegisterCreatureAI(npc_pet_mage_mirror_image);
 }