nchebrov/azerothcore-wotlk
1
0
Fork 0
mirror of https://github.com/mod-playerbots/azerothcore-wotlk.git synced 2026-01-18 11:25:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Core/ObjectGuid): prevent creating copies when looping objects (#6852)

Browse Source
This commit is contained in:
Francesco Borzì
2021-07-10 15:54:16 +02:00
committed by GitHub
parent 2fcafa5f39
commit 4103fca5a4
40 changed files with 69 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/scripts/EasternKingdoms/BlackrockMountain/BlackwingLair/instance_blackwing_lair.cpp
View File

@@ -169,7 +169,7 @@ public:
case DATA_RAZORGORE_THE_UNTAMED:
if (state == DONE)
{
for (ObjectGuid const guid : EggList)
for (ObjectGuid const& guid : EggList)
if (GameObject* egg = instance->GetGameObject(guid))
egg->SetPhaseMask(2, true);
}

2
src/server/scripts/EasternKingdoms/SunkenTemple/instance_sunken_temple.cpp
View File

@@ -96,7 +96,7 @@ public:
}
break;
case DATA_ERANIKUS_FIGHT:
for (ObjectGuid const guid : _dragonkinList)
for (ObjectGuid const& guid : _dragonkinList)
{
if (Creature* creature = instance->GetCreature(guid))
if (instance->IsGridLoaded(creature->GetPositionX(), creature->GetPositionY()))

4
src/server/scripts/EasternKingdoms/zone_undercity.cpp
View File

@@ -1086,7 +1086,7 @@ public:
}
}
for (ObjectGuid const guid : allianceGuardsGUID)
for (ObjectGuid const& guid : allianceGuardsGUID)
if (Creature* temp = ObjectAccessor::GetCreature(*me, guid))
temp->DespawnOrUnsummon();
@@ -2415,7 +2415,7 @@ public:
SaurfangGUID.Clear();
}
for (ObjectGuid const guid : hordeGuardsGUID)
for (ObjectGuid const& guid : hordeGuardsGUID)
if (Creature* temp = ObjectAccessor::GetCreature(*me, guid))
temp->DespawnOrUnsummon();