refactor(Core): apply clang-tidy modernize-use-equals-default (#3834)

src/common/Collision/Management/IVMapManager.h

@@ -39,7 +39,7 @@ namespace VMAP
     public:
         IVMapManager() : iEnableLineOfSightCalc(true), iEnableHeightCalc(true) { }
 
-        virtual ~IVMapManager() { }
+        virtual ~IVMapManager() = default;
 
         virtual int loadMap(const char* pBasePath, unsigned int pMapId, int x, int y) = 0;
 

src/common/Database/DatabaseWorkerPool.h

@@ -38,7 +38,7 @@ public:
     /* Activity state */
     DatabaseWorkerPool();
 
-    ~DatabaseWorkerPool() { }
+    ~DatabaseWorkerPool() = default;
 
     bool Open(const std::string& infoString, uint8 async_threads, uint8 synch_threads);
 

src/common/Database/MySQLConnection.h

@@ -27,7 +27,7 @@ enum ConnectionFlags
 
 struct MySQLConnectionInfo
 {
-    MySQLConnectionInfo() { }
+    MySQLConnectionInfo() = default;
     MySQLConnectionInfo(const std::string& infoString)
     {
         Tokenizer tokens(infoString, ';');

src/common/Database/QueryHolder.h

@@ -16,7 +16,7 @@ private:
     typedef std::pair<SQLElementData, SQLResultSetUnion> SQLResultPair;
     std::vector<SQLResultPair> m_queries;
 public:
-    SQLQueryHolder() { }
+    SQLQueryHolder() = default;
     ~SQLQueryHolder();
     bool SetQuery(size_t index, const char* sql);
     bool SetPQuery(size_t index, const char* format, ...) ATTR_PRINTF(3, 4);

src/common/Database/Transaction.h

@@ -49,7 +49,7 @@ class TransactionTask : public SQLOperation
 
 public:
     TransactionTask(SQLTransaction trans) : m_trans(trans) { } ;
-    ~TransactionTask() override { };
+    ~TransactionTask() override = default;
 
 protected:
     bool Execute() override;

src/common/Dynamic/LinkedReference/RefManager.h

@@ -15,7 +15,7 @@ template <class TO, class FROM> class RefManager : public LinkedListHead
 {
 public:
     typedef LinkedListHead::Iterator< Reference<TO, FROM>> iterator;
-    RefManager() { }
+    RefManager() = default;
     virtual ~RefManager() { clearReferences(); }
 
     Reference<TO, FROM>* getFirst() { return ((Reference<TO, FROM>*) LinkedListHead::getFirst()); }

src/common/Dynamic/LinkedReference/Reference.h

@@ -28,7 +28,7 @@ protected:
     virtual void sourceObjectDestroyLink() = 0;
 public:
     Reference() { iRefTo = nullptr; iRefFrom = nullptr; }
-    virtual ~Reference() { }
+    virtual ~Reference() = default;
 
     // Create new link
     void link(TO* toObj, FROM* fromObj)

src/common/Packets/ByteBuffer.h

@@ -22,7 +22,7 @@
 class ByteBufferException : public std::exception
 {
 public:
-    ~ByteBufferException() noexcept override { }
+    ~ByteBufferException() noexcept override = default;
 
     [[nodiscard]] char const* what() const noexcept override { return msg_.c_str(); }
 
@@ -37,15 +37,14 @@ class ByteBufferPositionException : public ByteBufferException
 {
 public:
     ByteBufferPositionException(bool add, size_t pos, size_t size, size_t valueSize);
-    ~ByteBufferPositionException() noexcept override { }
+    ~ByteBufferPositionException() noexcept override = default;
 };
 
 class ByteBufferSourceException : public ByteBufferException
 {
 public:
     ByteBufferSourceException(size_t pos, size_t size, size_t valueSize);
-
-    ~ByteBufferSourceException() noexcept override { }
+    ~ByteBufferSourceException() noexcept override = default;
 };
 
 class ByteBuffer

src/common/Threading/LockedQueue.h

@@ -36,9 +36,7 @@ namespace ACE_Based
         }
 
         //! Destroy a LockedQueue.
-        virtual ~LockedQueue()
-        {
-        }
+        virtual ~LockedQueue() = default;
 
         //! Adds an item to the queue.
         void add(const T& item)

src/common/Threading/Threading.h

@@ -18,7 +18,7 @@ namespace acore
     class Runnable
     {
     public:
-        virtual ~Runnable() {}
+        virtual ~Runnable() = default;
         virtual void run() = 0;
 
         void incReference() { ++m_refs; }

src/common/Utilities/EventProcessor.h

@@ -22,7 +22,7 @@ public:
         m_addTime = 0;
         m_execTime = 0;
     }
-    virtual ~BasicEvent() { }                           // override destructor to perform some actions on event removal
+    virtual ~BasicEvent() = default;                           // override destructor to perform some actions on event removal
 
     // this method executes when the event is triggered
     // return false if event does not want to be deleted